* [Buildroot] [PATCH 1/1] docs/manual/adding-packages-cargo.txt: drop debug profile
@ 2020-08-24 7:09 Fabrice Fontaine
2020-08-24 9:06 ` Yann E. MORIN
2020-08-28 17:08 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2020-08-24 7:09 UTC (permalink / raw)
To: buildroot
There is no debug profile on cargo. The available profiles are: dev
(enabled by default), release, test and bench.
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
docs/manual/adding-packages-cargo.txt | 41 +++++++++++++--------------
1 file changed, 20 insertions(+), 21 deletions(-)
diff --git a/docs/manual/adding-packages-cargo.txt b/docs/manual/adding-packages-cargo.txt
index bb078b6981..8fcc80bcc6 100644
--- a/docs/manual/adding-packages-cargo.txt
+++ b/docs/manual/adding-packages-cargo.txt
@@ -47,32 +47,31 @@ package. Let's start with an example:
13: FOO_DEPENDENCIES = host-rustc
14:
15: FOO_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
-16: FOO_CARGO_MODE = $(if $(BR2_ENABLE_DEBUG),debug,release)
-17:
-18: FOO_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(FOO_CARGO_MODE)
-19:
-20: FOO_CARGO_OPTS = \
-21: --$(FOO_CARGO_MODE) \
-22: --target=$(RUSTC_TARGET_NAME) \
-23: --manifest-path=$(@D)/Cargo.toml
-24:
-25: define FOO_BUILD_CMDS
-26: $(TARGET_MAKE_ENV) $(FOO_CARGO_ENV) \
-27: cargo build $(FOO_CARGO_OPTS)
-28: endef
-29:
-30: define FOO_INSTALL_TARGET_CMDS
-31: $(INSTALL) -D -m 0755 $(@D)/$(FOO_BIN_DIR)/foo \
-32: $(TARGET_DIR)/usr/bin/foo
-33: endef
-34:
-35: $(eval $(generic-package))
+16:
+17: FOO_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(FOO_CARGO_MODE)
+18:
+19: FOO_CARGO_OPTS = \
+20: $(if $(BR2_ENABLE_DEBUG),,--release) \
+21: --target=$(RUSTC_TARGET_NAME) \
+22: --manifest-path=$(@D)/Cargo.toml
+23:
+24: define FOO_BUILD_CMDS
+25: $(TARGET_MAKE_ENV) $(FOO_CARGO_ENV) \
+26: cargo build $(FOO_CARGO_OPTS)
+27: endef
+28:
+29: define FOO_INSTALL_TARGET_CMDS
+30: $(INSTALL) -D -m 0755 $(@D)/$(FOO_BIN_DIR)/foo \
+31: $(TARGET_DIR)/usr/bin/foo
+32: endef
+33:
+34: $(eval $(generic-package))
--------------------------------
The Makefile starts with the definition of the standard variables for package
declaration (lines 7 to 11).
-As seen in line 35, it is based on the
+As seen in line 34, it is based on the
xref:generic-package-tutorial[+generic-package+ infrastructure]. So, it defines
the variables required by this particular infrastructure, where Cargo is
invoked:
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] docs/manual/adding-packages-cargo.txt: drop debug profile
2020-08-24 7:09 [Buildroot] [PATCH 1/1] docs/manual/adding-packages-cargo.txt: drop debug profile Fabrice Fontaine
@ 2020-08-24 9:06 ` Yann E. MORIN
2020-08-28 17:08 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2020-08-24 9:06 UTC (permalink / raw)
To: buildroot
Fabrice, All,
On 2020-08-24 09:09 +0200, Fabrice Fontaine spake thusly:
> There is no debug profile on cargo. The available profiles are: dev
> (enabled by default), release, test and bench.
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> docs/manual/adding-packages-cargo.txt | 41 +++++++++++++--------------
> 1 file changed, 20 insertions(+), 21 deletions(-)
>
> diff --git a/docs/manual/adding-packages-cargo.txt b/docs/manual/adding-packages-cargo.txt
> index bb078b6981..8fcc80bcc6 100644
> --- a/docs/manual/adding-packages-cargo.txt
> +++ b/docs/manual/adding-packages-cargo.txt
> @@ -47,32 +47,31 @@ package. Let's start with an example:
> 13: FOO_DEPENDENCIES = host-rustc
> 14:
> 15: FOO_CARGO_ENV = CARGO_HOME=$(HOST_DIR)/share/cargo
> -16: FOO_CARGO_MODE = $(if $(BR2_ENABLE_DEBUG),debug,release)
> -17:
> -18: FOO_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(FOO_CARGO_MODE)
> -19:
> -20: FOO_CARGO_OPTS = \
> -21: --$(FOO_CARGO_MODE) \
> -22: --target=$(RUSTC_TARGET_NAME) \
> -23: --manifest-path=$(@D)/Cargo.toml
> -24:
> -25: define FOO_BUILD_CMDS
> -26: $(TARGET_MAKE_ENV) $(FOO_CARGO_ENV) \
> -27: cargo build $(FOO_CARGO_OPTS)
> -28: endef
> -29:
> -30: define FOO_INSTALL_TARGET_CMDS
> -31: $(INSTALL) -D -m 0755 $(@D)/$(FOO_BIN_DIR)/foo \
> -32: $(TARGET_DIR)/usr/bin/foo
> -33: endef
> -34:
> -35: $(eval $(generic-package))
> +16:
> +17: FOO_BIN_DIR = target/$(RUSTC_TARGET_NAME)/$(FOO_CARGO_MODE)
> +18:
> +19: FOO_CARGO_OPTS = \
> +20: $(if $(BR2_ENABLE_DEBUG),,--release) \
> +21: --target=$(RUSTC_TARGET_NAME) \
> +22: --manifest-path=$(@D)/Cargo.toml
> +23:
> +24: define FOO_BUILD_CMDS
> +25: $(TARGET_MAKE_ENV) $(FOO_CARGO_ENV) \
> +26: cargo build $(FOO_CARGO_OPTS)
> +27: endef
> +28:
> +29: define FOO_INSTALL_TARGET_CMDS
> +30: $(INSTALL) -D -m 0755 $(@D)/$(FOO_BIN_DIR)/foo \
> +31: $(TARGET_DIR)/usr/bin/foo
> +32: endef
> +33:
> +34: $(eval $(generic-package))
> --------------------------------
>
> The Makefile starts with the definition of the standard variables for package
> declaration (lines 7 to 11).
>
> -As seen in line 35, it is based on the
> +As seen in line 34, it is based on the
> xref:generic-package-tutorial[+generic-package+ infrastructure]. So, it defines
> the variables required by this particular infrastructure, where Cargo is
> invoked:
> --
> 2.28.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] docs/manual/adding-packages-cargo.txt: drop debug profile
2020-08-24 7:09 [Buildroot] [PATCH 1/1] docs/manual/adding-packages-cargo.txt: drop debug profile Fabrice Fontaine
2020-08-24 9:06 ` Yann E. MORIN
@ 2020-08-28 17:08 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2020-08-28 17:08 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> There is no debug profile on cargo. The available profiles are: dev
> (enabled by default), release, test and bench.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2020.02.x and 2020.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-28 17:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-24 7:09 [Buildroot] [PATCH 1/1] docs/manual/adding-packages-cargo.txt: drop debug profile Fabrice Fontaine
2020-08-24 9:06 ` Yann E. MORIN
2020-08-28 17:08 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox