Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/1] package/easyframes: new package
Date: Sat, 29 Aug 2020 13:48:37 +0200	[thread overview]
Message-ID: <20200829134837.5ffbc3d0@windsurf.home> (raw)
In-Reply-To: <20200829072416.951156-1-horatiu.vultur@microchip.com>

Hello,

On Sat, 29 Aug 2020 09:24:16 +0200
Horatiu Vultur via buildroot <buildroot@busybox.net> wrote:

> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Thanks, I've applied to next, with a few changes, see below.

> diff --git a/package/easyframes/Config.in b/package/easyframes/Config.in
> new file mode 100644
> index 0000000000..f3a4ddbb34
> --- /dev/null
> +++ b/package/easyframes/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_EASYFRAMES
> +	bool "easyframes"
> +	select BR2_PACKAGE_LIBPCAP
> +	help
> +	  This is a small and simple command-line tool for network testing.
> +	  The tool makes it simple to compose a frame, inject and express what
> +	  and where frames are expected to be received.

These lines were too long, so I wrapped them.

> +################################################################################
> +#
> +# easyframes
> +#
> +################################################################################
> +
> +EASYFRAMES_VERSION = v0.3
> +EASYFRAMES_SITE = $(call github,microchip-ung,easyframes,$(EASYFRAMES_VERSION))

I changed this so that the version is just 0.3. Indeed, we want our
_VERSION variable to not have any "v" prefix, so that its value can be
matched against what release-monitoring.org is reporting for upstream
projects.

> +EASYFRAMES_INSTALL_STAGING = YES

I dropped this line, since easyframes does not install a library.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2020-08-29 11:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29  7:24 [Buildroot] [PATCH v4 1/1] package/easyframes: new package Horatiu Vultur
2020-08-29  7:46 ` Asaf Kahlon
2020-08-29 11:48 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200829134837.5ffbc3d0@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox