Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v4 1/1] package/easyframes: new package
@ 2020-08-29  7:24 Horatiu Vultur
  2020-08-29  7:46 ` Asaf Kahlon
  2020-08-29 11:48 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Horatiu Vultur @ 2020-08-29  7:24 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

---
Changes v3 -> v4:
  - update the version
  - remove C++ dependecy

Changes v2 -> v3:
  - add missing changelog

Changes v1 -> v2:
  - add missing comment in easyframes.hash
  - add sha256 for COPYING
  - remove zlib dependency
  - change from using sha to use tag
---
 DEVELOPERS                         |  3 +++
 package/Config.in                  |  1 +
 package/easyframes/Config.in       |  9 +++++++++
 package/easyframes/easyframes.hash |  3 +++
 package/easyframes/easyframes.mk   | 15 +++++++++++++++
 5 files changed, 31 insertions(+)
 create mode 100644 package/easyframes/Config.in
 create mode 100644 package/easyframes/easyframes.hash
 create mode 100644 package/easyframes/easyframes.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 3c3dcda859..96414f5b4b 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1111,6 +1111,9 @@ F:	package/gauche/
 F:	package/gmrender-resurrect/
 F:	package/squeezelite/
 
+N:	Horatiu Vultur <horatiu.vultur@microchip.com>
+F:	package/easyframes/
+
 N:	Ian Haylock <haylocki@yahoo.co.uk>
 F:	package/python-rpi-gpio/
 
diff --git a/package/Config.in b/package/Config.in
index d7e79f4795..3965d523c6 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -2039,6 +2039,7 @@ menu "Networking applications"
 	source "package/dnsmasq/Config.in"
 	source "package/drbd-utils/Config.in"
 	source "package/dropbear/Config.in"
+	source "package/easyframes/Config.in"
 	source "package/ebtables/Config.in"
 	source "package/ejabberd/Config.in"
 	source "package/ethtool/Config.in"
diff --git a/package/easyframes/Config.in b/package/easyframes/Config.in
new file mode 100644
index 0000000000..f3a4ddbb34
--- /dev/null
+++ b/package/easyframes/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_EASYFRAMES
+	bool "easyframes"
+	select BR2_PACKAGE_LIBPCAP
+	help
+	  This is a small and simple command-line tool for network testing.
+	  The tool makes it simple to compose a frame, inject and express what
+	  and where frames are expected to be received.
+
+	  https://github.com/microchip-ung/easyframes
diff --git a/package/easyframes/easyframes.hash b/package/easyframes/easyframes.hash
new file mode 100644
index 0000000000..a0b193ca6e
--- /dev/null
+++ b/package/easyframes/easyframes.hash
@@ -0,0 +1,3 @@
+# locally calculated
+sha256 3c0449b3129c29b5ecf67b689f1a75ffc65fde3c5f62811e2f0439ce4f4af392 easyframes-v0.3.tar.gz
+sha256 24f37598e822a1411fb7164ce7eb3ef120aea8279016399abc282c2381ce3f57 COPYING
diff --git a/package/easyframes/easyframes.mk b/package/easyframes/easyframes.mk
new file mode 100644
index 0000000000..b0ec1ae7e5
--- /dev/null
+++ b/package/easyframes/easyframes.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# easyframes
+#
+################################################################################
+
+EASYFRAMES_VERSION = v0.3
+EASYFRAMES_SITE = $(call github,microchip-ung,easyframes,$(EASYFRAMES_VERSION))
+EASYFRAMES_INSTALL_STAGING = YES
+EASYFRAMES_DEPENDENCIES = libpcap
+
+EASYFRAMES_LICENSE = MIT
+EASYFRAMES_LICENSE_FILES = COPYING
+
+$(eval $(cmake-package))
-- 
2.27.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v4 1/1] package/easyframes: new package
  2020-08-29  7:24 [Buildroot] [PATCH v4 1/1] package/easyframes: new package Horatiu Vultur
@ 2020-08-29  7:46 ` Asaf Kahlon
  2020-08-29 11:48 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Asaf Kahlon @ 2020-08-29  7:46 UTC (permalink / raw)
  To: buildroot

Hello,

On Sat, Aug 29, 2020 at 10:25 AM Horatiu Vultur via buildroot
<buildroot@busybox.net> wrote:
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>
> ---
> Changes v3 -> v4:
>   - update the version
>   - remove C++ dependecy
>
> Changes v2 -> v3:
>   - add missing changelog
>
> Changes v1 -> v2:
>   - add missing comment in easyframes.hash
>   - add sha256 for COPYING
>   - remove zlib dependency
>   - change from using sha to use tag
> ---
>  DEVELOPERS                         |  3 +++
>  package/Config.in                  |  1 +
>  package/easyframes/Config.in       |  9 +++++++++
>  package/easyframes/easyframes.hash |  3 +++
>  package/easyframes/easyframes.mk   | 15 +++++++++++++++
>  5 files changed, 31 insertions(+)
>  create mode 100644 package/easyframes/Config.in
>  create mode 100644 package/easyframes/easyframes.hash
>  create mode 100644 package/easyframes/easyframes.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 3c3dcda859..96414f5b4b 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1111,6 +1111,9 @@ F:        package/gauche/
>  F:     package/gmrender-resurrect/
>  F:     package/squeezelite/
>
> +N:     Horatiu Vultur <horatiu.vultur@microchip.com>
> +F:     package/easyframes/
> +
>  N:     Ian Haylock <haylocki@yahoo.co.uk>
>  F:     package/python-rpi-gpio/
>
> diff --git a/package/Config.in b/package/Config.in
> index d7e79f4795..3965d523c6 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -2039,6 +2039,7 @@ menu "Networking applications"
>         source "package/dnsmasq/Config.in"
>         source "package/drbd-utils/Config.in"
>         source "package/dropbear/Config.in"
> +       source "package/easyframes/Config.in"
>         source "package/ebtables/Config.in"
>         source "package/ejabberd/Config.in"
>         source "package/ethtool/Config.in"
> diff --git a/package/easyframes/Config.in b/package/easyframes/Config.in
> new file mode 100644
> index 0000000000..f3a4ddbb34
> --- /dev/null
> +++ b/package/easyframes/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_EASYFRAMES
> +       bool "easyframes"
> +       select BR2_PACKAGE_LIBPCAP
> +       help
> +         This is a small and simple command-line tool for network testing.
> +         The tool makes it simple to compose a frame, inject and express what
> +         and where frames are expected to be received.
Pay attention to the Config.in file conventions:
http://nightly.buildroot.org/#writing-rules-config-in4 ("make
check-package" validates that).

> +
> +         https://github.com/microchip-ung/easyframes
> diff --git a/package/easyframes/easyframes.hash b/package/easyframes/easyframes.hash
> new file mode 100644
> index 0000000000..a0b193ca6e
> --- /dev/null
> +++ b/package/easyframes/easyframes.hash
> @@ -0,0 +1,3 @@
> +# locally calculated
> +sha256 3c0449b3129c29b5ecf67b689f1a75ffc65fde3c5f62811e2f0439ce4f4af392 easyframes-v0.3.tar.gz
> +sha256 24f37598e822a1411fb7164ce7eb3ef120aea8279016399abc282c2381ce3f57 COPYING
> diff --git a/package/easyframes/easyframes.mk b/package/easyframes/easyframes.mk
> new file mode 100644
> index 0000000000..b0ec1ae7e5
> --- /dev/null
> +++ b/package/easyframes/easyframes.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# easyframes
> +#
> +################################################################################
> +
> +EASYFRAMES_VERSION = v0.3
> +EASYFRAMES_SITE = $(call github,microchip-ung,easyframes,$(EASYFRAMES_VERSION))
> +EASYFRAMES_INSTALL_STAGING = YES
Now I notice that the only file installed with this package is the 'ef binary.
In this case, there's no need to install easyframes to the staging dir.

> +EASYFRAMES_DEPENDENCIES = libpcap
> +
> +EASYFRAMES_LICENSE = MIT
> +EASYFRAMES_LICENSE_FILES = COPYING
> +
> +$(eval $(cmake-package))
> --
> 2.27.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Regards,
Asaf.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v4 1/1] package/easyframes: new package
  2020-08-29  7:24 [Buildroot] [PATCH v4 1/1] package/easyframes: new package Horatiu Vultur
  2020-08-29  7:46 ` Asaf Kahlon
@ 2020-08-29 11:48 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2020-08-29 11:48 UTC (permalink / raw)
  To: buildroot

Hello,

On Sat, 29 Aug 2020 09:24:16 +0200
Horatiu Vultur via buildroot <buildroot@busybox.net> wrote:

> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>

Thanks, I've applied to next, with a few changes, see below.

> diff --git a/package/easyframes/Config.in b/package/easyframes/Config.in
> new file mode 100644
> index 0000000000..f3a4ddbb34
> --- /dev/null
> +++ b/package/easyframes/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_EASYFRAMES
> +	bool "easyframes"
> +	select BR2_PACKAGE_LIBPCAP
> +	help
> +	  This is a small and simple command-line tool for network testing.
> +	  The tool makes it simple to compose a frame, inject and express what
> +	  and where frames are expected to be received.

These lines were too long, so I wrapped them.

> +################################################################################
> +#
> +# easyframes
> +#
> +################################################################################
> +
> +EASYFRAMES_VERSION = v0.3
> +EASYFRAMES_SITE = $(call github,microchip-ung,easyframes,$(EASYFRAMES_VERSION))

I changed this so that the version is just 0.3. Indeed, we want our
_VERSION variable to not have any "v" prefix, so that its value can be
matched against what release-monitoring.org is reporting for upstream
projects.

> +EASYFRAMES_INSTALL_STAGING = YES

I dropped this line, since easyframes does not install a library.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-08-29 11:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-29  7:24 [Buildroot] [PATCH v4 1/1] package/easyframes: new package Horatiu Vultur
2020-08-29  7:46 ` Asaf Kahlon
2020-08-29 11:48 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox