* [Buildroot] [PATCH] libcap: disable GOLANG
@ 2020-08-31 2:16 Tian Yuanhao
2020-08-31 15:15 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Tian Yuanhao @ 2020-08-31 2:16 UTC (permalink / raw)
To: buildroot
libcap is a pure C library before 2.27, it lacks some environment
variables set in pkg-golang.mk.
Signed-off-by: Tian Yuanhao <tianyuanhao@aliyun.com>
---
?package/libcap/libcap.mk | 4 ++--
?1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/libcap/libcap.mk b/package/libcap/libcap.mk
index 08c1bc9..5843ef9 100644
--- a/package/libcap/libcap.mk
+++ b/package/libcap/libcap.mk
@@ -62,12 +62,12 @@ endef
?define HOST_LIBCAP_BUILD_CMDS
???? $(HOST_MAKE_ENV) $(HOST_CONFIGURE_OPTS) $(MAKE) -C $(@D)\
-??? ??? RAISE_SETFCAP=no
+??? ??? GOLANG=no RAISE_SETFCAP=no
?endef
?define HOST_LIBCAP_INSTALL_CMDS
???? $(HOST_MAKE_ENV) $(MAKE) -C $(@D) prefix=$(HOST_DIR) \
-??? ??? RAISE_SETFCAP=no lib=lib install
+??? ??? GOLANG=no RAISE_SETFCAP=no lib=lib install
?endef
?$(eval $(generic-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] libcap: disable GOLANG
2020-08-31 2:16 [Buildroot] [PATCH] libcap: disable GOLANG Tian Yuanhao
@ 2020-08-31 15:15 ` Peter Korsgaard
2020-08-31 16:14 ` Tian Yuanhao
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2020-08-31 15:15 UTC (permalink / raw)
To: buildroot
>>>>> "Tian" == Tian Yuanhao via buildroot <buildroot@busybox.net> writes:
> libcap is a pure C library before 2.27, it lacks some environment
> variables set in pkg-golang.mk.
> Signed-off-by: Tian Yuanhao <tianyuanhao@aliyun.com>
Can you be more specific? What exactly is this fixing? I don't see any
related autobuilder errors?
http://autobuild.buildroot.net/?reason=libcap-2.27
And I don't see any reference to GOLANG in libcap-2.27?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] libcap: disable GOLANG
2020-08-31 15:15 ` Peter Korsgaard
@ 2020-08-31 16:14 ` Tian Yuanhao
2020-08-31 16:24 ` Peter Korsgaard
2020-09-09 20:42 ` Yann E. MORIN
0 siblings, 2 replies; 6+ messages in thread
From: Tian Yuanhao @ 2020-08-31 16:14 UTC (permalink / raw)
To: buildroot
This patch is for the next branch.
Recently, the go infrastructure has changed, and libcap has been
upgraded to 2.42. libcap introduced golang in 2.28, see:
https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/Make.Rules?id=0615d996379dceedefcd65a114f93fefd81c208f
When you compile host-go and then compile host-libcap, GOLANG will be
automatically set to yes. Because libcap.mk lacks golang support,
compilation will fail.
> > libcap is a pure C library before 2.27, it lacks some environment
> > variables set in pkg-golang.mk.
>
> Can you be more specific? What exactly is this fixing? I don't see
> any related autobuilder errors?
>
> http://autobuild.buildroot.net/?reason=libcap-2.27
>
> And I don't see any reference to GOLANG in libcap-2.27?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] libcap: disable GOLANG
2020-08-31 16:14 ` Tian Yuanhao
@ 2020-08-31 16:24 ` Peter Korsgaard
2020-09-09 20:35 ` Joseph Kogut
2020-09-09 20:42 ` Yann E. MORIN
1 sibling, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2020-08-31 16:24 UTC (permalink / raw)
To: buildroot
>>>>> "Tian" == Tian Yuanhao via buildroot <buildroot@busybox.net> writes:
> This patch is for the next branch.
Ahh, then please mention that. An easy way to do that is using the
--subject-prefix argument to git send-email, E.G.:
git send-email --subject-prefix='PATCH-NEXT' ..
> Recently, the go infrastructure has changed, and libcap has been
> upgraded to 2.42. libcap introduced golang in 2.28, see:
> https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/Make.Rules?id=0615d996379dceedefcd65a114f93fefd81c208f
> When you compile host-go and then compile host-libcap, GOLANG will be
> automatically set to yes. Because libcap.mk lacks golang support,
> compilation will fail.
OK.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] libcap: disable GOLANG
2020-08-31 16:24 ` Peter Korsgaard
@ 2020-09-09 20:35 ` Joseph Kogut
0 siblings, 0 replies; 6+ messages in thread
From: Joseph Kogut @ 2020-09-09 20:35 UTC (permalink / raw)
To: buildroot
Hi,
On Mon, Aug 31, 2020 at 9:24 AM Peter Korsgaard <peter@korsgaard.com> wrote:
>
> >>>>> "Tian" == Tian Yuanhao via buildroot <buildroot@busybox.net> writes:
>
> > This patch is for the next branch.
>
> Ahh, then please mention that. An easy way to do that is using the
> --subject-prefix argument to git send-email, E.G.:
>
> git send-email --subject-prefix='PATCH-NEXT' ..
>
> > Recently, the go infrastructure has changed, and libcap has been
> > upgraded to 2.42. libcap introduced golang in 2.28, see:
>
> > https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/Make.Rules?id=0615d996379dceedefcd65a114f93fefd81c208f
>
> > When you compile host-go and then compile host-libcap, GOLANG will be
> > automatically set to yes. Because libcap.mk lacks golang support,
> > compilation will fail.
>
This fixes a build issue with libcap 2.42 when ccache is enabled.
https://gist.github.com/jakogut/3675b4a692da1b87b59056fec71575b4
Minor suggestion, but perhaps we should move these flags to
HOST_LIBCAP_MAKE_FLAGS to mirror how the target package is built?
Regardless,
Tested-by: Joseph Kogut <joseph.kogut@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] libcap: disable GOLANG
2020-08-31 16:14 ` Tian Yuanhao
2020-08-31 16:24 ` Peter Korsgaard
@ 2020-09-09 20:42 ` Yann E. MORIN
1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2020-09-09 20:42 UTC (permalink / raw)
To: buildroot
Tian Yuanhao, All,
On 2020-09-01 00:14 +0800, Tian Yuanhao via buildroot spake thusly:
> This patch is for the next branch.
>
> Recently, the go infrastructure has changed, and libcap has been
> upgraded to 2.42. libcap introduced golang in 2.28, see:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/Make.Rules?id=0615d996379dceedefcd65a114f93fefd81c208f
>
> When you compile host-go and then compile host-libcap, GOLANG will be
> automatically set to yes. Because libcap.mk lacks golang support,
> compilation will fail.
I've taken those explanations and used them as the new commit log, and
applied the patch.
However, the patch was mangled: TABs were replaced by spaces, so I had
to fix that too.
Applied to master, thanks!
Regards,
Yann E. MORIN.
> > > libcap is a pure C library before 2.27, it lacks some environment
> > > variables set in pkg-golang.mk.
> >
> > Can you be more specific? What exactly is this fixing? I don't see
> > any related autobuilder errors?
> >
> > http://autobuild.buildroot.net/?reason=libcap-2.27
> >
> > And I don't see any reference to GOLANG in libcap-2.27?
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-09 20:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-31 2:16 [Buildroot] [PATCH] libcap: disable GOLANG Tian Yuanhao
2020-08-31 15:15 ` Peter Korsgaard
2020-08-31 16:14 ` Tian Yuanhao
2020-08-31 16:24 ` Peter Korsgaard
2020-09-09 20:35 ` Joseph Kogut
2020-09-09 20:42 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox