* [Buildroot] [PATCH] package/libxml-parser-perl: use the compiler as "LD"
@ 2020-09-09 21:34 Thomas Petazzoni
2020-09-09 21:43 ` Joseph Kogut
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2020-09-09 21:34 UTC (permalink / raw)
To: buildroot
Since commit efa95b19aeab6bdcd7d5a620e199c2c32cf2516b
("package/libxml-parser-perl: make host build use correct compiler"),
we pass $(HOST_CONFIGURE_OPTS) when building host-libxml-parser-perl,
in order to use the correct host compiler.
However, this means that LD="$(HOSTLD)" is passed. However, the
host-libxml-parser-perl passes compiler arguments to LD, so it really
assumes that LD is gcc, not ld. For example, it tries to pass
-mtune=generic.
So, let's tell host-libxml-parser-perl that LD is "$(HOSTCC)".
Fixes:
http://autobuild.buildroot.net/results/2ed2e5ccefe9047c597f84d5880de2e8de2bdd94/
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/libxml-parser-perl/libxml-parser-perl.mk | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/package/libxml-parser-perl/libxml-parser-perl.mk b/package/libxml-parser-perl/libxml-parser-perl.mk
index 100c49633c..37cef2e418 100644
--- a/package/libxml-parser-perl/libxml-parser-perl.mk
+++ b/package/libxml-parser-perl/libxml-parser-perl.mk
@@ -12,9 +12,14 @@ LIBXML_PARSER_PERL_LICENSE = Artistic or GPL-1.0+
LIBXML_PARSER_PERL_LICENSE_FILES = README
LIBXML_PARSER_PERL_RUN_PERL = `which perl`
+HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS = \
+ $(HOST_CONFIGURE_OPTS) \
+ LD="$(HOSTCC)"
+
define HOST_LIBXML_PARSER_PERL_CONFIGURE_CMDS
(cd $(@D) ; \
- $(HOST_CONFIGURE_OPTS) $(LIBXML_PARSER_PERL_RUN_PERL) Makefile.PL \
+ $(HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS) \
+ $(LIBXML_PARSER_PERL_RUN_PERL) Makefile.PL \
PREFIX=$(HOST_DIR) \
EXPATLIBPATH=$(HOST_DIR)/lib \
EXPATINCPATH=$(HOST_DIR)/include \
@@ -25,7 +30,7 @@ define HOST_LIBXML_PARSER_PERL_CONFIGURE_CMDS
endef
define HOST_LIBXML_PARSER_PERL_BUILD_CMDS
- $(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)
+ $(HOST_MAKE_ENV) $(MAKE) $(HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS) -C $(@D)
endef
define HOST_LIBXML_PARSER_PERL_INSTALL_CMDS
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/libxml-parser-perl: use the compiler as "LD"
2020-09-09 21:34 [Buildroot] [PATCH] package/libxml-parser-perl: use the compiler as "LD" Thomas Petazzoni
@ 2020-09-09 21:43 ` Joseph Kogut
2020-09-09 21:47 ` Yann E. MORIN
2020-09-11 21:19 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Joseph Kogut @ 2020-09-09 21:43 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Wed, Sep 9, 2020 at 2:34 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Since commit efa95b19aeab6bdcd7d5a620e199c2c32cf2516b
> ("package/libxml-parser-perl: make host build use correct compiler"),
> we pass $(HOST_CONFIGURE_OPTS) when building host-libxml-parser-perl,
> in order to use the correct host compiler.
>
> However, this means that LD="$(HOSTLD)" is passed. However, the
> host-libxml-parser-perl passes compiler arguments to LD, so it really
> assumes that LD is gcc, not ld. For example, it tries to pass
> -mtune=generic.
>
> So, let's tell host-libxml-parser-perl that LD is "$(HOSTCC)".
>
> Fixes:
>
> http://autobuild.buildroot.net/results/2ed2e5ccefe9047c597f84d5880de2e8de2bdd94/
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/libxml-parser-perl/libxml-parser-perl.mk | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/package/libxml-parser-perl/libxml-parser-perl.mk b/package/libxml-parser-perl/libxml-parser-perl.mk
> index 100c49633c..37cef2e418 100644
> --- a/package/libxml-parser-perl/libxml-parser-perl.mk
> +++ b/package/libxml-parser-perl/libxml-parser-perl.mk
> @@ -12,9 +12,14 @@ LIBXML_PARSER_PERL_LICENSE = Artistic or GPL-1.0+
> LIBXML_PARSER_PERL_LICENSE_FILES = README
> LIBXML_PARSER_PERL_RUN_PERL = `which perl`
>
> +HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS = \
> + $(HOST_CONFIGURE_OPTS) \
> + LD="$(HOSTCC)"
> +
> define HOST_LIBXML_PARSER_PERL_CONFIGURE_CMDS
> (cd $(@D) ; \
> - $(HOST_CONFIGURE_OPTS) $(LIBXML_PARSER_PERL_RUN_PERL) Makefile.PL \
> + $(HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS) \
> + $(LIBXML_PARSER_PERL_RUN_PERL) Makefile.PL \
> PREFIX=$(HOST_DIR) \
> EXPATLIBPATH=$(HOST_DIR)/lib \
> EXPATINCPATH=$(HOST_DIR)/include \
> @@ -25,7 +30,7 @@ define HOST_LIBXML_PARSER_PERL_CONFIGURE_CMDS
> endef
>
> define HOST_LIBXML_PARSER_PERL_BUILD_CMDS
> - $(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)
> + $(HOST_MAKE_ENV) $(MAKE) $(HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS) -C $(@D)
> endef
>
> define HOST_LIBXML_PARSER_PERL_INSTALL_CMDS
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Tested-by: Joseph Kogut <joseph.kogut@gmail.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/libxml-parser-perl: use the compiler as "LD"
2020-09-09 21:34 [Buildroot] [PATCH] package/libxml-parser-perl: use the compiler as "LD" Thomas Petazzoni
2020-09-09 21:43 ` Joseph Kogut
@ 2020-09-09 21:47 ` Yann E. MORIN
2020-09-11 21:19 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-09-09 21:47 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2020-09-09 23:34 +0200, Thomas Petazzoni spake thusly:
> Since commit efa95b19aeab6bdcd7d5a620e199c2c32cf2516b
> ("package/libxml-parser-perl: make host build use correct compiler"),
> we pass $(HOST_CONFIGURE_OPTS) when building host-libxml-parser-perl,
> in order to use the correct host compiler.
>
> However, this means that LD="$(HOSTLD)" is passed. However, the
> host-libxml-parser-perl passes compiler arguments to LD, so it really
> assumes that LD is gcc, not ld. For example, it tries to pass
> -mtune=generic.
>
> So, let's tell host-libxml-parser-perl that LD is "$(HOSTCC)".
>
> Fixes:
>
> http://autobuild.buildroot.net/results/2ed2e5ccefe9047c597f84d5880de2e8de2bdd94/
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to master, after adding the tested-by tag Joseph gave during our
live discussion on IRC... Thanks.
Regards,
Yann E. MORIN.
> ---
> package/libxml-parser-perl/libxml-parser-perl.mk | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/package/libxml-parser-perl/libxml-parser-perl.mk b/package/libxml-parser-perl/libxml-parser-perl.mk
> index 100c49633c..37cef2e418 100644
> --- a/package/libxml-parser-perl/libxml-parser-perl.mk
> +++ b/package/libxml-parser-perl/libxml-parser-perl.mk
> @@ -12,9 +12,14 @@ LIBXML_PARSER_PERL_LICENSE = Artistic or GPL-1.0+
> LIBXML_PARSER_PERL_LICENSE_FILES = README
> LIBXML_PARSER_PERL_RUN_PERL = `which perl`
>
> +HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS = \
> + $(HOST_CONFIGURE_OPTS) \
> + LD="$(HOSTCC)"
> +
> define HOST_LIBXML_PARSER_PERL_CONFIGURE_CMDS
> (cd $(@D) ; \
> - $(HOST_CONFIGURE_OPTS) $(LIBXML_PARSER_PERL_RUN_PERL) Makefile.PL \
> + $(HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS) \
> + $(LIBXML_PARSER_PERL_RUN_PERL) Makefile.PL \
> PREFIX=$(HOST_DIR) \
> EXPATLIBPATH=$(HOST_DIR)/lib \
> EXPATINCPATH=$(HOST_DIR)/include \
> @@ -25,7 +30,7 @@ define HOST_LIBXML_PARSER_PERL_CONFIGURE_CMDS
> endef
>
> define HOST_LIBXML_PARSER_PERL_BUILD_CMDS
> - $(HOST_MAKE_ENV) $(MAKE) $(HOST_CONFIGURE_OPTS) -C $(@D)
> + $(HOST_MAKE_ENV) $(MAKE) $(HOST_LIBXML_PARSER_PERL_CONFIGURE_OPTS) -C $(@D)
> endef
>
> define HOST_LIBXML_PARSER_PERL_INSTALL_CMDS
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/libxml-parser-perl: use the compiler as "LD"
2020-09-09 21:34 [Buildroot] [PATCH] package/libxml-parser-perl: use the compiler as "LD" Thomas Petazzoni
2020-09-09 21:43 ` Joseph Kogut
2020-09-09 21:47 ` Yann E. MORIN
@ 2020-09-11 21:19 ` Peter Korsgaard
2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-09-11 21:19 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Since commit efa95b19aeab6bdcd7d5a620e199c2c32cf2516b
> ("package/libxml-parser-perl: make host build use correct compiler"),
> we pass $(HOST_CONFIGURE_OPTS) when building host-libxml-parser-perl,
> in order to use the correct host compiler.
> However, this means that LD="$(HOSTLD)" is passed. However, the
> host-libxml-parser-perl passes compiler arguments to LD, so it really
> assumes that LD is gcc, not ld. For example, it tries to pass
> -mtune=generic.
> So, let's tell host-libxml-parser-perl that LD is "$(HOSTCC)".
> Fixes:
> http://autobuild.buildroot.net/results/2ed2e5ccefe9047c597f84d5880de2e8de2bdd94/
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-11 21:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-09 21:34 [Buildroot] [PATCH] package/libxml-parser-perl: use the compiler as "LD" Thomas Petazzoni
2020-09-09 21:43 ` Joseph Kogut
2020-09-09 21:47 ` Yann E. MORIN
2020-09-11 21:19 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox