* [Buildroot] [PATCH 1/1] package/gnuplot: Add patch to fix 'undefined reference to gp_read_history'
@ 2020-09-14 9:07 Michael Fischer
2020-09-19 19:42 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Michael Fischer @ 2020-09-14 9:07 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.net/results/e09087f0afd323a220889e2c7827fd73c9025673
Signed-off-by: Michael Fischer <mf@go-sys.de>
---
package/gnuplot/0002-without-history.patch | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 package/gnuplot/0002-without-history.patch
diff --git a/package/gnuplot/0002-without-history.patch b/package/gnuplot/0002-without-history.patch
new file mode 100644
index 0000000000..6091da8415
--- /dev/null
+++ b/package/gnuplot/0002-without-history.patch
@@ -0,0 +1,17 @@
+history.c: Patch to solve the 'undefined reference to gp_read_history'
+
+Signed-off-by: Michael Fischer <mf@go-sys.de>
+
+diff -purN gnuplot-5.4.0.org/src/history.c gnuplot-5.4.0/src/history.c
+--- gnuplot-5.4.0.org/src/history.c 2019-12-10 07:22:32.000000000 +0100
++++ gnuplot-5.4.0/src/history.c 2020-09-14 10:07:36.525441702 +0200
+@@ -91,7 +91,9 @@ write_history(char *filename)
+ void
+ read_history(char *filename)
+ {
+- gp_read_history(filename);
++#ifdef GNUPLOT_HISTORY
++ gp_read_history(filename);
++#endif
+ }
+
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/1] package/gnuplot: Add patch to fix 'undefined reference to gp_read_history'
@ 2020-09-03 13:30 Michael Fischer
2020-09-05 7:51 ` Yann E. MORIN
0 siblings, 1 reply; 5+ messages in thread
From: Michael Fischer @ 2020-09-03 13:30 UTC (permalink / raw)
To: buildroot
Signed-off-by: Michael Fischer <mf@go-sys.de>
---
package/gnuplot/0002-without-history.patch | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 package/gnuplot/0002-without-history.patch
diff --git a/package/gnuplot/0002-without-history.patch b/package/gnuplot/0002-without-history.patch
new file mode 100644
index 0000000000..2ce144eabd
--- /dev/null
+++ b/package/gnuplot/0002-without-history.patch
@@ -0,0 +1,18 @@
+Patch to solve the 'undefined reference to gp_read_history'
+
+Signed-off-by: Michael Fischer <mf@go-sys.de>
+
+
+diff -Naur a/src/history.c b/src/history.c
+--- a/src/history.c 2020-09-03 14:48:47.875493026 +0200
++++ b/src/history.c 2020-09-03 14:50:39.493972218 +0200
+@@ -91,7 +91,9 @@
+ void
+ read_history(char *filename)
+ {
++#ifdef GNUPLOT_HISTORY
+ gp_read_history(filename);
++#endif
+ }
+
+
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/1] package/gnuplot: Add patch to fix 'undefined reference to gp_read_history'
2020-09-03 13:30 Michael Fischer
@ 2020-09-05 7:51 ` Yann E. MORIN
2020-09-08 7:39 ` Michael Fischer
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2020-09-05 7:51 UTC (permalink / raw)
To: buildroot
Micheal, All,
On 2020-09-03 15:30 +0200, Michael Fischer spake thusly:
> Signed-off-by: Michael Fischer <mf@go-sys.de>
Thanks for this patch.
This is fixing autobuilder failures, so a reference to at least one
would have been good:
Fixes:
http://autobuild.buildroot.org/results/095/0956bc50b9823374254a2032d7897d48aff2d1fa/
> ---
> package/gnuplot/0002-without-history.patch | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 package/gnuplot/0002-without-history.patch
>
> diff --git a/package/gnuplot/0002-without-history.patch b/package/gnuplot/0002-without-history.patch
> new file mode 100644
> index 0000000000..2ce144eabd
> --- /dev/null
> +++ b/package/gnuplot/0002-without-history.patch
> @@ -0,0 +1,18 @@
> +Patch to solve the 'undefined reference to gp_read_history'
> +
> +Signed-off-by: Michael Fischer <mf@go-sys.de>
Since gnuplot uses git, we need that patch to be git-formatted:
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
(Yes I know the existing patch does not conform to that requirement, but
that is a old patch, from before we started enforcing any coding style.)
Also, did you send that patch upstream? If so, it would be super nice
that you include the URL to the bug-report, or mailing post, so that we
eventually bump gnuplot, we can get rid of that patch.
Care to rework and respin, please?
Regards,
Yann E. MORIN.
> +diff -Naur a/src/history.c b/src/history.c
> +--- a/src/history.c 2020-09-03 14:48:47.875493026 +0200
> ++++ b/src/history.c 2020-09-03 14:50:39.493972218 +0200
> +@@ -91,7 +91,9 @@
> + void
> + read_history(char *filename)
> + {
> ++#ifdef GNUPLOT_HISTORY
> + gp_read_history(filename);
> ++#endif
> + }
> +
> +
> --
> 2.28.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/1] package/gnuplot: Add patch to fix 'undefined reference to gp_read_history'
2020-09-05 7:51 ` Yann E. MORIN
@ 2020-09-08 7:39 ` Michael Fischer
0 siblings, 0 replies; 5+ messages in thread
From: Michael Fischer @ 2020-09-08 7:39 UTC (permalink / raw)
To: buildroot
I'm on vacation this week.
So it takes a while.
Regards
Michael.
-------- Urspr?ngliche Nachricht --------
Von: "Yann E. MORIN" <yann.morin.1998@free.fr>
Datum: 05.09.20 09:52 (GMT+01:00)
An: Michael Fischer <mf@go-sys.de>
Cc: buildroot at busybox.net
Betreff: Re: [Buildroot] [PATCH 1/1] package/gnuplot: Add patch to fix 'undefined reference to gp_read_history'
Micheal, All,
On 2020-09-03 15:30 +0200, Michael Fischer spake thusly:
> Signed-off-by: Michael Fischer <mf@go-sys.de>
Thanks for this patch.
This is fixing autobuilder failures, so a reference to at least one
would have been good:
Fixes:
http://autobuild.buildroot.org/results/095/0956bc50b9823374254a2032d7897d48aff2d1fa/
> ---
> package/gnuplot/0002-without-history.patch | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 package/gnuplot/0002-without-history.patch
>
> diff --git a/package/gnuplot/0002-without-history.patch b/package/gnuplot/0002-without-history.patch
> new file mode 100644
> index 0000000000..2ce144eabd
> --- /dev/null
> +++ b/package/gnuplot/0002-without-history.patch
> @@ -0,0 +1,18 @@
> +Patch to solve the 'undefined reference to gp_read_history'
> +
> +Signed-off-by: Michael Fischer <mf@go-sys.de>
Since gnuplot uses git, we need that patch to be git-formatted:
https://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches
(Yes I know the existing patch does not conform to that requirement, but
that is a old patch, from before we started enforcing any coding style.)
Also, did you send that patch upstream? If so, it would be super nice
that you include the URL to the bug-report, or mailing post, so that we
eventually bump gnuplot, we can get rid of that patch.
Care to rework and respin, please?
Regards,
Yann E. MORIN.
> +diff -Naur a/src/history.c b/src/history.c
> +--- a/src/history.c 2020-09-03 14:48:47.875493026 +0200
> ++++ b/src/history.c 2020-09-03 14:50:39.493972218 +0200
> +@@ -91,7 +91,9 @@
> + void
> + read_history(char *filename)
> + {
> ++#ifdef GNUPLOT_HISTORY
> + gp_read_history(filename);
> ++#endif
> + }
> +
> +
> --
> 2.28.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200908/21c704d9/attachment.html>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-19 19:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-14 9:07 [Buildroot] [PATCH 1/1] package/gnuplot: Add patch to fix 'undefined reference to gp_read_history' Michael Fischer
2020-09-19 19:42 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2020-09-03 13:30 Michael Fischer
2020-09-05 7:51 ` Yann E. MORIN
2020-09-08 7:39 ` Michael Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox