[Buildroot] [PATCH 1/1] package/iwd: fix build with uclibc

[Buildroot] [PATCH 1/1] package/iwd: fix build with uclibc

[Fabrice Fontaine]

Fixes:
 - http://autobuild.buildroot.org/results/8bbf7e1d0929d0883c0c2445990f62f5a1d54163

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 ...0001-src-p2p.c-fix-build-with-uclibc.patch | 38 +++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 package/iwd/0001-src-p2p.c-fix-build-with-uclibc.patch

diff --git a/package/iwd/0001-src-p2p.c-fix-build-with-uclibc.patch b/package/iwd/0001-src-p2p.c-fix-build-with-uclibc.patch
new file mode 100644
index 0000000000..34c525f907
--- /dev/null
+++ b/package/iwd/0001-src-p2p.c-fix-build-with-uclibc.patch
@@ -0,0 +1,38 @@
+From 7d29d294c7138460dc400df8d051d7f334d149cf Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Sat, 20 Jun 2020 15:13:17 +0200
+Subject: [PATCH] src/p2p.c: fix build with uclibc
+
+explicit_bzero is used in src/p2p.c since commit
+1675c765a3d66f3c626a1581a7bf514e1859b064 but src/missing.h is not
+included, as a result build with uclibc fails on:
+
+/home/naourr/work/instance-0/output-1/per-package/iwd/host/opt/ext-toolchain/bin/../lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/../../../../mips64el-buildroot-linux-uclibc/bin/ld: src/p2p.o: in function `p2p_connection_reset':
+p2p.c:(.text+0x2cf4): undefined reference to `explicit_bzero'
+/home/naourr/work/instance-0/output-1/per-package/iwd/host/opt/ext-toolchain/bin/../lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/../../../../mips64el-buildroot-linux-uclibc/bin/ld: p2p.c:(.text+0x2cfc): undefined reference to `explicit_bzero'
+
+Fixes:
+ - http://autobuild.buildroot.org/results/8bbf7e1d0929d0883c0c2445990f62f5a1d54163
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status:
+https://lists.01.org/hyperkitty/list/iwd at lists.01.org/thread/EXR3JZJXIVITX2ZSQRE6GEXGN6P3KUTC]
+---
+ src/p2p.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/p2p.c b/src/p2p.c
+index dc78b887..a759df5c 100644
+--- a/src/p2p.c
++++ b/src/p2p.c
+@@ -37,6 +37,7 @@
+ 
+ #include "linux/nl80211.h"
+ 
++#include "src/missing.h"
+ #include "src/iwd.h"
+ #include "src/wiphy.h"
+ #include "src/scan.h"
+-- 
+2.26.2
+
-- 
2.26.2

[Buildroot] [PATCH 1/1] package/iwd: fix build with uclibc

[Thomas Petazzoni]

On Sat, 20 Jun 2020 15:23:05 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fixes:
>  - http://autobuild.buildroot.org/results/8bbf7e1d0929d0883c0c2445990f62f5a1d54163
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...0001-src-p2p.c-fix-build-with-uclibc.patch | 38 +++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 package/iwd/0001-src-p2p.c-fix-build-with-uclibc.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/iwd: fix build with uclibc

[Fabrice Fontaine]

This patch is needed to fix a build failure with iwd 1.9.0 and uclibc

Fixes:
 - http://autobuild.buildroot.org/results/c7a0096a269bfc52bd8e23d453d36d5bfb61441d

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 .../0001-src-ap.c-fix-build-with-uclibc.patch | 37 +++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch

diff --git a/package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch b/package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch
new file mode 100644
index 0000000000..b4e18098c0
--- /dev/null
+++ b/package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch
@@ -0,0 +1,37 @@
+From 377df79e83e2127a087e1aa5ba6173e195e50933 Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+Date: Thu, 10 Sep 2020 07:47:14 +0200
+Subject: [PATCH] src/ap.c: fix build with uclibc
+
+explicit_bzero is used in src/ap.c since commit
+d55e00b31d7bccdbb2ea1cdeb0a749df77a51e47 but src/missing.h is not
+included, as a result build with uclibc fails on:
+
+/srv/storage/autobuild/run/instance-1/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/9.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld: src/ap.o: in function `ap_probe_req_cb':
+ap.c:(.text+0x23d8): undefined reference to `explicit_bzero'
+
+Fixes:
+ - http://autobuild.buildroot.org/results/c7a0096a269bfc52bd8e23d453d36d5bfb61441d
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
+[Upstream status:
+https://lists.01.org/hyperkitty/list/iwd at lists.01.org/thread/SSEFPYCJWH2CQGY7IV6BPNOPMQWYYZPD/]
+---
+ src/ap.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/ap.c b/src/ap.c
+index c972cfcb..ac705c31 100644
+--- a/src/ap.c
++++ b/src/ap.c
+@@ -31,6 +31,7 @@
+ 
+ #include "linux/nl80211.h"
+ 
++#include "src/missing.h"
+ #include "src/iwd.h"
+ #include "src/module.h"
+ #include "src/scan.h"
+-- 
+2.28.0
+
-- 
2.28.0

[Buildroot] [PATCH 1/1] package/iwd: fix build with uclibc

[Peter Seiderer]

Hello Fabrice,

On Thu, 10 Sep 2020 08:20:26 +0200, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> This patch is needed to fix a build failure with iwd 1.9.0 and uclibc
>
> Fixes:
>  - http://autobuild.buildroot.org/results/c7a0096a269bfc52bd8e23d453d36d5bfb61441d
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  .../0001-src-ap.c-fix-build-with-uclibc.patch | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch
>
> diff --git a/package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch b/package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch
> new file mode 100644
> index 0000000000..b4e18098c0
> --- /dev/null
> +++ b/package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch
> @@ -0,0 +1,37 @@
> +From 377df79e83e2127a087e1aa5ba6173e195e50933 Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Thu, 10 Sep 2020 07:47:14 +0200
> +Subject: [PATCH] src/ap.c: fix build with uclibc
> +
> +explicit_bzero is used in src/ap.c since commit
> +d55e00b31d7bccdbb2ea1cdeb0a749df77a51e47 but src/missing.h is not
> +included, as a result build with uclibc fails on:
> +
> +/srv/storage/autobuild/run/instance-1/output-1/host/lib/gcc/xtensa-buildroot-linux-uclibc/9.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld: src/ap.o: in function `ap_probe_req_cb':
> +ap.c:(.text+0x23d8): undefined reference to `explicit_bzero'
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/c7a0096a269bfc52bd8e23d453d36d5bfb61441d
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status:
> +https://lists.01.org/hyperkitty/list/iwd at lists.01.org/thread/SSEFPYCJWH2CQGY7IV6BPNOPMQWYYZPD/]

And upstream accepted, see [1]...

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter

[1] https://git.kernel.org/pub/scm/network/wireless/iwd.git/commit/?id=0a6de7932a61ec82aca4f78f71dab7247c897860

> +---
> + src/ap.c | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/src/ap.c b/src/ap.c
> +index c972cfcb..ac705c31 100644
> +--- a/src/ap.c
> ++++ b/src/ap.c
> +@@ -31,6 +31,7 @@
> +
> + #include "linux/nl80211.h"
> +
> ++#include "src/missing.h"
> + #include "src/iwd.h"
> + #include "src/module.h"
> + #include "src/scan.h"
> +--
> +2.28.0
> +

[Buildroot] [PATCH 1/1] package/iwd: fix build with uclibc

[Thomas Petazzoni]

On Thu, 10 Sep 2020 08:20:26 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> This patch is needed to fix a build failure with iwd 1.9.0 and uclibc
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/c7a0096a269bfc52bd8e23d453d36d5bfb61441d
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  .../0001-src-ap.c-fix-build-with-uclibc.patch | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 package/iwd/0001-src-ap.c-fix-build-with-uclibc.patch

Applied to master, thanks. I have updated the upstream status, as the
patch was accepted upstream as pointed out by Peter Seiderer.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com