From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] linux: show compression options only on some architectures
Date: Thu, 24 Sep 2020 14:22:20 +0200 [thread overview]
Message-ID: <20200924122222.3449188-1-thomas.petazzoni@bootlin.com> (raw)
Our Linux kernel compression options have the effect of enabling
CONFIG_KERNEL_{GZIP,LZMA,LZ4,...}. However, those configuration
options only exist on a subset of the CPU architectures, and it is
confusing to have such a choice visible when it in fact has no
effect. For example on ARM64, it has absolutely no effect, and the way
to create a compressed image is different, and the image is not
self-extractible.
So, we introduce a BR2_LINUX_KERNEL_ARCH_HAS_COMPRESSION to know which
architectures have compression support. Of course, it's never going to
be perfect as the set of architectures supporting compression might
change over time. But at least, it will allow us to hide this option
on architectures that do not at this point support compression.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
linux/Config.in | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/linux/Config.in b/linux/Config.in
index 49da2b81b2..9f2af6da5b 100644
--- a/linux/Config.in
+++ b/linux/Config.in
@@ -299,6 +299,22 @@ endchoice
# Kernel compression format
#
+# Indicates whether this architecture has support for built-in kernel
+# compression, i.e architectures that select one of
+# HAVE_KERNEL_{GZIP,LZMA,LZ4,LZO,XZ,UNCOMPRESSED}
+config BR2_LINUX_KERNEL_ARCH_HAS_COMPRESSION
+ bool
+ default y if BR2_arcle || BR2_arceb
+ default y if BR2_arm || BR2_armeb
+ default y if BR2_csky
+ default y if BR2_i386
+ default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
+ default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
+ default y if BR2_sh
+ default y if BR2_x86_64
+
+if BR2_LINUX_KERNEL_ARCH_HAS_COMPRESSION
+
choice
prompt "Kernel compression format"
help
@@ -326,6 +342,8 @@ config BR2_LINUX_KERNEL_ZSTD
endchoice
+endif
+
config BR2_LINUX_KERNEL_IMAGE_TARGET_NAME
string "Kernel image target name"
depends on BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM
--
2.26.2
next reply other threads:[~2020-09-24 12:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 12:22 Thomas Petazzoni [this message]
2020-09-24 12:22 ` [Buildroot] [PATCH 2/2] linux: support Image.gz on arm64 and riscv Thomas Petazzoni
2020-09-25 2:31 ` Tian Yuanhao
2020-09-25 7:37 ` [Buildroot] [PATCH 1/2] linux: show compression options only on some architectures Yann E. MORIN
2020-09-25 7:45 ` Thomas Petazzoni
2020-09-25 8:14 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924122222.3449188-1-thomas.petazzoni@bootlin.com \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox