From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] linux: show compression options only on some architectures
Date: Fri, 25 Sep 2020 10:14:15 +0200 [thread overview]
Message-ID: <20200925081415.GE11621@scaer> (raw)
In-Reply-To: <20200925094546.064d9c09@windsurf.hq.k.grp>
Thomas, All,
On 2020-09-25 09:45 +0200, Thomas Petazzoni spake thusly:
> On Fri, 25 Sep 2020 09:37:58 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > $(SED) "/\\<)\\>/d" /some/.config-file
> > echo '=y' >> /some/.config-file
> > And to be honest, I am not sure that last line would generate a fully
> > legit kconfig setting... ;-)
> > Of course, running 'make oldconfig' on that modified .config would drop
> > invalid lines, so you would not notivce the issue, but still this is not
> > correct...
> Thanks for spotting this, I'll fix in v2. That being said, one can
> notice that you're pointing out that this bogus =y line will be
> dropped... just as equally as the bogus CONFIG_KERNEL_GZIP=y that we
> have today gets dropped on arm64 and other architectures for which
> those CONFIG_KERNEL_{GZIP,LZMA,LZ4,...} options don't exist :-)
Yes, but an unknown symbol assignment is still valid syntax, and
silently discarded by kconfig, because that is the goal of running
oldconfig: assigning new symbols and dropping old ones.
But the '=y' is not even syntactically valid. kconfig is still lenient
about that, though (but it does warn, doesn't it?), but this is not a
reason to generate an invalid file.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2020-09-25 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 12:22 [Buildroot] [PATCH 1/2] linux: show compression options only on some architectures Thomas Petazzoni
2020-09-24 12:22 ` [Buildroot] [PATCH 2/2] linux: support Image.gz on arm64 and riscv Thomas Petazzoni
2020-09-25 2:31 ` Tian Yuanhao
2020-09-25 7:37 ` [Buildroot] [PATCH 1/2] linux: show compression options only on some architectures Yann E. MORIN
2020-09-25 7:45 ` Thomas Petazzoni
2020-09-25 8:14 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925081415.GE11621@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox