Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/mesa3d: add missing depends and driver name to r100 driver
@ 2020-02-09 18:34 James Hilliard
  2020-09-23  5:26 ` Bernd Kuhls
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: James Hilliard @ 2020-02-09 18:34 UTC (permalink / raw)
  To: buildroot

Propagate libdrm dependencies.

Add r100 to menu name to differentiate from r200 dri driver.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/mesa3d/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index ff39652508..788705544d 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -355,7 +355,9 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU
 	  Support for Nvidia-based GPUs.
 
 config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
-	bool "DRI radeon driver"
+	bool "DRI radeon r100 driver"
+	depends on BR2_i386 || BR2_x86_64
+	depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC
 	select BR2_PACKAGE_MESA3D_DRI_DRIVER
 	select BR2_PACKAGE_LIBDRM_RADEON
 	help
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/mesa3d: add missing depends and driver name to r100 driver
  2020-02-09 18:34 [Buildroot] [PATCH 1/1] package/mesa3d: add missing depends and driver name to r100 driver James Hilliard
@ 2020-09-23  5:26 ` Bernd Kuhls
  2020-10-06 20:19 ` Yann E. MORIN
  2020-10-06 21:05 ` Yann E. MORIN
  2 siblings, 0 replies; 4+ messages in thread
From: Bernd Kuhls @ 2020-09-23  5:26 UTC (permalink / raw)
  To: buildroot

Hi James,

Am Sun, 09 Feb 2020 11:34:41 -0700 schrieb James Hilliard:

> Propagate libdrm dependencies.
> 
> Add r100 to menu name to differentiate from r200 dri driver.
> 
> Signed-off-by: James Hilliard <james.hilliard1-
Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  package/mesa3d/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index ff39652508..788705544d 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -355,7 +355,9 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU
>  	  Support for Nvidia-based GPUs.
>  
>  config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
> -	bool "DRI radeon driver"
> +	bool "DRI radeon r100 driver"

ok.

> +	depends on BR2_i386 || BR2_x86_64

Ok, the build system of mesa3d limits the driver to these archs:
https://cgit.freedesktop.org/mesa/mesa/tree/meson.build?h=20.1#n141

> +	depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC

ok.

Reviewed-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Regards, Bernd

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/mesa3d: add missing depends and driver name to r100 driver
  2020-02-09 18:34 [Buildroot] [PATCH 1/1] package/mesa3d: add missing depends and driver name to r100 driver James Hilliard
  2020-09-23  5:26 ` Bernd Kuhls
@ 2020-10-06 20:19 ` Yann E. MORIN
  2020-10-06 21:05 ` Yann E. MORIN
  2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-10-06 20:19 UTC (permalink / raw)
  To: buildroot

James, All,

On 2020-02-09 11:34 -0700, James Hilliard spake thusly:
> Propagate libdrm dependencies.
> 
> Add r100 to menu name to differentiate from r200 dri driver.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/mesa3d/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index ff39652508..788705544d 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -355,7 +355,9 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU
>  	  Support for Nvidia-based GPUs.
>  
>  config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
> -	bool "DRI radeon driver"
> +	bool "DRI radeon r100 driver"
> +	depends on BR2_i386 || BR2_x86_64
> +	depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC
>  	select BR2_PACKAGE_MESA3D_DRI_DRIVER
>  	select BR2_PACKAGE_LIBDRM_RADEON
>  	help
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] package/mesa3d: add missing depends and driver name to r100 driver
  2020-02-09 18:34 [Buildroot] [PATCH 1/1] package/mesa3d: add missing depends and driver name to r100 driver James Hilliard
  2020-09-23  5:26 ` Bernd Kuhls
  2020-10-06 20:19 ` Yann E. MORIN
@ 2020-10-06 21:05 ` Yann E. MORIN
  2 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-10-06 21:05 UTC (permalink / raw)
  To: buildroot

James, All,

On 2020-02-09 11:34 -0700, James Hilliard spake thusly:
> Propagate libdrm dependencies.
> 
> Add r100 to menu name to differentiate from r200 dri driver.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/mesa3d/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index ff39652508..788705544d 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -355,7 +355,9 @@ config BR2_PACKAGE_MESA3D_DRI_DRIVER_NOUVEAU
>  	  Support for Nvidia-based GPUs.
>  
>  config BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
> -	bool "DRI radeon driver"
> +	bool "DRI radeon r100 driver"
> +	depends on BR2_i386 || BR2_x86_64
> +	depends on BR2_PACKAGE_LIBDRM_HAS_ATOMIC

This was causing a circular dependency, as noticed by Thomas:

    package/gstreamer1/gstreamer1/Config.in:5:error: recursive dependency detected!
    package/gstreamer1/gstreamer1/Config.in:5:symbo l BR2_PACKAGE_GSTREAMER1 is selected by BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
    package/webkitgtk/Config.in:86:symbol BR2_PACKAGE_WEBKITGTK_MULTIMEDI   A depends on BR2_PACKAGE_WEBKITGTK
    package/webkitgtk/Config.in:23:symb ol BR2_PACKAGE_WEBKITGTK is selected by BR2_PACKAGE_MIDORI
    package/midori/Config.in:9:symbol BR2_PACKAGE_MIDORI depends on BR2_PACKAGE_LIBGTK3 
    package/libgtk3/Config.in:15:symbol BR2_PACKAGE_LIBGTK3 is selected b   y BR2_PACKAGE_VTE
    package/vte/Config.in:1:symbol BR2_PACKAGE_VTE depen    ds on BR2_PACKAGE_HAS_LIBEGL_WAYLAND
    package/opengl/libegl/Config.in:4:symbol BR2_PACKAGE_HAS_LIBEGL_WAYLAND is selected by BR2_PACKAGE_MESA3D_OPENGL_   EGL
    package/mesa3d/Config.in:436:symbol BR2_PACKAGE_MESA3D_OPENGL_EGL   depends on BR2_PACKAGE_MESA3D_DRIVER
    package/mesa3d/Config.in:75:symbo   l BR2_PACKAGE_MESA3D_DRIVER is selected by BR2_PACKAGE_MESA3D_DRI_DRIVER
    package/mesa3d/Config.in:61:symbol BR2_PACKAGE_MESA3D_DRI_DRIVER is s   elected by BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON
    package/mesa3d/Config.in:372:symbol BR2_PACKAGE_MESA3D_DRI_DRIVER_RADEON depends on BR2_PACKAGE_LIBDRM_HAS  _ATOMIC
    package/libdrm/Config.in:12:symbol BR2_PACKAGE_LIBDRM_HAS_ATOM  IC depends on BR2_PACKAGE_LIBDRM
    package/libdrm/Config.in:1:symbol BR2   _PACKAGE_LIBDRM is selected by BR2_PACKAGE_GST1_VAAPI
    package/gstreamer1/gst1-vaapi/Config.in:1:symbol BR2_PACKAGE_GST1_VAAPI depends on BR2_PAC  KAGE_GSTREAMER1

So, I dropped the dependency, like you already did in 00c1a8c34f7, and
pushed that fix to master.

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_MESA3D_DRI_DRIVER
>  	select BR2_PACKAGE_LIBDRM_RADEON
>  	help
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-10-06 21:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-09 18:34 [Buildroot] [PATCH 1/1] package/mesa3d: add missing depends and driver name to r100 driver James Hilliard
2020-09-23  5:26 ` Bernd Kuhls
2020-10-06 20:19 ` Yann E. MORIN
2020-10-06 21:05 ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox