From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/libabseil-cpp: enforce C++11
Date: Thu, 29 Oct 2020 23:36:00 +0100 [thread overview]
Message-ID: <20201029233600.4b2c8bd8@windsurf.home> (raw)
In-Reply-To: <20201027174046.17157-2-buildroot@heine.tech>
On Tue, 27 Oct 2020 18:40:44 +0100
Michael Nosthoff via buildroot <buildroot@busybox.net> wrote:
> From: Michael Nosthoff <buildroot@heine.tech>
>
> For gcc < 6 the c++ default is 98. Abseil needs@least 11
> but doesn't enforce this anymore. So we need to do this.
>
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
Is this fixing a build issue? What was the thing that made you write
this patch?
> +# abseil needs c++ >= 11 but doesn't set this anymore,
> +# before gcc6 the default is 98.
> +ifeq ($(BR2_GCC_AT_LEAST_6_0),)
> +LIBABSEIL_CPP_CONF_OPTS += -DCMAKE_CXX_STANDARD=11
> +endif
> +
> +ifeq ($(BR2_HOST_GCC_AT_LEAST_6_0),)
> +HOST_LIBABSEIL_CPP_CONF_OPTS += -DCMAKE_CXX_STANDARD=11
> +endif
Can we do it unconditionally ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-10-29 22:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 17:40 [Buildroot] [PATCH 0/3] fix libabseil-cpp build on older gcc versions buildroot at heine.tech
2020-10-27 17:40 ` [Buildroot] [PATCH 1/3] package/libabseil-cpp: enforce C++11 buildroot at heine.tech
2020-10-29 22:36 ` Thomas Petazzoni [this message]
2020-10-30 7:44 ` Michael Nosthoff
2020-10-30 8:15 ` Thomas Petazzoni
2020-10-30 8:47 ` Michael Nosthoff
2020-10-30 9:16 ` Thomas Petazzoni
2020-10-27 17:40 ` [Buildroot] [PATCH 2/3] package/libabseil-cpp: depend on gcc >= 4.9 buildroot at heine.tech
2020-10-29 22:36 ` Thomas Petazzoni
2020-10-30 7:48 ` Michael Nosthoff
2020-10-30 8:16 ` Thomas Petazzoni
2020-10-27 17:40 ` [Buildroot] [PATCH 3/3] package/grpc: raise (host) gcc dependency to 4.9 buildroot at heine.tech
2020-10-29 22:37 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029233600.4b2c8bd8@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox