From: Michael Nosthoff <buildroot@heine.tech>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/libabseil-cpp: enforce C++11
Date: Fri, 30 Oct 2020 09:47:42 +0100 [thread overview]
Message-ID: <52-5f9bd300-7-71e23380@170443389> (raw)
In-Reply-To: <20201030091522.53c77303@windsurf.home>
Hi,
On Friday, October 30, 2020 09:15 CET, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
>
> In fact, let's turn this around: if abseil uses C++11 features, then it
> should by itself pass -std=c++11 to the compiler, by setting the
> appropriate CXX_STANDARD in its CMakeLists.txt. There is no reason
> Buildroot should have to help here. So isn't an abseil CMakeLists.txt
> fix (submitted upstream) more appropriate here ?
>
Actually this was in abseil and they removed it intentionally in [0].
So I don't think they might have interest in picking up a patch that would reintroduce that...
Regards,
Michael
[0] https://github.com/abseil/abseil-cpp/commit/c6954897f7ece5011f0126db9117361dc1a6ff36#
next prev parent reply other threads:[~2020-10-30 8:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 17:40 [Buildroot] [PATCH 0/3] fix libabseil-cpp build on older gcc versions buildroot at heine.tech
2020-10-27 17:40 ` [Buildroot] [PATCH 1/3] package/libabseil-cpp: enforce C++11 buildroot at heine.tech
2020-10-29 22:36 ` Thomas Petazzoni
2020-10-30 7:44 ` Michael Nosthoff
2020-10-30 8:15 ` Thomas Petazzoni
2020-10-30 8:47 ` Michael Nosthoff [this message]
2020-10-30 9:16 ` Thomas Petazzoni
2020-10-27 17:40 ` [Buildroot] [PATCH 2/3] package/libabseil-cpp: depend on gcc >= 4.9 buildroot at heine.tech
2020-10-29 22:36 ` Thomas Petazzoni
2020-10-30 7:48 ` Michael Nosthoff
2020-10-30 8:16 ` Thomas Petazzoni
2020-10-27 17:40 ` [Buildroot] [PATCH 3/3] package/grpc: raise (host) gcc dependency to 4.9 buildroot at heine.tech
2020-10-29 22:37 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52-5f9bd300-7-71e23380@170443389 \
--to=buildroot@heine.tech \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox