* [Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service
@ 2020-11-12 20:21 Stefan Agner
2020-11-12 20:26 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Stefan Agner @ 2020-11-12 20:21 UTC (permalink / raw)
To: buildroot
Avoid setting executable bits for apparmor.service. This gets rid of a
corresponding warning during installation:
Configuration file ../target/usr/lib/systemd/system/apparmor.service
is marked executable. Please remove executable permission bits.
Proceeding anyway.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
package/apparmor/apparmor.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/apparmor/apparmor.mk b/package/apparmor/apparmor.mk
index 4d08b0433b..7ea0fabd91 100644
--- a/package/apparmor/apparmor.mk
+++ b/package/apparmor/apparmor.mk
@@ -88,7 +88,7 @@ endef
define APPARMOR_INSTALL_INIT_SYSTEMD
$(INSTALL) -D -m 0755 $(@D)/parser/apparmor.systemd \
$(TARGET_DIR)/lib/apparmor/apparmor.systemd
- $(INSTALL) -D -m 0755 $(@D)/parser/apparmor.service \
+ $(INSTALL) -D -m 0644 $(@D)/parser/apparmor.service \
$(TARGET_DIR)/usr/lib/systemd/system/apparmor.service
endef
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service
2020-11-12 20:21 [Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service Stefan Agner
@ 2020-11-12 20:26 ` Thomas Petazzoni
2020-11-12 20:42 ` Stefan Agner
2020-11-12 20:57 ` Peter Korsgaard
2020-11-14 13:13 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2020-11-12 20:26 UTC (permalink / raw)
To: buildroot
Hello Stefan,
Thanks for your patch!
On Thu, 12 Nov 2020 21:21:34 +0100
Stefan Agner <stefan@agner.ch> wrote:
> Avoid setting executable bits for apparmor.service. This gets rid of a
> corresponding warning during installation:
> Configuration file ../target/usr/lib/systemd/system/apparmor.service
> is marked executable. Please remove executable permission bits.
> Proceeding anyway.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> package/apparmor/apparmor.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/apparmor/apparmor.mk b/package/apparmor/apparmor.mk
> index 4d08b0433b..7ea0fabd91 100644
> --- a/package/apparmor/apparmor.mk
> +++ b/package/apparmor/apparmor.mk
> @@ -88,7 +88,7 @@ endef
> define APPARMOR_INSTALL_INIT_SYSTEMD
> $(INSTALL) -D -m 0755 $(@D)/parser/apparmor.systemd \
> $(TARGET_DIR)/lib/apparmor/apparmor.systemd
Any reason not to change this one as well ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service
2020-11-12 20:26 ` Thomas Petazzoni
@ 2020-11-12 20:42 ` Stefan Agner
2020-11-12 20:43 ` Stefan Agner
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Agner @ 2020-11-12 20:42 UTC (permalink / raw)
To: buildroot
On 2020-11-12 21:26, Thomas Petazzoni wrote:
> Hello Stefan,
>
> Thanks for your patch!
>
> On Thu, 12 Nov 2020 21:21:34 +0100
> Stefan Agner <stefan@agner.ch> wrote:
>
>> Avoid setting executable bits for apparmor.service. This gets rid of a
>> corresponding warning during installation:
>> Configuration file ../target/usr/lib/systemd/system/apparmor.service
>> is marked executable. Please remove executable permission bits.
>> Proceeding anyway.
>>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>> ---
>> package/apparmor/apparmor.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/apparmor/apparmor.mk b/package/apparmor/apparmor.mk
>> index 4d08b0433b..7ea0fabd91 100644
>> --- a/package/apparmor/apparmor.mk
>> +++ b/package/apparmor/apparmor.mk
>> @@ -88,7 +88,7 @@ endef
>> define APPARMOR_INSTALL_INIT_SYSTEMD
>> $(INSTALL) -D -m 0755 $(@D)/parser/apparmor.systemd \
>> $(TARGET_DIR)/lib/apparmor/apparmor.systemd
>
> Any reason not to change this one as well ?
Hm, I somehow thought this is a directory. But it is actually a script
which afaik only gets included, so I guess we can take away executable
as well.
Will send a v2.
--
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service
2020-11-12 20:42 ` Stefan Agner
@ 2020-11-12 20:43 ` Stefan Agner
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Agner @ 2020-11-12 20:43 UTC (permalink / raw)
To: buildroot
On 2020-11-12 21:42, Stefan Agner wrote:
> On 2020-11-12 21:26, Thomas Petazzoni wrote:
>> Hello Stefan,
>>
>> Thanks for your patch!
>>
>> On Thu, 12 Nov 2020 21:21:34 +0100
>> Stefan Agner <stefan@agner.ch> wrote:
>>
>>> Avoid setting executable bits for apparmor.service. This gets rid of a
>>> corresponding warning during installation:
>>> Configuration file ../target/usr/lib/systemd/system/apparmor.service
>>> is marked executable. Please remove executable permission bits.
>>> Proceeding anyway.
>>>
>>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>>> ---
>>> package/apparmor/apparmor.mk | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/package/apparmor/apparmor.mk b/package/apparmor/apparmor.mk
>>> index 4d08b0433b..7ea0fabd91 100644
>>> --- a/package/apparmor/apparmor.mk
>>> +++ b/package/apparmor/apparmor.mk
>>> @@ -88,7 +88,7 @@ endef
>>> define APPARMOR_INSTALL_INIT_SYSTEMD
>>> $(INSTALL) -D -m 0755 $(@D)/parser/apparmor.systemd \
>>> $(TARGET_DIR)/lib/apparmor/apparmor.systemd
>>
>> Any reason not to change this one as well ?
>
> Hm, I somehow thought this is a directory. But it is actually a script
> which afaik only gets included, so I guess we can take away executable
> as well.
No it is actually executed by the systemd service:
apparmor.service:ExecStart=/lib/apparmor/apparmor.systemd reload
So this needs executable bits.
--
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service
2020-11-12 20:21 [Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service Stefan Agner
2020-11-12 20:26 ` Thomas Petazzoni
@ 2020-11-12 20:57 ` Peter Korsgaard
2020-11-14 13:13 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-11-12 20:57 UTC (permalink / raw)
To: buildroot
>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:
> Avoid setting executable bits for apparmor.service. This gets rid of a
> corresponding warning during installation:
> Configuration file ../target/usr/lib/systemd/system/apparmor.service
> is marked executable. Please remove executable permission bits.
> Proceeding anyway.
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service
2020-11-12 20:21 [Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service Stefan Agner
2020-11-12 20:26 ` Thomas Petazzoni
2020-11-12 20:57 ` Peter Korsgaard
@ 2020-11-14 13:13 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-11-14 13:13 UTC (permalink / raw)
To: buildroot
>>>>> "Stefan" == Stefan Agner <stefan@agner.ch> writes:
> Avoid setting executable bits for apparmor.service. This gets rid of a
> corresponding warning during installation:
> Configuration file ../target/usr/lib/systemd/system/apparmor.service
> is marked executable. Please remove executable permission bits.
> Proceeding anyway.
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Committed to 2020.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-14 13:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-12 20:21 [Buildroot] [PATCH] package/apparmor: fix permission bits for apparmor.service Stefan Agner
2020-11-12 20:26 ` Thomas Petazzoni
2020-11-12 20:42 ` Stefan Agner
2020-11-12 20:43 ` Stefan Agner
2020-11-12 20:57 ` Peter Korsgaard
2020-11-14 13:13 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox