From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/go: fix a typo in CC and CXX env values
Date: Sat, 19 Dec 2020 12:11:46 +0100 [thread overview]
Message-ID: <20201219111146.GG3188@scaer> (raw)
In-Reply-To: <8selkOZpKE5CREY0ZZ4DfQgdVGdikFT69Rfm3Jo05uQO5vUDo-KlPp3AZiao5Qiwu03f-XUFHGg6uuYrhxGJYLk_9KqwZcQbj2O2ue5jaAc=@baudi.no>
Michael, All,
On 2020-12-18 09:57 +0000, Michael Baudino spake thusly:
> This commit fixes a typo in variable names that caused CC and CXX
> environment variables to be empty.
>
> Signed-off-by: Michael Baudino <michael@baudi.no>
Applied to master, thanks.
However, see a little comment, below...
> ---
> package/go/go.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git package/go/go.mk package/go/go.mk
> index d9f4905..cabbdc8 100644
> --- package/go/go.mk
> +++ package/go/go.mk
I'm not sure how you generated your patch, but this does not apply as-is
because it is not the expected depth, so git-am chokes on it.
Next time, please use 'git send-email' to send your patches, as it
ensures that patches are properly formatted.
I fixed it locally (and will do so on your next patch too), so no need
to resend those two.
Regards,
Yann E. MORIN.
> @@ -99,8 +99,8 @@ HOST_GO_HOST_ENV = \
> $(HOST_GO_COMMON_ENV) \
> GOARCH="" \
> GOCACHE="$(HOST_GO_HOST_CACHE)" \
> - CC="$(HOST_CCNOCCACHE)" \
> - CXX="$(HOST_CXXNOCCACHE)" \
> + CC="$(HOSTCC_NOCCACHE)" \
> + CXX="$(HOSTCXX_NOCCACHE)" \
> CGO_CFLAGS="$(HOST_CFLAGS)" \
> CGO_CXXFLAGS="$(HOST_CXXFLAGS)" \
> CGO_LDFLAGS="$(HOST_LDFLAGS)"
> --
> 2.7.4
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-12-19 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 9:57 [Buildroot] [PATCH] package/go: fix a typo in CC and CXX env values Michael Baudino
2020-12-19 11:11 ` Yann E. MORIN [this message]
2020-12-19 11:38 ` Michael Baudino
2020-12-22 10:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201219111146.GG3188@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox