* [Buildroot] [PATCH] package/go: fix a typo in CC and CXX env values @ 2020-12-18 9:57 Michael Baudino 2020-12-19 11:11 ` Yann E. MORIN 2020-12-22 10:41 ` Peter Korsgaard 0 siblings, 2 replies; 4+ messages in thread From: Michael Baudino @ 2020-12-18 9:57 UTC (permalink / raw) To: buildroot This commit fixes a typo in variable names that caused CC and CXX environment variables to be empty. Signed-off-by: Michael Baudino <michael@baudi.no> --- package/go/go.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git package/go/go.mk package/go/go.mk index d9f4905..cabbdc8 100644 --- package/go/go.mk +++ package/go/go.mk @@ -99,8 +99,8 @@ HOST_GO_HOST_ENV = \ $(HOST_GO_COMMON_ENV) \ GOARCH="" \ GOCACHE="$(HOST_GO_HOST_CACHE)" \ - CC="$(HOST_CCNOCCACHE)" \ - CXX="$(HOST_CXXNOCCACHE)" \ + CC="$(HOSTCC_NOCCACHE)" \ + CXX="$(HOSTCXX_NOCCACHE)" \ CGO_CFLAGS="$(HOST_CFLAGS)" \ CGO_CXXFLAGS="$(HOST_CXXFLAGS)" \ CGO_LDFLAGS="$(HOST_LDFLAGS)" -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/go: fix a typo in CC and CXX env values 2020-12-18 9:57 [Buildroot] [PATCH] package/go: fix a typo in CC and CXX env values Michael Baudino @ 2020-12-19 11:11 ` Yann E. MORIN 2020-12-19 11:38 ` Michael Baudino 2020-12-22 10:41 ` Peter Korsgaard 1 sibling, 1 reply; 4+ messages in thread From: Yann E. MORIN @ 2020-12-19 11:11 UTC (permalink / raw) To: buildroot Michael, All, On 2020-12-18 09:57 +0000, Michael Baudino spake thusly: > This commit fixes a typo in variable names that caused CC and CXX > environment variables to be empty. > > Signed-off-by: Michael Baudino <michael@baudi.no> Applied to master, thanks. However, see a little comment, below... > --- > package/go/go.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git package/go/go.mk package/go/go.mk > index d9f4905..cabbdc8 100644 > --- package/go/go.mk > +++ package/go/go.mk I'm not sure how you generated your patch, but this does not apply as-is because it is not the expected depth, so git-am chokes on it. Next time, please use 'git send-email' to send your patches, as it ensures that patches are properly formatted. I fixed it locally (and will do so on your next patch too), so no need to resend those two. Regards, Yann E. MORIN. > @@ -99,8 +99,8 @@ HOST_GO_HOST_ENV = \ > $(HOST_GO_COMMON_ENV) \ > GOARCH="" \ > GOCACHE="$(HOST_GO_HOST_CACHE)" \ > - CC="$(HOST_CCNOCCACHE)" \ > - CXX="$(HOST_CXXNOCCACHE)" \ > + CC="$(HOSTCC_NOCCACHE)" \ > + CXX="$(HOSTCXX_NOCCACHE)" \ > CGO_CFLAGS="$(HOST_CFLAGS)" \ > CGO_CXXFLAGS="$(HOST_CXXFLAGS)" \ > CGO_LDFLAGS="$(HOST_LDFLAGS)" > -- > 2.7.4 > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/go: fix a typo in CC and CXX env values 2020-12-19 11:11 ` Yann E. MORIN @ 2020-12-19 11:38 ` Michael Baudino 0 siblings, 0 replies; 4+ messages in thread From: Michael Baudino @ 2020-12-19 11:38 UTC (permalink / raw) To: buildroot Hi Yann, Thanks for taking the manual extra steps ? (on both patches!) I created the patch with `git format-patch` but I have `diff.noprefix` in my global git config, may this have caused the depth issue? Anyway, thanks for accepting the patch and for all the work done on Buildroot ?? -------- Original Message -------- On Dec 19, 2020, 12:11, Yann E. MORIN wrote: > Michael, All, > > On 2020-12-18 09:57 +0000, Michael Baudino spake thusly: >> This commit fixes a typo in variable names that caused CC and CXX >> environment variables to be empty. >> >> Signed-off-by: Michael Baudino <michael@baudi.no> > > Applied to master, thanks. > > However, see a little comment, below... > >> --- >> package/go/go.mk | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git package/go/go.mk package/go/go.mk >> index d9f4905..cabbdc8 100644 >> --- package/go/go.mk >> +++ package/go/go.mk > > I'm not sure how you generated your patch, but this does not apply as-is > because it is not the expected depth, so git-am chokes on it. > > Next time, please use 'git send-email' to send your patches, as it > ensures that patches are properly formatted. > > I fixed it locally (and will do so on your next patch too), so no need > to resend those two. > > Regards, > Yann E. MORIN. > >> @@ -99,8 +99,8 @@ HOST_GO_HOST_ENV = \ >> $(HOST_GO_COMMON_ENV) \ >> GOARCH="" \ >> GOCACHE="$(HOST_GO_HOST_CACHE)" \ >> - CC="$(HOST_CCNOCCACHE)" \ >> - CXX="$(HOST_CXXNOCCACHE)" \ >> + CC="$(HOSTCC_NOCCACHE)" \ >> + CXX="$(HOSTCXX_NOCCACHE)" \ >> CGO_CFLAGS="$(HOST_CFLAGS)" \ >> CGO_CXXFLAGS="$(HOST_CXXFLAGS)" \ >> CGO_LDFLAGS="$(HOST_LDFLAGS)" >> -- >> 2.7.4 >> _______________________________________________ >> buildroot mailing list >> buildroot at busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20201219/a3297b6e/attachment.html> ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/go: fix a typo in CC and CXX env values 2020-12-18 9:57 [Buildroot] [PATCH] package/go: fix a typo in CC and CXX env values Michael Baudino 2020-12-19 11:11 ` Yann E. MORIN @ 2020-12-22 10:41 ` Peter Korsgaard 1 sibling, 0 replies; 4+ messages in thread From: Peter Korsgaard @ 2020-12-22 10:41 UTC (permalink / raw) To: buildroot >>>>> "Michael" == Michael Baudino <michael@baudi.no> writes: > This commit fixes a typo in variable names that caused CC and CXX > environment variables to be empty. > Signed-off-by: Michael Baudino <michael@baudi.no> Committed to 2020.11.x, thanks. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-22 10:41 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-12-18 9:57 [Buildroot] [PATCH] package/go: fix a typo in CC and CXX env values Michael Baudino 2020-12-19 11:11 ` Yann E. MORIN 2020-12-19 11:38 ` Michael Baudino 2020-12-22 10:41 ` Peter Korsgaard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox