Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/5] support/scripts/gen-bootlin-toolchains: riscv32 use a pre-2.33 glibc version without RPC support
Date: Tue, 29 Dec 2020 22:05:17 +0100	[thread overview]
Message-ID: <20201229220517.6638e22c@windsurf> (raw)
In-Reply-To: <20201207204821.3588178-2-romain.naour@gmail.com>

On Mon,  7 Dec 2020 21:48:18 +0100
Romain Naour <romain.naour@gmail.com> wrote:

> riscv32 has been merged into glibc 2.33 where RPC support has been removed [1].
> 
> Add a special handling for the riscv32 Bootlin bleeding-edge 2020.08-1 toolchain
> since it used a pre-2.33 glibc version [2].
> 
> Other glibc Bootlin toolchain use glibc 2.31 with RPC support enabled.
> 
> This special handling must be removed when all Bootlin toolchain has been
> rebuild with glibc > 2.32.
> 
> [1] https://sourceware.org/pipermail/libc-announce/2020/000029.html
> [2] https://git.buildroot.net/buildroot/commit/?id=a4889545aa653e7f001f212eda169e7d676aefc0
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  support/scripts/gen-bootlin-toolchains | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

So, as discussed, this approach was not really great. Instead, I've
merged your pull request on toolchains-builder, and manually fixed up
the existing toolchain fragments (for the latest glibc toolchains) so
that they carry the proper RPC information. Then, I applied
https://git.buildroot.org/buildroot/commit/?id=8cba5463deb263e1581895a58fef089e8ec02380
to gen-bootlin-toolchains to leverage this correct information in the
fragments.

So I've marked this particular patch of yours as Rejected.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2020-12-29 21:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 20:48 [Buildroot] [PATCH 1/5] package/ogre: bump to version 1.12.9 Romain Naour
2020-12-07 20:48 ` [Buildroot] [PATCH 2/5] support/scripts/gen-bootlin-toolchains: riscv32 use a pre-2.33 glibc version without RPC support Romain Naour
2020-12-07 21:50   ` Thomas Petazzoni
2020-12-07 22:30     ` Romain Naour
2020-12-08 10:55       ` Thomas Petazzoni
2020-12-29 21:05   ` Thomas Petazzoni [this message]
2020-12-07 20:48 ` [Buildroot] [PATCH 3/5] toolchain/toolchain-external/toolchain-external-bootlin: regenerate for riscv32 toolchain Romain Naour
2020-12-29 21:05   ` Thomas Petazzoni
2020-12-07 20:48 ` [Buildroot] [PATCH 4/5] support/{config-fragments, testing}: select INET_RPC option for custom glibc external toolchains Romain Naour
2020-12-07 21:52   ` Thomas Petazzoni
2020-12-07 22:33     ` Romain Naour
2020-12-29 21:06   ` Thomas Petazzoni
2020-12-07 20:48 ` [Buildroot] [PATCH 5/5] package/glibc: bump to version 2.32-23-g050022910be1d1f5c11cd5168f1685ad4f9580d2 Romain Naour
2020-12-29 22:34   ` Yann E. MORIN
2020-12-29 22:37     ` Thomas Petazzoni
2020-12-29 22:22 ` [Buildroot] [PATCH 1/5] package/ogre: bump to version 1.12.9 Thomas Petazzoni
2021-01-04 21:02   ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201229220517.6638e22c@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox