[Buildroot] [PATCH 1/5] package/ogre: bump to version 1.12.9

[Romain Naour <romain.naour@gmail.com>]

Hello Thomas,

Le 29/12/2020 ? 23:22, Thomas Petazzoni a ?crit?:
> Hello Romain,
> 
> On Mon,  7 Dec 2020 21:48:17 +0100
> Romain Naour <romain.naour@gmail.com> wrote:
> 
>> Remove upstream patch [1].
>>
>> tinyxml has been replaced by pugixml [2].
>>
>> Switch to git download method since github release without
>> the complete source code in the tarball [3].
>>
>> Update indentation of hash file (two spaces).
>>
>> The sdl2-config.cmake generated by sdl2 package is broken for
>> cross-compilation since it add /usr/include/SDL2 in CFLAGS.
>>
>> Such flags are unsafe for cross-compilation since it mixes
>> headers for the host and target.
>>
>> sdl2-config.cmake must be removed from staging since
>> we are using autotools build system to build sdl2 package
>> [4][5].
> 
> I'm confused by all these explanations about sdl2-config.cmake, because
> they appear here in this patch... but there's nothing related to that
> in the patch. And in fact your sdl2-config.cmake fix has already been
> merged in commit d59261836a2ae2d024645b1e286540dd4269b6c8.

Yes, this patch (2/2) was part of the series containing the sdl2-config.cmake fix.
But only the first patch was applied d59261836a2ae2d024645b1e286540dd4269b6c8.

> 
>> ogre 1.12.7 only include <sys/sysctl.h> for iOS in order to
>> build with glibc >= 2.32 [6].
> 
> And? So what?

With the glibc version but the current ogre version (1.12.0) doesn't build due
to <sys/sysctl.h>.

> 
> 
>> +OGRE_VERSION = v1.12.9
> 
> We don't want the leading "v" in the version variable. I'm not sure how
> we handle that for git-based downloads. With <pkg>_DL_VERSION ?

Maybe use the git hash instead?

> 
>> +OGRE_SITE = https://github.com/OGRECave/ogre
>> +OGRE_SITE_METHOD = git
>> +OGRE_LICENSE = MIT (main library, DeferredShadingMedia samples), Public Domain (samples and plugins)
>>  OGRE_LICENSE_FILES = LICENSE
>>  OGRE_INSTALL_STAGING = YES
>>  
>> -# Ogre use a bundled version of tinyxml
>> +# Download with imgui submodule (https://github.com/ocornut/imgui

ok

Best regards,
Romain


> 
> Missing closing parenthesis.
> 
> Thanks!
> 
> Thomas
>