Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/p11-kit: fix build without tasn1
@ 2020-12-30 19:20 Fabrice Fontaine
  2020-12-30 20:30 ` Yann E. MORIN
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2020-12-30 19:20 UTC (permalink / raw)
  To: buildroot

Commit d82da39d55ea16c3c8aa3c5a8ea91fd6c2ceafbb forgot to move
BR2_PACKAGE_CA_CERTIFICATES condition under BR2_PACKAGE_LIBTASN1 to
avoid the following build failure:

checking if trust module is enabled... configure: WARNING: --with-libtasn1 is needed in order to build the trust module, disabling
no
checking for trust module paths... configure: error: need --enable-trust-module in order to specify trust module paths.

Fixes:
 - http://autobuild.buildroot.org/results/e7f68205e1b776f9af34e6017f6eb17f46aa2f19

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/p11-kit/p11-kit.mk | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/package/p11-kit/p11-kit.mk b/package/p11-kit/p11-kit.mk
index c2a7b23e9d..1ffc7e21c8 100644
--- a/package/p11-kit/p11-kit.mk
+++ b/package/p11-kit/p11-kit.mk
@@ -13,12 +13,6 @@ P11_KIT_CONF_ENV = ac_cv_have_decl_program_invocation_short_name=yes \
 P11_KIT_LICENSE = BSD-3-Clause
 P11_KIT_LICENSE_FILES = COPYING
 
-ifeq ($(BR2_PACKAGE_CA_CERTIFICATES),y)
-P11_KIT_CONF_OPTS += --with-trust-paths=/etc/ssl/certs/ca-certificates.crt
-else
-P11_KIT_CONF_OPTS += --without-trust-paths
-endif
-
 ifeq ($(BR2_PACKAGE_LIBFFI),y)
 P11_KIT_DEPENDENCIES += host-pkgconf libffi
 P11_KIT_CONF_OPTS += --with-libffi
@@ -28,9 +22,18 @@ endif
 
 ifeq ($(BR2_PACKAGE_LIBTASN1),y)
 P11_KIT_DEPENDENCIES += host-pkgconf libtasn1
-P11_KIT_CONF_OPTS += --with-libtasn1
+P11_KIT_CONF_OPTS += \
+	--enable-trust-module \
+	--with-libtasn1
+ifeq ($(BR2_PACKAGE_CA_CERTIFICATES),y)
+P11_KIT_CONF_OPTS += --with-trust-paths=/etc/ssl/certs/ca-certificates.crt
+else
+P11_KIT_CONF_OPTS += --without-trust-paths
+endif
 else
-P11_KIT_CONF_OPTS += --without-libtasn1
+P11_KIT_CONF_OPTS += \
+	--disable-trust-module \
+	--without-libtasn1
 endif
 
 $(eval $(autotools-package))
-- 
2.29.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] package/p11-kit: fix build without tasn1
  2020-12-30 19:20 [Buildroot] [PATCH 1/1] package/p11-kit: fix build without tasn1 Fabrice Fontaine
@ 2020-12-30 20:30 ` Yann E. MORIN
  0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2020-12-30 20:30 UTC (permalink / raw)
  To: buildroot

On 2020-12-30 20:20 +0100, Fabrice Fontaine spake thusly:
> Commit d82da39d55ea16c3c8aa3c5a8ea91fd6c2ceafbb forgot to move
> BR2_PACKAGE_CA_CERTIFICATES condition under BR2_PACKAGE_LIBTASN1 to
> avoid the following build failure:
> 
> checking if trust module is enabled... configure: WARNING: --with-libtasn1 is needed in order to build the trust module, disabling
> no
> checking for trust module paths... configure: error: need --enable-trust-module in order to specify trust module paths.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e7f68205e1b776f9af34e6017f6eb17f46aa2f19
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/p11-kit/p11-kit.mk | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
> 
> diff --git a/package/p11-kit/p11-kit.mk b/package/p11-kit/p11-kit.mk
> index c2a7b23e9d..1ffc7e21c8 100644
> --- a/package/p11-kit/p11-kit.mk
> +++ b/package/p11-kit/p11-kit.mk
> @@ -13,12 +13,6 @@ P11_KIT_CONF_ENV = ac_cv_have_decl_program_invocation_short_name=yes \
>  P11_KIT_LICENSE = BSD-3-Clause
>  P11_KIT_LICENSE_FILES = COPYING
>  
> -ifeq ($(BR2_PACKAGE_CA_CERTIFICATES),y)
> -P11_KIT_CONF_OPTS += --with-trust-paths=/etc/ssl/certs/ca-certificates.crt
> -else
> -P11_KIT_CONF_OPTS += --without-trust-paths
> -endif
> -
>  ifeq ($(BR2_PACKAGE_LIBFFI),y)
>  P11_KIT_DEPENDENCIES += host-pkgconf libffi
>  P11_KIT_CONF_OPTS += --with-libffi
> @@ -28,9 +22,18 @@ endif
>  
>  ifeq ($(BR2_PACKAGE_LIBTASN1),y)
>  P11_KIT_DEPENDENCIES += host-pkgconf libtasn1
> -P11_KIT_CONF_OPTS += --with-libtasn1
> +P11_KIT_CONF_OPTS += \
> +	--enable-trust-module \
> +	--with-libtasn1
> +ifeq ($(BR2_PACKAGE_CA_CERTIFICATES),y)
> +P11_KIT_CONF_OPTS += --with-trust-paths=/etc/ssl/certs/ca-certificates.crt
> +else
> +P11_KIT_CONF_OPTS += --without-trust-paths
> +endif
>  else
> -P11_KIT_CONF_OPTS += --without-libtasn1
> +P11_KIT_CONF_OPTS += \
> +	--disable-trust-module \
> +	--without-libtasn1
>  endif
>  
>  $(eval $(autotools-package))
> -- 
> 2.29.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-30 20:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-30 19:20 [Buildroot] [PATCH 1/1] package/p11-kit: fix build without tasn1 Fabrice Fontaine
2020-12-30 20:30 ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox