* [Buildroot] [PATCH v2,1/1] package/libllcp: drop wrong comment
@ 2020-12-13 22:03 Fabrice Fontaine
2020-12-30 22:56 ` Thomas Petazzoni
2021-01-05 16:47 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2020-12-13 22:03 UTC (permalink / raw)
To: buildroot
Dependency on threads comes from libllcp itself not from libusb (which
is not even selected)
While at it, also add a comment about this dependency
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2:
- Add a comment
package/libllcp/Config.in | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/package/libllcp/Config.in b/package/libllcp/Config.in
index 1660e92a87..5dc5c36a67 100644
--- a/package/libllcp/Config.in
+++ b/package/libllcp/Config.in
@@ -1,9 +1,12 @@
config BR2_PACKAGE_LIBLLCP
bool "libllcp"
- depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
+ depends on BR2_TOOLCHAIN_HAS_THREADS
select BR2_PACKAGE_LIBNFC
help
Library extending libnfc with support for Logical Link Control
Protocol.
https://github.com/nfc-tools/libllcp
+
+comment "libllcp needs a toolchain w/ threads"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2,1/1] package/libllcp: drop wrong comment
2020-12-13 22:03 [Buildroot] [PATCH v2,1/1] package/libllcp: drop wrong comment Fabrice Fontaine
@ 2020-12-30 22:56 ` Thomas Petazzoni
2021-01-05 16:47 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2020-12-30 22:56 UTC (permalink / raw)
To: buildroot
On Sun, 13 Dec 2020 23:03:29 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Dependency on threads comes from libllcp itself not from libusb (which
> is not even selected)
>
> While at it, also add a comment about this dependency
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2:
> - Add a comment
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2,1/1] package/libllcp: drop wrong comment
2020-12-13 22:03 [Buildroot] [PATCH v2,1/1] package/libllcp: drop wrong comment Fabrice Fontaine
2020-12-30 22:56 ` Thomas Petazzoni
@ 2021-01-05 16:47 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-01-05 16:47 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Dependency on threads comes from libllcp itself not from libusb (which
> is not even selected)
> While at it, also add a comment about this dependency
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2:
> - Add a comment
Committed to 2020.02.x and 2020.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-05 16:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-13 22:03 [Buildroot] [PATCH v2,1/1] package/libllcp: drop wrong comment Fabrice Fontaine
2020-12-30 22:56 ` Thomas Petazzoni
2021-01-05 16:47 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox