From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/6] package/mrouted: menuconfig support for enabling rsrr support
Date: Sat, 23 Jan 2021 21:51:17 +0100 [thread overview]
Message-ID: <20210123205117.GC926565@scaer> (raw)
In-Reply-To: <20210123103155.2599311-7-troglobit@gmail.com>
On 2021-01-23 11:31 +0100, Joachim Wiberg spake thusly:
> Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
> ---
> package/mrouted/Config.in | 12 ++++++++++++
> package/mrouted/mrouted.mk | 2 +-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/package/mrouted/Config.in b/package/mrouted/Config.in
> index 95b4fb3825..30d32a4310 100644
> --- a/package/mrouted/Config.in
> +++ b/package/mrouted/Config.in
> @@ -11,3 +11,15 @@ config BR2_PACKAGE_MROUTED
> Note: at least two interfaces with MULTICAST flag is requried.
>
> http://github.com/troglobit/mrouted
> +
> +if BR2_PACKAGE_MROUTED
> +
> +config BR2_PACKAGE_MROUTED_RSRR
> + bool "enable RSRR for RSVP"
> + help
> + Routing Support for Resource Reservation, currently used by RSVP.
> + This is an EXPERIMENTAL feature.
> +
> + For details, see http://tools.ietf.org/html/draft-ietf-rsvp-routing-02
I've fixed some minor coding style issue:
$ make check-pacakge
[...]
package/mrouted/Config.in:20: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
package/mrouted/Config.in:23: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
[...]
> +endif
> diff --git a/package/mrouted/mrouted.mk b/package/mrouted/mrouted.mk
> index 558efa946e..74e4a0e97e 100644
> --- a/package/mrouted/mrouted.mk
> +++ b/package/mrouted/mrouted.mk
> @@ -11,7 +11,7 @@ MROUTED_DEPENDENCIES = host-bison
> MROUTED_LICENSE = BSD-3-Clause
> MROUTED_LICENSE_FILES = LICENSE
> MROUTED_CONF_OPTS = --prefix=/usr --sysconfdir=/etc --localstatedir=/var
> -MROUTED_CONF_OPTS += --enable-rsrr
> +MROUTED_CONF_OPTS += $(if $(BR2_PACKAGE_MROUTED_RSRR),--enable-rsrr,--disable-rsrr)
I've switched to using the more traditional ifeq-else-endif block.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> MROUTED_CPE_ID_VENDOR = troglobit
>
> define MROUTED_INSTALL_INIT_SYSV
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-01-23 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 10:31 [Buildroot] [PATCH 0/6] package/mrouted: bump version and improve integration Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 1/6] package/mrouted: bump to version 4.2 Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 2/6] package/mrouted: ensure multicast routing is enabled in kernel Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 3/6] package/mrouted: update description a bit, mention oper. requirement Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 4/6] package/mrouted: add sysv init script Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 5/6] package/mrouted: for merged usr, install to /usr by default, not / Joachim Wiberg
2021-01-23 20:57 ` Yann E. MORIN
2021-01-23 21:59 ` Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 6/6] package/mrouted: menuconfig support for enabling rsrr support Joachim Wiberg
2021-01-23 20:51 ` Yann E. MORIN [this message]
2021-01-23 22:02 ` Joachim Wiberg
2021-01-23 20:46 ` [Buildroot] [PATCH 0/6] package/mrouted: bump version and improve integration Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123205117.GC926565@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox