From: Joachim Wiberg <troglobit@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/6] package/mrouted: menuconfig support for enabling rsrr support
Date: Sat, 23 Jan 2021 23:02:09 +0100 [thread overview]
Message-ID: <8735yrwbvi.fsf@gmail.com> (raw)
In-Reply-To: <20210123205117.GC926565@scaer>
Hi Yann!
On Sat, Jan 23, 2021 at 21:51, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> On 2021-01-23 11:31 +0100, Joachim Wiberg spake thusly:
> I've fixed some minor coding style issue:
> package/mrouted/Config.in:20: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
> package/mrouted/Config.in:23: help text: <tab><2 spaces><62 chars> (http://nightly.buildroot.org/#writing-rules-config-in)
> [...]
Oups, thank you! I'll make sure to train my Emacs better :)
>> +MROUTED_CONF_OPTS += $(if $(BR2_PACKAGE_MROUTED_RSRR),--enable-rsrr,--disable-rsrr)
> I've switched to using the more traditional ifeq-else-endif block.
Thanks! (Copied from another package .mk, felt wrong while doing it)
> Applied to master, thanks.
Awesome :)
Best regards
/Joachim
next prev parent reply other threads:[~2021-01-23 22:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 10:31 [Buildroot] [PATCH 0/6] package/mrouted: bump version and improve integration Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 1/6] package/mrouted: bump to version 4.2 Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 2/6] package/mrouted: ensure multicast routing is enabled in kernel Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 3/6] package/mrouted: update description a bit, mention oper. requirement Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 4/6] package/mrouted: add sysv init script Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 5/6] package/mrouted: for merged usr, install to /usr by default, not / Joachim Wiberg
2021-01-23 20:57 ` Yann E. MORIN
2021-01-23 21:59 ` Joachim Wiberg
2021-01-23 10:31 ` [Buildroot] [PATCH 6/6] package/mrouted: menuconfig support for enabling rsrr support Joachim Wiberg
2021-01-23 20:51 ` Yann E. MORIN
2021-01-23 22:02 ` Joachim Wiberg [this message]
2021-01-23 20:46 ` [Buildroot] [PATCH 0/6] package/mrouted: bump version and improve integration Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735yrwbvi.fsf@gmail.com \
--to=troglobit@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox