Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] configs/bananapi_m1_plus_defconfig: new defconfig
Date: Mon, 25 Jan 2021 08:51:31 +0100	[thread overview]
Message-ID: <20210125085131.3829173f@windsurf.home> (raw)
In-Reply-To: <4f49c391-6275-cf49-6751-921f7484aa99@gmail.com>

Hello Filip,

On Sun, 24 Jan 2021 18:50:45 +0100
Filip <fskoneczny@gmail.com> wrote:

> >> +BR2_TARGET_GENERIC_HOSTNAME="bananapi"
> >> +BR2_TARGET_GENERIC_ISSUE="Welcome to Banana Pi!"
> >> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y  
> > 
> > Is this needed for automatic loading of modules ?  
> 
> Yes, it was loading brcmfmac automatically, I'm not sure though if this is desired in defconfig.
> After comparing to other configs I decided to remove it and add "modprobe brcmfmac" to readme.txt in proper section instead.
> Let me know if it's OK, or better to leave it to load automatically or something else.

I'd say let's keep mdev then, it's nice if the module gets loaded
automatically.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2021-01-25  7:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 17:28 [Buildroot] [PATCH 1/1] configs/bananapi_m1_plus_defconfig: new defconfig Filip Skoneczny
2021-01-23 20:40 ` Thomas Petazzoni
2021-01-24 17:50   ` Filip
2021-01-25  7:51     ` Thomas Petazzoni [this message]
2021-01-25 17:51       ` Filip

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125085131.3829173f@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox