From: Filip <fskoneczny@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] configs/bananapi_m1_plus_defconfig: new defconfig
Date: Mon, 25 Jan 2021 18:51:30 +0100 [thread overview]
Message-ID: <e5767875-8465-49e9-a6f3-9025fc6750e8@gmail.com> (raw)
In-Reply-To: <20210125085131.3829173f@windsurf.home>
Hi again Thomas. Corrected patch is now available:
[v4] configs/bananapi_m1_plus_defconfig: new defconfig
Let me know in case you've noticed anything else to fix.
Thanks again for guiding me through the first contribution :)
Filip
On 25.01.2021 08:51, Thomas Petazzoni wrote:
> Hello Filip,
>
> On Sun, 24 Jan 2021 18:50:45 +0100
> Filip <fskoneczny@gmail.com> wrote:
>
>>>> +BR2_TARGET_GENERIC_HOSTNAME="bananapi"
>>>> +BR2_TARGET_GENERIC_ISSUE="Welcome to Banana Pi!"
>>>> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
>>>
>>> Is this needed for automatic loading of modules ?
>>
>> Yes, it was loading brcmfmac automatically, I'm not sure though if this is desired in defconfig.
>> After comparing to other configs I decided to remove it and add "modprobe brcmfmac" to readme.txt in proper section instead.
>> Let me know if it's OK, or better to leave it to load automatically or something else.
>
> I'd say let's keep mdev then, it's nice if the module gets loaded
> automatically.
>
> Thanks!
>
> Thomas
>
prev parent reply other threads:[~2021-01-25 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 17:28 [Buildroot] [PATCH 1/1] configs/bananapi_m1_plus_defconfig: new defconfig Filip Skoneczny
2021-01-23 20:40 ` Thomas Petazzoni
2021-01-24 17:50 ` Filip
2021-01-25 7:51 ` Thomas Petazzoni
2021-01-25 17:51 ` Filip [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5767875-8465-49e9-a6f3-9025fc6750e8@gmail.com \
--to=fskoneczny@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox