From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/8] package/opkg-utils: remove build step
Date: Sat, 13 Mar 2021 09:04:17 +0100 [thread overview]
Message-ID: <20210313080417.GM2737665@scaer> (raw)
In-Reply-To: <20210312200534.923-2-ryan.barnett@rockwellcollins.com>
On 2021-03-12 14:05 -0600, Ryan Barnett spake thusly:
> opkg-utils is a package that only provides bash and python scripts.
> Upon further inspection of the Makefile for the package, invoking
> `make` is equivalent to `make install`.
That is not really true: 'make' does not install, which 'make isntall'
does; to they are not equivalent.
In fact, 'make' only buiold the manpage, and as you explained in the
following patch, we don't want to build+install it.
So by inverting the order f patches 2 and 1, building the manpage is no
longer ncessary as it is no longer installed.
(if we'd keep your initial order, the build of the manpage would happen
durign installation, which is not nice)
I've added a small comment to explain why we only have an install step.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> The makes the build step
> unnecessary so remove it.
>
> Signed-off-by: Ryan Barnett <ryan.barnett@rockwellcollins.com>
> ---
> package/opkg-utils/opkg-utils.mk | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/package/opkg-utils/opkg-utils.mk b/package/opkg-utils/opkg-utils.mk
> index a94a4cd5cd..47fc4c63b4 100644
> --- a/package/opkg-utils/opkg-utils.mk
> +++ b/package/opkg-utils/opkg-utils.mk
> @@ -12,10 +12,6 @@ OPKG_UTILS_LICENSE_FILES = COPYING
>
> HOST_OPKG_UTILS_DEPENDENCIES += $(BR2_PYTHON3_HOST_DEPENDENCY)
>
> -define HOST_OPKG_UTILS_BUILD_CMDS
> - $(MAKE) -C $(@D) $(HOST_CONFIGURE_OPTS)
> -endef
> -
> define HOST_OPKG_UTILS_INSTALL_CMDS
> $(MAKE) -C $(@D) PREFIX=$(HOST_DIR) install
> endef
> --
> 2.17.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-03-13 8:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 20:05 [Buildroot] [PATCH 0/8] package/opkg-utils: add target build Ryan Barnett
2021-03-12 20:05 ` [Buildroot] [PATCH 1/8] package/opkg-utils: remove build step Ryan Barnett
2021-03-13 8:04 ` Yann E. MORIN [this message]
2021-03-20 16:43 ` Peter Korsgaard
2021-03-12 20:05 ` [Buildroot] [PATCH 2/8] package/opkg-utils: install only utility scripts Ryan Barnett
2021-03-20 16:43 ` Peter Korsgaard
2021-03-12 20:05 ` [Buildroot] [PATCH 3/8] package/diffutils: add host package Ryan Barnett
2021-03-20 16:47 ` Peter Korsgaard
2021-03-12 20:05 ` [Buildroot] [PATCH 4/8] package/findutils: " Ryan Barnett
2021-03-12 20:05 ` [Buildroot] [PATCH 5/8] package/grep: " Ryan Barnett
2021-03-12 20:05 ` [Buildroot] [PATCH 6/8] package/opkg-utils: add missing dependencies for host build Ryan Barnett
2021-03-12 22:52 ` Yann E. MORIN
2021-03-15 16:13 ` Ryan Barnett
2021-03-20 16:49 ` Peter Korsgaard
2021-03-12 20:05 ` [Buildroot] [PATCH 7/8] package/opkg-utils: add opkg-utils as target pkg Ryan Barnett
2021-03-12 22:56 ` Yann E. MORIN
2021-03-14 18:38 ` Yann E. MORIN
2021-03-12 20:05 ` [Buildroot] [PATCH 8/8] DEVELOPERS: Add Ryan Barnett for opkg and opkg-utils Ryan Barnett
2021-03-14 18:39 ` Yann E. MORIN
2021-03-13 7:59 ` [Buildroot] [PATCH 0/8] package/opkg-utils: add target build Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210313080417.GM2737665@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox