[Buildroot] [PATCH v2 0/6] Some Nios II and OpenRisc Fixes

[Buildroot] [PATCH v2 0/6] Some Nios II and OpenRisc Fixes

[Giulio Benetti]

This patchset applies after this:
https://patchwork.ozlabs.org/project/buildroot/list/?series=232409

and fixes build failures on Nios II and OpenRisc.

---
V1->V2: fixed libcamera patch that breaks Config.in rules
---

Giulio Benetti (6):
  package/libtheora: disable package if binutils is affected from bug
    21464
  package/gnutls: disable package if binutils is affected from bug 21464
  toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
  package/openal: disable package if binutils is affected from bug 27100
  package/libcamera: disable package while building for Nios II
  package/kf5-kcoreaddons: disable package while building for Nios II

 package/gnutls/Config.in              | 4 +++-
 package/kf5/kf5-kcoreaddons/Config.in | 1 +
 package/libcamera/Config.in           | 4 +++-
 package/libtheora/Config.in           | 1 +
 package/openal/Config.in              | 4 +++-
 toolchain/Config.in                   | 6 ++++++
 6 files changed, 17 insertions(+), 3 deletions(-)

-- 
2.25.1

[Buildroot] [PATCH v2 1/6] package/libtheora: disable package if binutils is affected from bug 21464

[Giulio Benetti]

This package is affected from binutils bug 21464, since there is no
workaround, let's disable it.

Fixes:
http://autobuild.buildroot.net/results/6c8/6c87be004adf03955c832be72c0c59749f311f71/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libtheora/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libtheora/Config.in b/package/libtheora/Config.in
index eee9e9b1db..18a450ce99 100644
--- a/package/libtheora/Config.in
+++ b/package/libtheora/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_LIBTHEORA
 	bool "libtheora"
 	select BR2_PACKAGE_LIBOGG
 	select BR2_PACKAGE_LIBVORBIS
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
 	help
 	  A library for the free and open video compression format
 	  "Theora" from the Xiph.org Foundation.
-- 
2.25.1

[Buildroot] [PATCH v2 1/6] package/libtheora: disable package if binutils is affected from bug 21464

[Thomas Petazzoni]

On Wed, 10 Mar 2021 10:14:48 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This package is affected from binutils bug 21464, since there is no
> workaround, let's disable it.
> 
> Fixes:
> http://autobuild.buildroot.net/results/6c8/6c87be004adf03955c832be72c0c59749f311f71/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/libtheora/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libtheora/Config.in b/package/libtheora/Config.in
> index eee9e9b1db..18a450ce99 100644
> --- a/package/libtheora/Config.in
> +++ b/package/libtheora/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_LIBTHEORA
>  	bool "libtheora"
>  	select BR2_PACKAGE_LIBOGG
>  	select BR2_PACKAGE_LIBVORBIS
> +	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464

Not correct: there is a package that selects BR2_PACKAGE_LIBTHEORA.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 1/6] package/libtheora: disable package if binutils is affected from bug 21464

[Thomas Petazzoni]

On Wed, 10 Mar 2021 10:14:48 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This package is affected from binutils bug 21464, since there is no
> workaround, let's disable it.
> 
> Fixes:
> http://autobuild.buildroot.net/results/6c8/6c87be004adf03955c832be72c0c59749f311f71/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/libtheora/Config.in | 1 +
>  1 file changed, 1 insertion(+)

This problem still affects binutils 2.33.1 and 2.34. Did you test with
binutils 2.36 ?

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 1/6] package/libtheora: disable package if binutils is affected from bug 21464

[Giulio Benetti]

Hi Thomas,

On 3/14/21 10:53 PM, Thomas Petazzoni wrote:
> On Wed, 10 Mar 2021 10:14:48 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> This package is affected from binutils bug 21464, since there is no
>> workaround, let's disable it.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/6c8/6c87be004adf03955c832be72c0c59749f311f71/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   package/libtheora/Config.in | 1 +
>>   1 file changed, 1 insertion(+)
> 
> This problem still affects binutils 2.33.1 and 2.34. Did you test with
> binutils 2.36 ?

Yes, tested with 2.36.1 and failed. This is the config used with today's 
master:
BR2_or1k=y
BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
BR2_BINUTILS_VERSION_2_36_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_LIBTHEORA=y

This is the output:
/home/giuliobenetti/git/upstream/or1k-binutils-2.36.1/host/lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld: 
BFD (GNU Binutils) 2.36.1 assertion fail elf32-or1k.c:2377
/home/giuliobenetti/git/upstream/or1k-binutils-2.36.1/host/lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld: 
BFD (GNU Binutils) 2.36.1 assertion fail elf32-or1k.c:2377
/home/giuliobenetti/git/upstream/or1k-binutils-2.36.1/host/lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld: 
BFD (GNU Binutils) 2.36.1 assertion fail elf32-or1k.c:2377
collect2: error: ld returned 1 exit status

and no luck with -O0. I've also double-checked that this is bug 21464 
since its assert changed while binutils version advancing and it always 
asserts on the same point.

I've also pinged at binutils bugzilla:
https://sourceware.org/bugzilla/show_bug.cgi?id=21464

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

[Buildroot] [PATCH v2 2/6] package/gnutls: disable package if binutils is affected from bug 21464

[Giulio Benetti]

This package is affected from binutils bug 21464, since there is no
workaround, let's disable it.

Fixes:
http://autobuild.buildroot.net/results/ce9/ce9050a183a3f1e31cefbc4d4a6d780235466e39/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/gnutls/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/gnutls/Config.in b/package/gnutls/Config.in
index 15b930b6bd..c4fa729e71 100644
--- a/package/gnutls/Config.in
+++ b/package/gnutls/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_GNUTLS
 	# gnulib requires a library that implements wctomb().
 	# This is noticed only when linking with libgnutls.so.
 	depends on BR2_USE_WCHAR
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
 	select BR2_PACKAGE_LIBTASN1
 	select BR2_PACKAGE_NETTLE
 	select BR2_PACKAGE_PCRE
@@ -32,4 +33,5 @@ config BR2_PACKAGE_GNUTLS_TOOLS
 endif
 
 comment "gnutls needs a toolchain w/ wchar, dynamic library"
-	depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS
+	depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \
+		   !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
-- 
2.25.1

[Buildroot] [PATCH v2 2/6] package/gnutls: disable package if binutils is affected from bug 21464

[Thomas Petazzoni]

On Wed, 10 Mar 2021 10:14:49 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This package is affected from binutils bug 21464, since there is no
> workaround, let's disable it.
> 
> Fixes:
> http://autobuild.buildroot.net/results/ce9/ce9050a183a3f1e31cefbc4d4a6d780235466e39/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/gnutls/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/gnutls/Config.in b/package/gnutls/Config.in
> index 15b930b6bd..c4fa729e71 100644
> --- a/package/gnutls/Config.in
> +++ b/package/gnutls/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_GNUTLS
>  	# gnulib requires a library that implements wctomb().
>  	# This is noticed only when linking with libgnutls.so.
>  	depends on BR2_USE_WCHAR
> +	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464

Not correct: there are plenty of packages that select
BR2_PACKAGE_GNUTLS.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 2/6] package/gnutls: disable package if binutils is affected from bug 21464

[Thomas Petazzoni]

On Wed, 10 Mar 2021 10:14:49 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This package is affected from binutils bug 21464, since there is no
> workaround, let's disable it.
> 
> Fixes:
> http://autobuild.buildroot.net/results/ce9/ce9050a183a3f1e31cefbc4d4a6d780235466e39/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

FYI, the latest build failure of gnutls on OpenRISC was in July 2020:

  http://autobuild.buildroot.net/?reason=gnutls%

Since then, no failure.

I just tested this configuration:

BR2_or1k=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_OPENRISC_UCLIBC_STABLE=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_GNUTLS=y
# BR2_TARGET_ROOTFS_TAR is not set

and it builds fine.

Please double check that the failures and bugs still exist before
sending patches. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 2/6] package/gnutls: disable package if binutils is affected from bug 21464

[Giulio Benetti]

On 3/14/21 10:44 PM, Thomas Petazzoni wrote:
> On Wed, 10 Mar 2021 10:14:49 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> This package is affected from binutils bug 21464, since there is no
>> workaround, let's disable it.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/ce9/ce9050a183a3f1e31cefbc4d4a6d780235466e39/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> 
> FYI, the latest build failure of gnutls on OpenRISC was in July 2020:
> 
>    http://autobuild.buildroot.net/?reason=gnutls%
> 
> Since then, no failure.
> 
> I just tested this configuration:
> 
> BR2_or1k=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_OPENRISC_UCLIBC_STABLE=y
> BR2_INIT_NONE=y
> BR2_SYSTEM_BIN_SH_NONE=y
> # BR2_PACKAGE_BUSYBOX is not set
> BR2_PACKAGE_GNUTLS=y
> # BR2_TARGET_ROOTFS_TAR is not set
> 
> and it builds fine.
> 
> Please double check that the failures and bugs still exist before
> sending patches. Thanks!

Ah, sorry, sure I will, and I will do the same for 2 old patches pending
for riscv build failure that probably has been fixed in the meanwhile.

Kind regards
-- 
Giulio Benetti
Benetti Engineering sas

[Buildroot] [PATCH v2 2/6] package/gnutls: disable package if binutils is affected from bug 21464

[Giulio Benetti]

Hi Thomas,

On 3/14/21 10:44 PM, Thomas Petazzoni wrote:
> On Wed, 10 Mar 2021 10:14:49 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> This package is affected from binutils bug 21464, since there is no
>> workaround, let's disable it.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/ce9/ce9050a183a3f1e31cefbc4d4a6d780235466e39/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> 
> FYI, the latest build failure of gnutls on OpenRISC was in July 2020:
> 
>    http://autobuild.buildroot.net/?reason=gnutls%
> 
> Since then, no failure.
> 
> I just tested this configuration:
> 
> BR2_or1k=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_OPENRISC_UCLIBC_STABLE=y
> BR2_INIT_NONE=y
> BR2_SYSTEM_BIN_SH_NONE=y
> # BR2_PACKAGE_BUSYBOX is not set
> BR2_PACKAGE_GNUTLS=y
> # BR2_TARGET_ROOTFS_TAR is not set
> 
> and it builds fine.
> 
> Please double check that the failures and bugs still exist before
> sending patches. Thanks!

Yes, I confirm, this package build correctly now, while others not.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

[Buildroot] [PATCH v2 3/6] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100

[Giulio Benetti]

On OpenRisc binutils it still present ld bug 27100 leading to a package
openal to fail building:
http://autobuild.buildroot.net/results/c05/c053b9e191b31f0b1f8f8c902b602e187f714dc0/

The bug was already reported and it's been updated:
https://sourceware.org/bugzilla/show_bug.cgi?id=27100

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 toolchain/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index f3f9bbe641..f0aff3c64e 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -87,6 +87,12 @@ config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_21464
 	bool
 	default y if BR2_or1k
 
+# https://sourceware.org/bugzilla/show_bug.cgi?id=27100
+# Affect toolchains built with binutils 2.33.1 (fixed in binutils 2.36)
+config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
+	bool
+	default y if BR2_or1k && !BR2_BINUTILS_VERSION_2_36_X
+
 # Atomic types can be:
 #  - never lock-free
 #  - sometimes lock-free
-- 
2.25.1

[Buildroot] [PATCH v2 3/6] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100

[Thomas Petazzoni]

On Wed, 10 Mar 2021 10:14:50 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> On OpenRisc binutils it still present ld bug 27100 leading to a package
> openal to fail building:
> http://autobuild.buildroot.net/results/c05/c053b9e191b31f0b1f8f8c902b602e187f714dc0/
> 
> The bug was already reported and it's been updated:
> https://sourceware.org/bugzilla/show_bug.cgi?id=27100

How do you know it is this bug? The "final link failed: bad value"
message is pretty generic. Did you actually check that those issues no
longer appear with binutils 2.36 ?

> +# https://sourceware.org/bugzilla/show_bug.cgi?id=27100
> +# Affect toolchains built with binutils 2.33.1 (fixed in binutils 2.36)
> +config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
> +	bool
> +	default y if BR2_or1k && !BR2_BINUTILS_VERSION_2_36_X

Obviously, an annoying problem is that the BR2_BINUTILS_VERSION_2_36_X
part of the condition does not take into account external toolchains.
So for external toolchains that have binutils >= 2.36, we still won't
be able to build those packages.

But oh well, for something like OpenRISC, this is perhaps an acceptable
trade-off.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 3/6] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100

[Giulio Benetti]

Hi Thomas,

On 3/14/21 11:05 PM, Thomas Petazzoni wrote:
> On Wed, 10 Mar 2021 10:14:50 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> On OpenRisc binutils it still present ld bug 27100 leading to a package
>> openal to fail building:
>> http://autobuild.buildroot.net/results/c05/c053b9e191b31f0b1f8f8c902b602e187f714dc0/
>>
>> The bug was already reported and it's been updated:
>> https://sourceware.org/bugzilla/show_bug.cgi?id=27100
> 
> How do you know it is this bug? The "final link failed: bad value"
> message is pretty generic. 

You're right, that is not the entire message, it's:
'''
/home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld: 
CMakeFiles/OpenAL.dir/al/source.cpp.o: pc-relative relocation against 
dynamic symbol alSourcePlayv
/home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld: 
final link failed: bad value
'''

and that a package's issue. I think I've added by mistake openal failure 
as a test-case but it's not.

>Did you actually check that those issues no
> longer appear with binutils 2.36 ?
>> +# https://sourceware.org/bugzilla/show_bug.cgi?id=27100
>> +# Affect toolchains built with binutils 2.33.1 (fixed in binutils 2.36)
>> +config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
>> +	bool
>> +	default y if BR2_or1k && !BR2_BINUTILS_VERSION_2_36_X
> 
> Obviously, an annoying problem is that the BR2_BINUTILS_VERSION_2_36_X
> part of the condition does not take into account external toolchains.
> So for external toolchains that have binutils >= 2.36, we still won't
> be able to build those packages.
> 
> But oh well, for something like OpenRISC, this is perhaps an acceptable
> trade-off.
> 
> Thomas
> 

-- 
Giulio Benetti
Benetti Engineering sas

[Buildroot] [PATCH v2 3/6] toolchain: introduce BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100

[Giulio Benetti]

And since only openal package seemed to be "affected by this bug", 
please drop this patch.

Thank you!
Kind regards
-- 
Giulio Benetti
Benetti Engineering sas

On 3/17/21 5:57 PM, Giulio Benetti wrote:
> Hi Thomas,
> 
> On 3/14/21 11:05 PM, Thomas Petazzoni wrote:
>> On Wed, 10 Mar 2021 10:14:50 +0100
>> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>>
>>> On OpenRisc binutils it still present ld bug 27100 leading to a package
>>> openal to fail building:
>>> http://autobuild.buildroot.net/results/c05/c053b9e191b31f0b1f8f8c902b602e187f714dc0/
>>>
>>> The bug was already reported and it's been updated:
>>> https://sourceware.org/bugzilla/show_bug.cgi?id=27100
>>
>> How do you know it is this bug? The "final link failed: bad value"
>> message is pretty generic.
> 
> You're right, that is not the entire message, it's:
> '''
> /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld:
> CMakeFiles/OpenAL.dir/al/source.cpp.o: pc-relative relocation against
> dynamic symbol alSourcePlayv
> /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld:
> final link failed: bad value
> '''
> 
> and that a package's issue. I think I've added by mistake openal failure
> as a test-case but it's not.
> 
>> Did you actually check that those issues no
>> longer appear with binutils 2.36 ?
>>> +# https://sourceware.org/bugzilla/show_bug.cgi?id=27100
>>> +# Affect toolchains built with binutils 2.33.1 (fixed in binutils 2.36)
>>> +config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
>>> +	bool
>>> +	default y if BR2_or1k && !BR2_BINUTILS_VERSION_2_36_X
>>
>> Obviously, an annoying problem is that the BR2_BINUTILS_VERSION_2_36_X
>> part of the condition does not take into account external toolchains.
>> So for external toolchains that have binutils >= 2.36, we still won't
>> be able to build those packages.
>>
>> But oh well, for something like OpenRISC, this is perhaps an acceptable
>> trade-off.
>>
>> Thomas
>>
> 

[Buildroot] [PATCH v2 4/6] package/openal: disable package if binutils is affected from bug 27100

[Giulio Benetti]

This package is affected from binutils bug 21464, since there is no
workaround, let's disable it.

Fixes:
http://autobuild.buildroot.net/results/c05/c053b9e191b31f0b1f8f8c902b602e187f714dc0/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/openal/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/openal/Config.in b/package/openal/Config.in
index 6b0e9973db..def95222de 100644
--- a/package/openal/Config.in
+++ b/package/openal/Config.in
@@ -19,6 +19,7 @@ config BR2_PACKAGE_OPENAL
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11 PR56019
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_PACKAGE_OPENAL_ARCH_SUPPORTS
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
 	help
 	  OpenAL provides capabilities for playing audio in a virtual
 	  3D environment. Distance attenuation, doppler shift, and
@@ -31,4 +32,5 @@ comment "openal needs a toolchain w/ NPTL, C++, gcc >= 4.9"
 	depends on BR2_PACKAGE_OPENAL_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL \
 		|| !BR2_INSTALL_LIBSTDCPP \
-		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 \
+		|| !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
-- 
2.25.1

[Buildroot] [PATCH v2 4/6] package/openal: disable package if binutils is affected from bug 27100

[Thomas Petazzoni]

On Wed, 10 Mar 2021 10:14:51 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This package is affected from binutils bug 21464, since there is no

You're using the BUG_27100 condition, not 21464.

> diff --git a/package/openal/Config.in b/package/openal/Config.in
> index 6b0e9973db..def95222de 100644
> --- a/package/openal/Config.in
> +++ b/package/openal/Config.in
> @@ -19,6 +19,7 @@ config BR2_PACKAGE_OPENAL
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11 PR56019
>  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>  	depends on BR2_PACKAGE_OPENAL_ARCH_SUPPORTS
> +	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100

What about all the things that select BR2_PACKAGE_OPENAL ?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 4/6] package/openal: disable package if binutils is affected from bug 27100

[Giulio Benetti]

Hi Thomas,

following previous e-mail about bug 27100, this is not a binutils bug, 
it's a package link failure. So please drop this patch. Thank you

-- 
Giulio Benetti
Benetti Engineering sas

On 3/14/21 11:07 PM, Thomas Petazzoni wrote:
> On Wed, 10 Mar 2021 10:14:51 +0100
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> 
>> This package is affected from binutils bug 21464, since there is no
> 
> You're using the BUG_27100 condition, not 21464.
> 
>> diff --git a/package/openal/Config.in b/package/openal/Config.in
>> index 6b0e9973db..def95222de 100644
>> --- a/package/openal/Config.in
>> +++ b/package/openal/Config.in
>> @@ -19,6 +19,7 @@ config BR2_PACKAGE_OPENAL
>>   	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11 PR56019
>>   	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>>   	depends on BR2_PACKAGE_OPENAL_ARCH_SUPPORTS
>> +	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27100
> 
> What about all the things that select BR2_PACKAGE_OPENAL ?
> 
> Thomas
> 

[Buildroot] [PATCH v2 5/6] package/libcamera: disable package while building for Nios II

[Giulio Benetti]

This package fails to build with Nios II up to gcc version 10.x and no
work around has been found. So let's disable it whil building for Nios
II.

Fixes:
http://autobuild.buildroot.net/results/8ac/8ac599392f773eecff4773393ef0d0232a22f372/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2: add missing || that prevented building
---
 package/libcamera/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
index b9c243084e..fc8181f55c 100644
--- a/package/libcamera/Config.in
+++ b/package/libcamera/Config.in
@@ -12,6 +12,7 @@ menuconfig BR2_PACKAGE_LIBCAMERA
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
 	depends on !BR2_STATIC_LIBS # gnutls
 	depends on BR2_USE_WCHAR # gnutls
+	depends on !BR2_nios
 	select BR2_PACKAGE_GNUTLS
 	select BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
 	help
@@ -73,4 +74,5 @@ endif # BR2_PACKAGE_LIBCAMERA
 comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7"
 	depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR || \
+		!BR2_nios2
-- 
2.25.1

[Buildroot] [PATCH v2 5/6] package/libcamera: disable package while building for Nios II

[Thomas Petazzoni]

On Wed, 10 Mar 2021 10:14:52 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This package fails to build with Nios II up to gcc version 10.x and no
> work around has been found. So let's disable it whil building for Nios
> II.
> 
> Fixes:
> http://autobuild.buildroot.net/results/8ac/8ac599392f773eecff4773393ef0d0232a22f372/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2: add missing || that prevented building
> ---
>  package/libcamera/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index b9c243084e..fc8181f55c 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -12,6 +12,7 @@ menuconfig BR2_PACKAGE_LIBCAMERA
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
>  	depends on !BR2_STATIC_LIBS # gnutls
>  	depends on BR2_USE_WCHAR # gnutls
> +	depends on !BR2_nios

So for this one, no BR2_TOOLCHAIN_HAS_BUG_xyz ?

Same question for PATCH 6/6 in the series.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/2] package/libcamera: disable package affected by binutils bug 27597

[Giulio Benetti]

This package is affected by binutils bug 27597 and no work around has
been found, so let's disable it if
BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597=y.

Fixes:
http://autobuild.buildroot.net/results/8ac/8ac599392f773eecff4773393ef0d0232a22f372/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/libcamera/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
index b9c243084e..3df9c68feb 100644
--- a/package/libcamera/Config.in
+++ b/package/libcamera/Config.in
@@ -12,6 +12,7 @@ menuconfig BR2_PACKAGE_LIBCAMERA
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
 	depends on !BR2_STATIC_LIBS # gnutls
 	depends on BR2_USE_WCHAR # gnutls
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
 	select BR2_PACKAGE_GNUTLS
 	select BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
 	help
@@ -73,4 +74,5 @@ endif # BR2_PACKAGE_LIBCAMERA
 comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7"
 	depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR || \
+		!BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
-- 
2.25.1

[Buildroot] [PATCH 2/2] package/kf5-kcoreaddons: disable package affected by binutils bug 27597

[Giulio Benetti]

This package is affected by binutils bug 27597 and no work around has
been found, so let's disable it if
BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597=y.

Fixes:
http://autobuild.buildroot.net/results/0c1/0c1e7e094b0990970f28cda2be0e3fe7d82ce6a2/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/kf5/kf5-kcoreaddons/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/kf5/kf5-kcoreaddons/Config.in b/package/kf5/kf5-kcoreaddons/Config.in
index 88fda03ee0..02bd38e395 100644
--- a/package/kf5/kf5-kcoreaddons/Config.in
+++ b/package/kf5/kf5-kcoreaddons/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_KF5_KCOREADDONS
 	bool "kf5-kcoreaddons"
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
 	select BR2_PACKAGE_KF5_EXTRA_CMAKE_MODULES
 	select BR2_PACKAGE_QT5TOOLS
 	select BR2_PACKAGE_QT5TOOLS_LINGUIST_TOOLS
-- 
2.25.1

[Buildroot] [PATCH 1/2] package/libcamera: disable package affected by binutils bug 27597

[Thomas Petazzoni]

On Wed, 17 Mar 2021 17:43:45 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This package is affected by binutils bug 27597 and no work around has
> been found, so let's disable it if
> BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597=y.
> 
> Fixes:
> http://autobuild.buildroot.net/results/8ac/8ac599392f773eecff4773393ef0d0232a22f372/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/libcamera/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index b9c243084e..3df9c68feb 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -12,6 +12,7 @@ menuconfig BR2_PACKAGE_LIBCAMERA
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
>  	depends on !BR2_STATIC_LIBS # gnutls
>  	depends on BR2_USE_WCHAR # gnutls
> +	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597

Perhaps we could just push this dependency to
BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS ?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2] package/libcamera: disable package affected by binutils bug 27597

[Giulio Benetti]

This package is affected by binutils bug 27597 and no work around has
been found, so let's disable it if
BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597=y.

Fixes:
http://autobuild.buildroot.net/results/8ac/8ac599392f773eecff4773393ef0d0232a22f372/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* move BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 under BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
---
 package/libcamera/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
index b9c243084e..92c17df849 100644
--- a/package/libcamera/Config.in
+++ b/package/libcamera/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
 	default y
 	# Invalid packing size of ControlValue struct on m68k
 	depends on !BR2_m68k
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
 
 menuconfig BR2_PACKAGE_LIBCAMERA
 	bool "libcamera"
-- 
2.25.1

[Buildroot] [PATCH v2] package/libcamera: disable package affected by binutils bug 27597

[Arnout Vandecappelle]

On 17/03/2021 18:00, Giulio Benetti wrote:
> This package is affected by binutils bug 27597 and no work around has
> been found, so let's disable it if
> BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597=y.
> 
> Fixes:
> http://autobuild.buildroot.net/results/8ac/8ac599392f773eecff4773393ef0d0232a22f372/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

 Both applied to master, thanks.

 Regards,
 Arnout

> ---
> V1->V2:
> * move BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597 under BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
> ---
>  package/libcamera/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index b9c243084e..92c17df849 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
>  	default y
>  	# Invalid packing size of ControlValue struct on m68k
>  	depends on !BR2_m68k
> +	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_27597
>  
>  menuconfig BR2_PACKAGE_LIBCAMERA
>  	bool "libcamera"
> 

[Buildroot] [PATCH v2 6/6] package/kf5-kcoreaddons: disable package while building for Nios II

[Giulio Benetti]

This package fails to build with Nios II up to gcc version 10.x and no
work around has been found. So let's disable it whil building for Nios
II.

Fixes:
http://autobuild.buildroot.net/results/0c1/0c1e7e094b0990970f28cda2be0e3fe7d82ce6a2/

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 package/kf5/kf5-kcoreaddons/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/kf5/kf5-kcoreaddons/Config.in b/package/kf5/kf5-kcoreaddons/Config.in
index 88fda03ee0..0acb68297b 100644
--- a/package/kf5/kf5-kcoreaddons/Config.in
+++ b/package/kf5/kf5-kcoreaddons/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_KF5_KCOREADDONS
 	bool "kf5-kcoreaddons"
+	depends on !BR2_nios
 	select BR2_PACKAGE_KF5_EXTRA_CMAKE_MODULES
 	select BR2_PACKAGE_QT5TOOLS
 	select BR2_PACKAGE_QT5TOOLS_LINGUIST_TOOLS
-- 
2.25.1