From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 2/2] package/batman-adv: enable B.A.T.M.A.N. V protocol by default
Date: Mon, 15 Mar 2021 20:59:00 +0100 [thread overview]
Message-ID: <20210315195900.GS2737665@scaer> (raw)
In-Reply-To: <20210314223207.13460-2-ps.report@gmx.net>
Peter, All,
On 2021-03-14 23:32 +0100, Peter Seiderer spake thusly:
> As upstream enables CONFIG_BATMAN_ADV_BATMAN_V option since
> 2018.2 by defaullt ([1]) honor this in buildroot and do
> the same (and remove the leagcy experimental comment accordingly).
>
> [1] https://git.open-mesh.org/batman-adv.git/blob/HEAD:/CHANGELOG.rst#l174
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/batman-adv/Config.in | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/package/batman-adv/Config.in b/package/batman-adv/Config.in
> index 9d3d7967b9..f3ac974296 100644
> --- a/package/batman-adv/Config.in
> +++ b/package/batman-adv/Config.in
> @@ -25,11 +25,10 @@ config BR2_PACKAGE_BATMAN_ADV_NC
> https://www.open-mesh.org/projects/batman-adv/wiki/NetworkCoding
>
> config BR2_PACKAGE_BATMAN_ADV_BATMAN_V
> - bool "enable B.A.T.M.A.N. V protocol (experimental)"
> + bool "enable B.A.T.M.A.N. V protocol"
Upstream seems to still consider this to be experimental [0].
> + default y
What we talked about earlier [1], was to always enable it, not to change
the default.
Now, people that have a defconfig file with BATMAN-V disabled (i.e.
there would be nothing in the defconfig as 'is not set' is the default),
will have it enabled now.
So, if upstream recommends to not disable it (do you have a ref?), then
we should just drop our option, and to always enable it.
Thoughts?
[0] https://git.open-mesh.org/batman-adv.git/blob/HEAD:/Makefile#l7
[1] http://lists.busybox.net/pipermail/buildroot/2021-March/305811.html
Regards,
Yann E. MORIN.
> help
> Enables B.A.T.M.A.N. V network protocol.
> - This is the next-gen protocol and is experimental at this
> - time.
>
> https://www.open-mesh.org/projects/batman-adv/wiki/BATMAN_V
>
> --
> 2.30.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-03-15 19:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-14 22:32 [Buildroot] [PATCH v1 1/2] package/batman-adv: fix compile with BR2_PACKAGE_BATMAN_ADV_BATMAN_V disabled Peter Seiderer
2021-03-14 22:32 ` [Buildroot] [PATCH v1 2/2] package/batman-adv: enable B.A.T.M.A.N. V protocol by default Peter Seiderer
2021-03-15 19:59 ` Yann E. MORIN [this message]
2021-03-15 20:49 ` Christian Stewart
2021-03-15 22:12 ` Peter Seiderer
2022-07-24 21:26 ` Arnout Vandecappelle
2021-03-15 19:53 ` [Buildroot] [PATCH v1 1/2] package/batman-adv: fix compile with BR2_PACKAGE_BATMAN_ADV_BATMAN_V disabled Yann E. MORIN
2021-03-15 21:00 ` Christian Stewart
2021-03-15 21:50 ` Peter Seiderer
2021-03-16 1:45 ` Christian Stewart
2021-03-16 18:19 ` Peter Seiderer
2021-03-23 17:26 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315195900.GS2737665@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox