* [Buildroot] [PATCH 1/1] package/qemu: disable NDEBUG
@ 2021-06-24 14:10 Joseph Burt
2021-07-04 19:54 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: Joseph Burt @ 2021-06-24 14:10 UTC (permalink / raw)
To: buildroot
QEMU cannot build with NDEBUG defined.
Signed-off-by: Joseph Burt <caseorum@gmail.com>
---
package/qemu/qemu.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 470c285f16..c397b8883b 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -160,7 +160,7 @@ define QEMU_CONFIGURE_CMDS
unset TARGET_DIR; \
cd $(@D); \
LIBS='$(QEMU_LIBS)' \
- $(TARGET_CONFIGURE_OPTS) \
+ $(filter-out -DNDEBUG,$(TARGET_CONFIGURE_OPTS)) \
$(TARGET_CONFIGURE_ARGS) \
CPP="$(TARGET_CC) -E" \
$(QEMU_VARS) \
@@ -327,7 +327,7 @@ endif
# call the compiler.
define HOST_QEMU_CONFIGURE_CMDS
unset TARGET_DIR; \
- cd $(@D); $(HOST_CONFIGURE_OPTS) CPP="$(HOSTCC) -E" \
+ cd $(@D); $(filter-out -DNDEBUG,$(HOST_CONFIGURE_OPTS)) CPP="$(HOSTCC) -E" \
./configure \
--target-list="$(HOST_QEMU_TARGETS)" \
--prefix="$(HOST_DIR)" \
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] package/qemu: disable NDEBUG
2021-06-24 14:10 [Buildroot] [PATCH 1/1] package/qemu: disable NDEBUG Joseph Burt
@ 2021-07-04 19:54 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2021-07-04 19:54 UTC (permalink / raw)
To: buildroot
Joseph, All,
On 2021-06-24 14:10 +0000, Joseph Burt spake thusly:
> QEMU cannot build with NDEBUG defined.
>
> Signed-off-by: Joseph Burt <caseorum@gmail.com>
We are now no longer setting NDEBUG in the infra; see a1c7cff1a081.
So this patch is no longer needed; I've marked it as rejected.
Thanks!
Regards,
Yann E. MORIN.
> ---
> package/qemu/qemu.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 470c285f16..c397b8883b 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -160,7 +160,7 @@ define QEMU_CONFIGURE_CMDS
> unset TARGET_DIR; \
> cd $(@D); \
> LIBS='$(QEMU_LIBS)' \
> - $(TARGET_CONFIGURE_OPTS) \
> + $(filter-out -DNDEBUG,$(TARGET_CONFIGURE_OPTS)) \
> $(TARGET_CONFIGURE_ARGS) \
> CPP="$(TARGET_CC) -E" \
> $(QEMU_VARS) \
> @@ -327,7 +327,7 @@ endif
> # call the compiler.
> define HOST_QEMU_CONFIGURE_CMDS
> unset TARGET_DIR; \
> - cd $(@D); $(HOST_CONFIGURE_OPTS) CPP="$(HOSTCC) -E" \
> + cd $(@D); $(filter-out -DNDEBUG,$(HOST_CONFIGURE_OPTS)) CPP="$(HOSTCC) -E" \
> ./configure \
> --target-list="$(HOST_QEMU_TARGETS)" \
> --prefix="$(HOST_DIR)" \
> --
> 2.32.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-04 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-24 14:10 [Buildroot] [PATCH 1/1] package/qemu: disable NDEBUG Joseph Burt
2021-07-04 19:54 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox