* [Buildroot] [PATCH 1/1] package/uboot-tools: fix env image help text @ 2021-06-25 9:19 Mirza Kapetanovic 2021-06-27 10:44 ` Yann E. MORIN 2021-07-05 12:19 ` [Buildroot] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool Mirza Kapetanovic 0 siblings, 2 replies; 8+ messages in thread From: Mirza Kapetanovic @ 2021-06-25 9:19 UTC (permalink / raw) To: buildroot BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE is passed almost as is to mkenvimage which, looking at the help text and source code of the tool, doesn't seem to support mulitple files as input. I tried providing multiple files (space separated) and only the last file was included in the resulting environment image. Signed-off-by: Mirza Kapetanovic <mirza.kapetanovic@gmail.com> --- package/uboot-tools/Config.in.host | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/package/uboot-tools/Config.in.host b/package/uboot-tools/Config.in.host index 431cc8631d..7e5c5084c0 100644 --- a/package/uboot-tools/Config.in.host +++ b/package/uboot-tools/Config.in.host @@ -56,15 +56,13 @@ config BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE if BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE config BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE - string "Source files for environment" + string "Source file for environment" default BR2_TARGET_UBOOT_ENVIMAGE_SOURCE if BR2_TARGET_UBOOT_ENVIMAGE_SOURCE != "" # legacy help - Text files describing the environment. Files should have + Text file describing the environment. File should have lines of the form var=value, one per line. Blank lines and lines starting with a # are ignored. - Multiple source files are concatenated in the order listed. - Leave empty to generate image from compiled-in env if a U-boot target build is configured (BR2_TARGET_UBOOT) -- 2.25.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/uboot-tools: fix env image help text 2021-06-25 9:19 [Buildroot] [PATCH 1/1] package/uboot-tools: fix env image help text Mirza Kapetanovic @ 2021-06-27 10:44 ` Yann E. MORIN 2021-07-05 12:29 ` Mirza Kapetanovic 2021-07-05 12:19 ` [Buildroot] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool Mirza Kapetanovic 1 sibling, 1 reply; 8+ messages in thread From: Yann E. MORIN @ 2021-06-27 10:44 UTC (permalink / raw) To: buildroot Mirza, All, On 2021-06-25 11:19 +0200, Mirza Kapetanovic spake thusly: > BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE is passed almost as is to mkenvimage > which, looking at the help text and source code of the tool, doesn't seem to support > mulitple files as input. > > I tried providing multiple files (space separated) and only the last file was included > in the resulting environment image. Can't we instead make that possible? For example, this (totally untested) patch should be a step in that direction, I think: diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk index 8963d6182e..d4392e47bf 100644 --- a/package/uboot-tools/uboot-tools.mk +++ b/package/uboot-tools/uboot-tools.mk @@ -116,7 +116,7 @@ endif ifeq ($(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE),y) -UBOOT_TOOLS_GENERATE_ENV_FILE = $(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE)) +UBOOT_TOOLS_ENV_FILE_SOURCES = $(call qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE)) # If BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE is left empty, we # will use the default environment provided in the U-Boot build @@ -130,7 +130,7 @@ HOST_UBOOT_TOOLS_DEPENDENCIES += uboot # Handle the case where BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE # is left empty, use the default U-Boot environment. -ifeq ($(UBOOT_TOOLS_GENERATE_ENV_FILE),) +ifeq ($(UBOOT_TOOLS_ENV_FILE_SOURCES),) UBOOT_TOOLS_GENERATE_ENV_FILE = $(@D)/boot-env-defaults.txt define HOST_UBOOT_TOOLS_GENERATE_ENV_DEFAULTS CROSS_COMPILE="$(TARGET_CROSS)" \ @@ -138,7 +138,13 @@ define HOST_UBOOT_TOOLS_GENERATE_ENV_DEFAULTS $(UBOOT_SRCDIR) \ > $(UBOOT_TOOLS_GENERATE_ENV_FILE) endef -endif # UBOOT_TOOLS_GENERATE_ENV_FILE +else +UBOOT_TOOLS_GENERATE_ENV_FILE = $(@D)/boot-env-buildroot.txt +define HOST_UBOOT_TOOLS_GENERATE_ENV_DEFAULTS + cat $(UBOOT_TOOLS_ENV_FILE_SOURCES) \ + > $(UBOOT_TOOLS_GENERATE_ENV_FILE) +endef +endif # UBOOT_TOOLS_ENV_FILE_SOURCE endif # BR2_TARGET_UBOOT ifeq ($(BR_BUILDING),y) As I said: totally untested... I can already see that it is broken for the case where uboot is not enabled, so this definitely needs a little bit more of thinking... Can you look into that, please? Regards, Yann E. MORIN. > Signed-off-by: Mirza Kapetanovic <mirza.kapetanovic@gmail.com> > --- > package/uboot-tools/Config.in.host | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/package/uboot-tools/Config.in.host b/package/uboot-tools/Config.in.host > index 431cc8631d..7e5c5084c0 100644 > --- a/package/uboot-tools/Config.in.host > +++ b/package/uboot-tools/Config.in.host > @@ -56,15 +56,13 @@ config BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE > if BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE > > config BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE > - string "Source files for environment" > + string "Source file for environment" > default BR2_TARGET_UBOOT_ENVIMAGE_SOURCE if BR2_TARGET_UBOOT_ENVIMAGE_SOURCE != "" # legacy > help > - Text files describing the environment. Files should have > + Text file describing the environment. File should have > lines of the form var=value, one per line. Blank lines and > lines starting with a # are ignored. > > - Multiple source files are concatenated in the order listed. > - > Leave empty to generate image from compiled-in env if a U-boot > target build is configured (BR2_TARGET_UBOOT) > > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/uboot-tools: fix env image help text 2021-06-27 10:44 ` Yann E. MORIN @ 2021-07-05 12:29 ` Mirza Kapetanovic 2021-07-05 12:29 ` Mirza Kapetanovic 0 siblings, 1 reply; 8+ messages in thread From: Mirza Kapetanovic @ 2021-07-05 12:29 UTC (permalink / raw) To: buildroot I created a new patch with your suggestions, now it concatenates the file before passing it to the env tool. I thought I was replying to this thread when I sent the patch, but it seems I ended up creating a separate patch (patchwork link: http://patchwork.ozlabs.org/project/buildroot/patch/20210705121933.1055057-1-mirza.kapetanovic at gmail.com), let me know if I need to change fix that somehow. On Sun, 27 Jun 2021 at 12:44, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Mirza, All, > > On 2021-06-25 11:19 +0200, Mirza Kapetanovic spake thusly: > > BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE is passed almost as is to > mkenvimage > > which, looking at the help text and source code of the tool, doesn't > seem to support > > mulitple files as input. > > > > I tried providing multiple files (space separated) and only the last > file was included > > in the resulting environment image. > > Can't we instead make that possible? > > For example, this (totally untested) patch should be a step in that > direction, I think: > > diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/ > uboot-tools.mk > index 8963d6182e..d4392e47bf 100644 > --- a/package/uboot-tools/uboot-tools.mk > +++ b/package/uboot-tools/uboot-tools.mk > @@ -116,7 +116,7 @@ endif > > ifeq ($(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE),y) > > -UBOOT_TOOLS_GENERATE_ENV_FILE = $(call > qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE)) > +UBOOT_TOOLS_ENV_FILE_SOURCES = $(call > qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE)) > > # If BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE is left empty, we > # will use the default environment provided in the U-Boot build > @@ -130,7 +130,7 @@ HOST_UBOOT_TOOLS_DEPENDENCIES += uboot > > # Handle the case where BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE > # is left empty, use the default U-Boot environment. > -ifeq ($(UBOOT_TOOLS_GENERATE_ENV_FILE),) > +ifeq ($(UBOOT_TOOLS_ENV_FILE_SOURCES),) > UBOOT_TOOLS_GENERATE_ENV_FILE = $(@D)/boot-env-defaults.txt > define HOST_UBOOT_TOOLS_GENERATE_ENV_DEFAULTS > CROSS_COMPILE="$(TARGET_CROSS)" \ > @@ -138,7 +138,13 @@ define HOST_UBOOT_TOOLS_GENERATE_ENV_DEFAULTS > $(UBOOT_SRCDIR) \ > > $(UBOOT_TOOLS_GENERATE_ENV_FILE) > endef > -endif # UBOOT_TOOLS_GENERATE_ENV_FILE > +else > +UBOOT_TOOLS_GENERATE_ENV_FILE = $(@D)/boot-env-buildroot.txt > +define HOST_UBOOT_TOOLS_GENERATE_ENV_DEFAULTS > + cat $(UBOOT_TOOLS_ENV_FILE_SOURCES) \ > + > $(UBOOT_TOOLS_GENERATE_ENV_FILE) > +endef > +endif # UBOOT_TOOLS_ENV_FILE_SOURCE > endif # BR2_TARGET_UBOOT > > ifeq ($(BR_BUILDING),y) > > As I said: totally untested... I can already see that it is broken for > the case where uboot is not enabled, so this definitely needs a little > bit more of thinking... > > Can you look into that, please? > > Regards, > Yann E. MORIN. > > > Signed-off-by: Mirza Kapetanovic <mirza.kapetanovic@gmail.com> > > --- > > package/uboot-tools/Config.in.host | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/package/uboot-tools/Config.in.host > b/package/uboot-tools/Config.in.host > > index 431cc8631d..7e5c5084c0 100644 > > --- a/package/uboot-tools/Config.in.host > > +++ b/package/uboot-tools/Config.in.host > > @@ -56,15 +56,13 @@ config BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE > > if BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE > > > > config BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE > > - string "Source files for environment" > > + string "Source file for environment" > > default BR2_TARGET_UBOOT_ENVIMAGE_SOURCE if > BR2_TARGET_UBOOT_ENVIMAGE_SOURCE != "" # legacy > > help > > - Text files describing the environment. Files should have > > + Text file describing the environment. File should have > > lines of the form var=value, one per line. Blank lines and > > lines starting with a # are ignored. > > > > - Multiple source files are concatenated in the order listed. > > - > > Leave empty to generate image from compiled-in env if a U-boot > > target build is configured (BR2_TARGET_UBOOT) > > > > -- > > 2.25.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot at busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > -- > > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' > conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ > | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is > no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v > conspiracy. | > > '------------------------------^-------^------------------^--------------------' > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210705/c9cd7e29/attachment.html> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/uboot-tools: fix env image help text 2021-07-05 12:29 ` Mirza Kapetanovic @ 2021-07-05 12:29 ` Mirza Kapetanovic 0 siblings, 0 replies; 8+ messages in thread From: Mirza Kapetanovic @ 2021-07-05 12:29 UTC (permalink / raw) To: buildroot I created a new patch with your suggestions, now it concatenates the file before passing it to the env tool. I thought I was replying to this thread when I sent the patch, but it seems I ended up creating a separate patch (patchwork link: http://patchwork.ozlabs.org/project/buildroot/patch/20210705121933.1055057-1-mirza.kapetanovic at gmail.com), let me know if I need to change fix that somehow. On Sun, 27 Jun 2021 at 12:44, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Mirza, All, > > On 2021-06-25 11:19 +0200, Mirza Kapetanovic spake thusly: > > BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE is passed almost as is to > mkenvimage > > which, looking at the help text and source code of the tool, doesn't > seem to support > > mulitple files as input. > > > > I tried providing multiple files (space separated) and only the last > file was included > > in the resulting environment image. > > Can't we instead make that possible? > > For example, this (totally untested) patch should be a step in that > direction, I think: > > diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/ > uboot-tools.mk > index 8963d6182e..d4392e47bf 100644 > --- a/package/uboot-tools/uboot-tools.mk > +++ b/package/uboot-tools/uboot-tools.mk > @@ -116,7 +116,7 @@ endif > > ifeq ($(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE),y) > > -UBOOT_TOOLS_GENERATE_ENV_FILE = $(call > qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE)) > +UBOOT_TOOLS_ENV_FILE_SOURCES = $(call > qstrip,$(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE)) > > # If BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE is left empty, we > # will use the default environment provided in the U-Boot build > @@ -130,7 +130,7 @@ HOST_UBOOT_TOOLS_DEPENDENCIES += uboot > > # Handle the case where BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE > # is left empty, use the default U-Boot environment. > -ifeq ($(UBOOT_TOOLS_GENERATE_ENV_FILE),) > +ifeq ($(UBOOT_TOOLS_ENV_FILE_SOURCES),) > UBOOT_TOOLS_GENERATE_ENV_FILE = $(@D)/boot-env-defaults.txt > define HOST_UBOOT_TOOLS_GENERATE_ENV_DEFAULTS > CROSS_COMPILE="$(TARGET_CROSS)" \ > @@ -138,7 +138,13 @@ define HOST_UBOOT_TOOLS_GENERATE_ENV_DEFAULTS > $(UBOOT_SRCDIR) \ > > $(UBOOT_TOOLS_GENERATE_ENV_FILE) > endef > -endif # UBOOT_TOOLS_GENERATE_ENV_FILE > +else > +UBOOT_TOOLS_GENERATE_ENV_FILE = $(@D)/boot-env-buildroot.txt > +define HOST_UBOOT_TOOLS_GENERATE_ENV_DEFAULTS > + cat $(UBOOT_TOOLS_ENV_FILE_SOURCES) \ > + > $(UBOOT_TOOLS_GENERATE_ENV_FILE) > +endef > +endif # UBOOT_TOOLS_ENV_FILE_SOURCE > endif # BR2_TARGET_UBOOT > > ifeq ($(BR_BUILDING),y) > > As I said: totally untested... I can already see that it is broken for > the case where uboot is not enabled, so this definitely needs a little > bit more of thinking... > > Can you look into that, please? > > Regards, > Yann E. MORIN. > > > Signed-off-by: Mirza Kapetanovic <mirza.kapetanovic@gmail.com> > > --- > > package/uboot-tools/Config.in.host | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/package/uboot-tools/Config.in.host > b/package/uboot-tools/Config.in.host > > index 431cc8631d..7e5c5084c0 100644 > > --- a/package/uboot-tools/Config.in.host > > +++ b/package/uboot-tools/Config.in.host > > @@ -56,15 +56,13 @@ config BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE > > if BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE > > > > config BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE > > - string "Source files for environment" > > + string "Source file for environment" > > default BR2_TARGET_UBOOT_ENVIMAGE_SOURCE if > BR2_TARGET_UBOOT_ENVIMAGE_SOURCE != "" # legacy > > help > > - Text files describing the environment. Files should have > > + Text file describing the environment. File should have > > lines of the form var=value, one per line. Blank lines and > > lines starting with a # are ignored. > > > > - Multiple source files are concatenated in the order listed. > > - > > Leave empty to generate image from compiled-in env if a U-boot > > target build is configured (BR2_TARGET_UBOOT) > > > > -- > > 2.25.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot at busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > -- > > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' > conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ > | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is > no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v > conspiracy. | > > '------------------------------^-------^------------------^--------------------' > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210705/c9cd7e29/attachment-0002.html> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool 2021-06-25 9:19 [Buildroot] [PATCH 1/1] package/uboot-tools: fix env image help text Mirza Kapetanovic 2021-06-27 10:44 ` Yann E. MORIN @ 2021-07-05 12:19 ` Mirza Kapetanovic 2021-07-06 11:55 ` [Buildroot] [External] " Weber, Matthew L Collins ` (2 more replies) 1 sibling, 3 replies; 8+ messages in thread From: Mirza Kapetanovic @ 2021-07-05 12:19 UTC (permalink / raw) To: buildroot Fix BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE so that files are actually concatenated as described in the help text. Signed-off-by: Mirza Kapetanovic <mirza.kapetanovic@gmail.com> --- package/uboot-tools/uboot-tools.mk | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk index 8963d6182e..4d1fc46e25 100644 --- a/package/uboot-tools/uboot-tools.mk +++ b/package/uboot-tools/uboot-tools.mk @@ -156,11 +156,12 @@ endif #BR_BUILDING define HOST_UBOOT_TOOLS_GENERATE_ENVIMAGE $(HOST_UBOOT_TOOLS_GENERATE_ENV_DEFAULTS) - $(@D)/tools/mkenvimage -s $(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SIZE) \ + cat $(UBOOT_TOOLS_GENERATE_ENV_FILE) | \ + $(@D)/tools/mkenvimage -s $(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SIZE) \ $(if $(BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_REDUNDANT),-r) \ $(if $(filter "BIG",$(BR2_ENDIAN)),-b) \ -o $(@D)/tools/uboot-env.bin \ - $(UBOOT_TOOLS_GENERATE_ENV_FILE) + - endef define HOST_UBOOT_TOOLS_INSTALL_ENVIMAGE $(INSTALL) -m 0755 -D $(@D)/tools/uboot-env.bin $(BINARIES_DIR)/uboot-env.bin -- 2.30.1 (Apple Git-130) ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [External] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool 2021-07-05 12:19 ` [Buildroot] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool Mirza Kapetanovic @ 2021-07-06 11:55 ` Weber, Matthew L Collins 2021-07-18 17:52 ` [Buildroot] " Thomas Petazzoni 2021-08-04 11:02 ` Peter Korsgaard 2 siblings, 0 replies; 8+ messages in thread From: Weber, Matthew L Collins @ 2021-07-06 11:55 UTC (permalink / raw) To: buildroot Hi Mirza, > From: Mirza Kapetanovic <mirza.kapetanovic@gmail.com> > Sent: Monday, July 5, 2021 7:19 AM > To: buildroot at buildroot.org <buildroot@buildroot.org> > Cc: Weber, Matthew L Collins <Matthew.Weber@collins.com>; Mirza Kapetanovic <mirza.kapetanovic@gmail.com> > Subject: [External] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool >? > Fix BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE so that files are actually concatenated > as described in the help text. Reviewed-by: Matthew Weber <matthew.weber@collins.com> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool 2021-07-05 12:19 ` [Buildroot] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool Mirza Kapetanovic 2021-07-06 11:55 ` [Buildroot] [External] " Weber, Matthew L Collins @ 2021-07-18 17:52 ` Thomas Petazzoni 2021-08-04 11:02 ` Peter Korsgaard 2 siblings, 0 replies; 8+ messages in thread From: Thomas Petazzoni @ 2021-07-18 17:52 UTC (permalink / raw) To: buildroot On Mon, 5 Jul 2021 14:19:33 +0200 Mirza Kapetanovic <mirza.kapetanovic@gmail.com> wrote: > Fix BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE so that files are actually concatenated > as described in the help text. > > Signed-off-by: Mirza Kapetanovic <mirza.kapetanovic@gmail.com> > --- > package/uboot-tools/uboot-tools.mk | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool 2021-07-05 12:19 ` [Buildroot] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool Mirza Kapetanovic 2021-07-06 11:55 ` [Buildroot] [External] " Weber, Matthew L Collins 2021-07-18 17:52 ` [Buildroot] " Thomas Petazzoni @ 2021-08-04 11:02 ` Peter Korsgaard 2 siblings, 0 replies; 8+ messages in thread From: Peter Korsgaard @ 2021-08-04 11:02 UTC (permalink / raw) To: Mirza Kapetanovic; +Cc: Matt Weber, buildroot >>>>> "Mirza" == Mirza Kapetanovic <mirza.kapetanovic@gmail.com> writes: > Fix BR2_PACKAGE_HOST_UBOOT_TOOLS_ENVIMAGE_SOURCE so that files are actually concatenated > as described in the help text. > Signed-off-by: Mirza Kapetanovic <mirza.kapetanovic@gmail.com> Committed to 2021.02.x and 2021.05.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-08-04 11:02 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-06-25 9:19 [Buildroot] [PATCH 1/1] package/uboot-tools: fix env image help text Mirza Kapetanovic 2021-06-27 10:44 ` Yann E. MORIN 2021-07-05 12:29 ` Mirza Kapetanovic 2021-07-05 12:29 ` Mirza Kapetanovic 2021-07-05 12:19 ` [Buildroot] [PATCH 1/1] package/uboot-tools: concat files before passing to env image tool Mirza Kapetanovic 2021-07-06 11:55 ` [Buildroot] [External] " Weber, Matthew L Collins 2021-07-18 17:52 ` [Buildroot] " Thomas Petazzoni 2021-08-04 11:02 ` Peter Korsgaard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox