Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] board/raspberrypi: use kernel Bluetooth mode
Date: Sun, 18 Jul 2021 00:22:42 +0200	[thread overview]
Message-ID: <20210718002242.4638b323@gmx.net> (raw)
In-Reply-To: <20210714145132.533559-1-john@metanate.com>

Hello John,

On Wed, 14 Jul 2021 15:51:32 +0100, John Keeping <john@metanate.com> wrote:

> The default setting with miniuart-bt requires hciattach which is a
> deprecated utility in BlueZ.  Setting the krnbt parameter switches to
> the modern method of using serdev in the kernel removing the need for
> any userspace configuration to enable the Bluetooth controller.
>
> This is documented as applying to all Raspberry Pi variants so just
> enable it globally.
>
> Signed-off-by: John Keeping <john@metanate.com>
> ---
>  board/raspberrypi/post-image.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/raspberrypi/post-image.sh b/board/raspberrypi/post-image.sh
> index 9dbd98ef9b..a6728c686e 100755
> --- a/board/raspberrypi/post-image.sh
> +++ b/board/raspberrypi/post-image.sh
> @@ -16,7 +16,7 @@ do
>  			cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
>
>  # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
> -dtoverlay=miniuart-bt
> +dtoverlay=miniuart-bt,krnbt=on
>  __EOF__
>  		fi
>  		;;

I fully understand the aim of your patch, but it is beyond the the minimal
approach of the defconfigs (minimal as as starting point for own
enhancements - startup and at minimum serial console access if possible,
so even not all rpi defconfigs provide the DTB overlays) or as strong hint
your enhancement would not match the comment line above the changed line...

But for an alternative config.txt file handling (with better/easier support
for cutomizations) see [1]...

Regards,
Peter

[1] https://patchwork.ozlabs.org/project/buildroot/patch/20210321114002.31000-1-ps.report at gmx.net/

  reply	other threads:[~2021-07-17 22:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 14:51 [Buildroot] [PATCH] board/raspberrypi: use kernel Bluetooth mode John Keeping
2021-07-17 22:22 ` Peter Seiderer [this message]
2021-07-19 11:26   ` John Keeping
2021-07-19 20:53     ` Yann E. MORIN
2021-07-20 11:19       ` John Keeping
2021-07-20 19:55 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210718002242.4638b323@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox