From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] board/raspberrypi: use kernel Bluetooth mode
Date: Tue, 20 Jul 2021 21:55:37 +0200 [thread overview]
Message-ID: <20210720215537.3f47b47e@windsurf> (raw)
In-Reply-To: <20210714145132.533559-1-john@metanate.com>
Hello,
On Wed, 14 Jul 2021 15:51:32 +0100
John Keeping <john@metanate.com> wrote:
> The default setting with miniuart-bt requires hciattach which is a
> deprecated utility in BlueZ. Setting the krnbt parameter switches to
> the modern method of using serdev in the kernel removing the need for
> any userspace configuration to enable the Bluetooth controller.
>
> This is documented as applying to all Raspberry Pi variants so just
> enable it globally.
>
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> board/raspberrypi/post-image.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Peter, Yann: I have read your reviews, and they both have good points.
However, I think John's patch keeps the state of a minimal defconfig,
it only makes it a bit easier to have operational Bluetooth. I
certainly don't mind seeing further improvements on how our RPi support
is done, but I believe John's patch was OK as-is as it improves the
situation for users, without any specific downside that I can think of.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2021-07-20 19:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 14:51 [Buildroot] [PATCH] board/raspberrypi: use kernel Bluetooth mode John Keeping
2021-07-17 22:22 ` Peter Seiderer
2021-07-19 11:26 ` John Keeping
2021-07-19 20:53 ` Yann E. MORIN
2021-07-20 11:19 ` John Keeping
2021-07-20 19:55 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720215537.3f47b47e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox