Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] package/mupdf: bump to version 1.18.0
Date: Tue, 20 Jul 2021 23:40:55 +0200	[thread overview]
Message-ID: <20210720234055.14967287@windsurf> (raw)
In-Reply-To: <20210630234717.21742-3-raphael.melotte@mind.be>

Hello Rapha?l,

On Thu,  1 Jul 2021 01:47:15 +0200
Rapha?l M?lotte <raphael.melotte@mind.be> wrote:

> diff --git a/package/mupdf/Config.in b/package/mupdf/Config.in
> index dc296b3e8a..f796965751 100644
> --- a/package/mupdf/Config.in
> +++ b/package/mupdf/Config.in
> @@ -10,6 +10,7 @@ config BR2_PACKAGE_MUPDF
>  	select BR2_PACKAGE_JPEG
>  	select BR2_PACKAGE_LCMS2
>  	select BR2_PACKAGE_OPENJPEG
> +	select BR2_PACKAGE_GUMBO_PARSER

I fixed the alphabetic ordering here.

> -# Modern versions of mupdf depend on OpenGL,
> -# we disable it because it may not be available:
> +ifneq ($(BR2_PACKAGE_FREEGLUT),y)

And here fixed the option name (it's BR2_PACKAGE_LIBFREEGLUT) and
switched to positive logic, i.e:

ifeq ($(BR2_PACKAGE_LIBFREEGLUT),y)
... do stuff if enabled
else
... do stuff if disabled
endif

Applied with those changes.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Raphaël Mélotte" <raphael.melotte@mind.be>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/4] package/mupdf: bump to version 1.18.0
Date: Tue, 20 Jul 2021 23:40:55 +0200	[thread overview]
Message-ID: <20210720234055.14967287@windsurf> (raw)
Message-ID: <20210720214055.i-6lgMZvvMoBl-HKOsCK087D_EZxLNvoJutkOR8ey6s@z> (raw)
In-Reply-To: <20210630234717.21742-3-raphael.melotte@mind.be>

Hello Raphaël,

On Thu,  1 Jul 2021 01:47:15 +0200
Raphaël Mélotte <raphael.melotte@mind.be> wrote:

> diff --git a/package/mupdf/Config.in b/package/mupdf/Config.in
> index dc296b3e8a..f796965751 100644
> --- a/package/mupdf/Config.in
> +++ b/package/mupdf/Config.in
> @@ -10,6 +10,7 @@ config BR2_PACKAGE_MUPDF
>  	select BR2_PACKAGE_JPEG
>  	select BR2_PACKAGE_LCMS2
>  	select BR2_PACKAGE_OPENJPEG
> +	select BR2_PACKAGE_GUMBO_PARSER

I fixed the alphabetic ordering here.

> -# Modern versions of mupdf depend on OpenGL,
> -# we disable it because it may not be available:
> +ifneq ($(BR2_PACKAGE_FREEGLUT),y)

And here fixed the option name (it's BR2_PACKAGE_LIBFREEGLUT) and
switched to positive logic, i.e:

ifeq ($(BR2_PACKAGE_LIBFREEGLUT),y)
... do stuff if enabled
else
... do stuff if disabled
endif

Applied with those changes.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-07-20 21:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 23:47 [Buildroot] [PATCH 1/4] DEVELOPERS: update email address for Raphaël Mélotte Raphaël Mélotte
2021-06-30 23:47 ` [Buildroot] [PATCH 2/4] package/gumbo-parser: new package Raphaël Mélotte
2021-07-20 21:39   ` Thomas Petazzoni
2021-07-20 21:39     ` Thomas Petazzoni
2021-06-30 23:47 ` [Buildroot] [PATCH 3/4] package/mupdf: bump to version 1.18.0 Raphaël Mélotte
2021-07-20 21:40   ` Thomas Petazzoni [this message]
2021-07-20 21:40     ` Thomas Petazzoni
2021-06-30 23:47 ` [Buildroot] [PATCH 4/4] package/python-pymupdf: bump to version 1.18.14 Raphaël Mélotte
2021-07-20 21:40   ` Thomas Petazzoni
2021-07-20 21:40     ` Thomas Petazzoni
2021-07-20 21:38 ` [Buildroot] [PATCH 1/4] DEVELOPERS: update email address for Raphaël Mélotte Thomas Petazzoni
2021-07-20 21:38   ` Thomas Petazzoni
2021-08-04 14:36 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210720234055.14967287@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox