From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/5] package/nginx-naxsi: bump version to 1.3
Date: Wed, 21 Jul 2021 00:00:26 +0200 [thread overview]
Message-ID: <20210721000026.010fd8e1@windsurf> (raw)
In-Reply-To: <20210630173700.30975-4-aduskett@gmail.com>
Hello Adam,
+Yann in Cc.
On Wed, 30 Jun 2021 10:36:58 -0700
Adam Duskett <aduskett@gmail.com> wrote:
> -NGINX_NAXSI_VERSION = 0.56
> +NGINX_NAXSI_VERSION = 1.3
> NGINX_NAXSI_SITE = $(call github,nbs-system,naxsi,$(NGINX_NAXSI_VERSION))
> -NGINX_NAXSI_LICENSE = GPL-2.0+ with OpenSSL exception
> -NGINX_NAXSI_LICENSE_FILES = naxsi_src/naxsi_json.c
> +NGINX_NAXSI_LICENSE = GPL-3.0 BSD-3c
This was not quite correct: it should be comma-separated, and the SPDX
identifier for BSD-3c is BSD-3-Clause. So I changed this line to:
NGINX_NAXSI_LICENSE = GPL-3.0, BSD-3-Clause (libinjection)
> +NGINX_NAXSI_LICENSE_FILES = LICENSE naxsi_src/ext/libinjection/COPYING
> +NGINX_NAXSI_DEPENDENCIES = pcre
And also I think this new pcre dependency is not really correct. Yes,
the Config.in files selects BR2_PACKAGE_PCRE, but it doesn't mean
nginx-naxsi has a build dependency on pcre. In fact, nginx-naxsi
doesn't build anything, it only downloads code, and it's really nginx
that builds these external modules.
This was already discussed in 2016 when Samuel Martin added the
BR2_PACKAGE_PCRE select. See:
http://lists.busybox.net/pipermail/buildroot/2016-September/172028.html
http://lists.busybox.net/pipermail/buildroot/2016-September/172171.html
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Adam Duskett <aduskett@gmail.com>
Cc: Frank Vanbever <frank.vanbever@essensium.com>,
Samuel Martin <s.martin49@gmail.com>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
Johan Oudinet <johan.oudinet@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/5] package/nginx-naxsi: bump version to 1.3
Date: Wed, 21 Jul 2021 00:00:26 +0200 [thread overview]
Message-ID: <20210721000026.010fd8e1@windsurf> (raw)
Message-ID: <20210720220026.svscB0dm9I-xnyPP9lr37cW_64Azp8Z4RNSOX3OBUwQ@z> (raw)
In-Reply-To: <20210630173700.30975-4-aduskett@gmail.com>
Hello Adam,
+Yann in Cc.
On Wed, 30 Jun 2021 10:36:58 -0700
Adam Duskett <aduskett@gmail.com> wrote:
> -NGINX_NAXSI_VERSION = 0.56
> +NGINX_NAXSI_VERSION = 1.3
> NGINX_NAXSI_SITE = $(call github,nbs-system,naxsi,$(NGINX_NAXSI_VERSION))
> -NGINX_NAXSI_LICENSE = GPL-2.0+ with OpenSSL exception
> -NGINX_NAXSI_LICENSE_FILES = naxsi_src/naxsi_json.c
> +NGINX_NAXSI_LICENSE = GPL-3.0 BSD-3c
This was not quite correct: it should be comma-separated, and the SPDX
identifier for BSD-3c is BSD-3-Clause. So I changed this line to:
NGINX_NAXSI_LICENSE = GPL-3.0, BSD-3-Clause (libinjection)
> +NGINX_NAXSI_LICENSE_FILES = LICENSE naxsi_src/ext/libinjection/COPYING
> +NGINX_NAXSI_DEPENDENCIES = pcre
And also I think this new pcre dependency is not really correct. Yes,
the Config.in files selects BR2_PACKAGE_PCRE, but it doesn't mean
nginx-naxsi has a build dependency on pcre. In fact, nginx-naxsi
doesn't build anything, it only downloads code, and it's really nginx
that builds these external modules.
This was already discussed in 2016 when Samuel Martin added the
BR2_PACKAGE_PCRE select. See:
http://lists.busybox.net/pipermail/buildroot/2016-September/172028.html
http://lists.busybox.net/pipermail/buildroot/2016-September/172171.html
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-07-20 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 17:36 [Buildroot] [PATCH v2 0/5] nginx updates Adam Duskett
2021-06-30 17:36 ` [Buildroot] [PATCH v2 1/5] package/nginx: bump version to 1.20.1 Adam Duskett
2021-06-30 17:36 ` [Buildroot] [PATCH v2 2/5] package/nginx: add stream_set_module support Adam Duskett
2021-06-30 17:36 ` [Buildroot] [PATCH v2 3/5] package/nginx-naxsi: bump version to 1.3 Adam Duskett
2021-07-20 22:00 ` Thomas Petazzoni [this message]
2021-07-20 22:00 ` Thomas Petazzoni
2021-06-30 17:36 ` [Buildroot] [PATCH v2 4/5] package/nginx-dav-ext: bump version to 3.0.0 Adam Duskett
2021-06-30 17:37 ` [Buildroot] [PATCH v2 5/5] package/nginx-modsecurity: bump to version 1.0.2 Adam Duskett
2021-07-20 21:57 ` [Buildroot] [PATCH v2 0/5] nginx updates Thomas Petazzoni
2021-07-20 21:57 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721000026.010fd8e1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox