Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v3] package/libtomcrypt: use makefile.unix (gains pkgconfig support)
@ 2021-05-06 20:52 Peter Seiderer
  2021-07-28 22:13 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Seiderer @ 2021-05-06 20:52 UTC (permalink / raw)
  To: buildroot

Change from makefile to makefile.unix:
  - gains pkgconfig support (libtomcrypt.pc will be installed)
  - remove NODOCS (legacy, not used anymore)
  - remove INSTALL_USER/INSTALL_GROUP (not needed for makefile.unix)

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v2 -> v3:
  - change from custom libtomcrypt.pc install/sed to makefile.unix
    (suggested by Arnout Vandecappelle)
  - no need for GIT_VERSION define (only used by - not compiled - tests)

Changes v1 -> v2:
  - use libtomcrypt provided libtomcrypt.pc.in template file
---
 package/libtomcrypt/libtomcrypt.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/package/libtomcrypt/libtomcrypt.mk b/package/libtomcrypt/libtomcrypt.mk
index 35886057d4..fa2a585047 100644
--- a/package/libtomcrypt/libtomcrypt.mk
+++ b/package/libtomcrypt/libtomcrypt.mk
@@ -24,13 +24,12 @@ LIBTOMCRYPT_CFLAGS += -fPIC
 endif
 
 define LIBTOMCRYPT_BUILD_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(LIBTOMCRYPT_CFLAGS)"
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) -f makefile.unix $(TARGET_CONFIGURE_OPTS) CFLAGS="$(LIBTOMCRYPT_CFLAGS)"
 endef
 
 define LIBTOMCRYPT_INSTALL_STAGING_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) DESTDIR="$(STAGING_DIR)" \
-		PREFIX=/usr NODOCS=1 INSTALL_USER=$(shell id -u) \
-		INSTALL_GROUP=$(shell id -g) install
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) -f makefile.unix \
+		DESTDIR="$(STAGING_DIR)" PREFIX=/usr install
 endef
 
 $(eval $(generic-package))
-- 
2.31.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH v3] package/libtomcrypt: use makefile.unix (gains pkgconfig support)
  2021-05-06 20:52 [Buildroot] [PATCH v3] package/libtomcrypt: use makefile.unix (gains pkgconfig support) Peter Seiderer
@ 2021-07-28 22:13 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2021-07-28 22:13 UTC (permalink / raw)
  To: Peter Seiderer; +Cc: buildroot

On Thu,  6 May 2021 22:52:29 +0200
Peter Seiderer <ps.report@gmx.net> wrote:

> Change from makefile to makefile.unix:
>   - gains pkgconfig support (libtomcrypt.pc will be installed)
>   - remove NODOCS (legacy, not used anymore)
>   - remove INSTALL_USER/INSTALL_GROUP (not needed for makefile.unix)
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v2 -> v3:
>   - change from custom libtomcrypt.pc install/sed to makefile.unix
>     (suggested by Arnout Vandecappelle)
>   - no need for GIT_VERSION define (only used by - not compiled - tests)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-28 22:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-06 20:52 [Buildroot] [PATCH v3] package/libtomcrypt: use makefile.unix (gains pkgconfig support) Peter Seiderer
2021-07-28 22:13 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox