[Buildroot] [PATCH 1/1] package/gtest: needs gcc >= 4.9

[Buildroot] [PATCH 1/1] package/gtest: needs gcc >= 4.9

[Fabrice Fontaine]

gtest unconditionally uses is_trivially_copy_constructible since
version 1.11.0 and
https://github.com/google/googletest/commit/c13c27a513ecd1cbf5700a45fe590e85e8ae6770

So add a dependency on gcc >= 4.9 to avoid a build failure since commit
9dfbbbb4105c47602da048c9bb9499fb8862e768

Fixes:
 - http://autobuild.buildroot.org/results/3d23d7c2c340c23e468890e4df73a9b3b142ecf6

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/gtest/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/gtest/Config.in b/package/gtest/Config.in
index 3f1f38556f..d8bcf6343f 100644
--- a/package/gtest/Config.in
+++ b/package/gtest/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_GTEST
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11
 	depends on BR2_USE_MMU # fork()
 	help
 	  Google's framework for writing C++ tests on a variety of
@@ -48,7 +49,8 @@ config BR2_PACKAGE_GTEST_GMOCK
 
 endif # BR2_PACKAGE_GTEST
 
-comment "gtest needs a toolchain w/ C++, wchar, threads"
+comment "gtest needs a toolchain w/ C++, wchar, threads, gcc >= 4.9"
 	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_INSTALL_LIBSTDCPP
+		!BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/gtest: needs gcc >= 4.9

[Thomas Petazzoni]

On Sat, 31 Jul 2021 22:05:55 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> gtest unconditionally uses is_trivially_copy_constructible since
> version 1.11.0 and
> https://github.com/google/googletest/commit/c13c27a513ecd1cbf5700a45fe590e85e8ae6770
> 
> So add a dependency on gcc >= 4.9 to avoid a build failure since commit
> 9dfbbbb4105c47602da048c9bb9499fb8862e768
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/3d23d7c2c340c23e468890e4df73a9b3b142ecf6
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/gtest/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot