Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/gtest: drop unrecognized option
@ 2021-07-31 20:11 Fabrice Fontaine
  2021-07-31 22:07 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2021-07-31 20:11 UTC (permalink / raw)
  To: buildroot; +Cc: Michael Nosthoff, Stephan Hoffmann, Fabrice Fontaine

BUILD_GTEST has been dropped from gtest since version 1.8.1 and
https://github.com/google/googletest/commit/aff0379441a392d618ec87b6d55a29070e97eaf1

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/gtest/gtest.mk | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/gtest/gtest.mk b/package/gtest/gtest.mk
index 29c85e698f..474d127312 100644
--- a/package/gtest/gtest.mk
+++ b/package/gtest/gtest.mk
@@ -44,8 +44,6 @@ ifeq ($(BR2_STATIC_LIBS),)
 GTEST_CONF_OPTS += -DCMAKE_POSITION_INDEPENDENT_CODE=ON
 endif
 
-GTEST_CONF_OPTS += -DBUILD_GTEST=ON
-
 ifeq ($(BR2_PACKAGE_GTEST_GMOCK),y)
 GTEST_CONF_OPTS += -DBUILD_GMOCK=ON
 else
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/gtest: drop unrecognized option
  2021-07-31 20:11 [Buildroot] [PATCH 1/1] package/gtest: drop unrecognized option Fabrice Fontaine
@ 2021-07-31 22:07 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2021-07-31 22:07 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Michael Nosthoff, Stephan Hoffmann, buildroot

On Sat, 31 Jul 2021 22:11:37 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> BUILD_GTEST has been dropped from gtest since version 1.8.1 and
> https://github.com/google/googletest/commit/aff0379441a392d618ec87b6d55a29070e97eaf1
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/gtest/gtest.mk | 2 --
>  1 file changed, 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-31 22:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-31 20:11 [Buildroot] [PATCH 1/1] package/gtest: drop unrecognized option Fabrice Fontaine
2021-07-31 22:07 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox