[Buildroot] [PATCH 1/1] package/cegui: needs gcc >= 5

[Buildroot] [PATCH 1/1] package/cegui: needs gcc >= 5

[Fabrice Fontaine]

cegui needs gcc >= 5 since bump to current master in commit
352a8b3fe8b1d78073b1119369f10688e00bc859 and
https://github.com/cegui/cegui/commit/17f7f6156eb0ba903d5ae926e372b8c5c26d8c68
or the build will fail on:

/home/buildroot/autobuild/instance-1/output-1/build/cegui-00b4e1fe174da53b7ed726ab5970ba51bd5b5ee0/cegui/src/widgets/Spinner.cpp: In member function 'virtual CEGUI::String CEGUI::Spinner::getTextFromValue() const':
/home/buildroot/autobuild/instance-1/output-1/build/cegui-00b4e1fe174da53b7ed726ab5970ba51bd5b5ee0/cegui/src/widgets/Spinner.cpp:310:116: error: 'defaultfloat' is not a member of 'std'
             tmp << std::fixed << std::setprecision(d_precision) << d_currentValue << std::setprecision(defPrec) << std::defaultfloat;
                                                                                                                    ^

defaultfloat is not available before gcc 5 and
https://github.com/gcc-mirror/gcc/commit/c4b64f5bcac6f7d5e1ae7d3026a3e228fb8adbbd

Fixes:
 - http://autobuild.buildroot.org/results/006ce109980a76870d2347e53307082b36d9904a

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/cegui/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/cegui/Config.in b/package/cegui/Config.in
index 1bd0ee1cc3..20b865835b 100644
--- a/package/cegui/Config.in
+++ b/package/cegui/Config.in
@@ -1,11 +1,13 @@
-comment "cegui needs a toolchain w/ C++, threads, dynamic library, wchar"
+comment "cegui needs a toolchain w/ C++, threads, dynamic library, wchar, gcc >= 5"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP \
-			|| BR2_STATIC_LIBS || !BR2_USE_WCHAR
+			|| BR2_STATIC_LIBS || !BR2_USE_WCHAR \
+			|| !BR2_TOOLCHAIN_GCC_AT_LEAST_5
 
 config BR2_PACKAGE_CEGUI
 	bool "cegui"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_STATIC_LIBS
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++11 PR59987
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_WCHAR
 	select BR2_PACKAGE_GLM
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/cegui: needs gcc >= 5

[Thomas Petazzoni]

On Sun,  1 Aug 2021 10:29:19 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> cegui needs gcc >= 5 since bump to current master in commit
> 352a8b3fe8b1d78073b1119369f10688e00bc859 and
> https://github.com/cegui/cegui/commit/17f7f6156eb0ba903d5ae926e372b8c5c26d8c68
> or the build will fail on:
> 
> /home/buildroot/autobuild/instance-1/output-1/build/cegui-00b4e1fe174da53b7ed726ab5970ba51bd5b5ee0/cegui/src/widgets/Spinner.cpp: In member function 'virtual CEGUI::String CEGUI::Spinner::getTextFromValue() const':
> /home/buildroot/autobuild/instance-1/output-1/build/cegui-00b4e1fe174da53b7ed726ab5970ba51bd5b5ee0/cegui/src/widgets/Spinner.cpp:310:116: error: 'defaultfloat' is not a member of 'std'
>              tmp << std::fixed << std::setprecision(d_precision) << d_currentValue << std::setprecision(defPrec) << std::defaultfloat;
>                                                                                                                     ^
> 
> defaultfloat is not available before gcc 5 and
> https://github.com/gcc-mirror/gcc/commit/c4b64f5bcac6f7d5e1ae7d3026a3e228fb8adbbd
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/006ce109980a76870d2347e53307082b36d9904a
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/cegui/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot