Re: [Buildroot] [PATCH 1/1] package/nfs-utils: Backport yet another printf fix

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

On Tue, 3 Aug 2021 00:06:46 +0200
Petr Vorel <petr.vorel@gmail.com> wrote:

> I believe all 3 patches (2 already merged + this one) should fix the problem.
> But I was not able to verify it, because ./utils/test-pkg didn't catch even
> this error (I tested all available toolchains), IMHO -Werror=format=2 and other
> -Werror are probably only on http://autobuild.buildroot.net/ (not in Buildroot
> config for users). It'd be great if ./utils/test-pkg had the same CFLAGS.
> Or have I (again) overlooked something?

No, the autobuilders don't do anything specific with -Werror CFLAGS.
The configurations tested by the autobuilders are generated by
utils/genrandconfig in the Buildroot tree. Besides the obvious package
randomization, there is some randomization of "global" options:

    # Per-package folder
    if randint(0, 15) == 0:
        configlines.append("BR2_PER_PACKAGE_DIRECTORIES=y\n")

    # Amend the configuration with a few things.
    if randint(0, 20) == 0:
        configlines.append("BR2_ENABLE_DEBUG=y\n")
    if randint(0, 20) == 0:
        configlines.append("BR2_ENABLE_RUNTIME_DEBUG=y\n")
    if randint(0, 1) == 0:
        configlines.append("BR2_INIT_BUSYBOX=y\n")
    elif randint(0, 15) == 0:
        configlines.append("BR2_INIT_SYSTEMD=y\n")
    elif randint(0, 10) == 0:
        configlines.append("BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y\n")
    if randint(0, 20) == 0:
        configlines.append("BR2_STATIC_LIBS=y\n")
    if randint(0, 20) == 0:
        configlines.append("BR2_PACKAGE_PYTHON_PY_ONLY=y\n")
    if randint(0, 5) == 0:
        configlines.append("BR2_OPTIMIZE_2=y\n")
    if randint(0, 4) == 0:
        configlines.append("BR2_SYSTEM_ENABLE_NLS=y\n")
    if randint(0, 4) == 0:
        configlines.append("BR2_FORTIFY_SOURCE_2=y\n")

For example, did you test with BR2_FORTIFY_SOURCE_2=y ?

Could you point me to the autobuilder failure that you had, but was not
able to reproduce with test-pkg ? We should be able to point out the
difference.

The thing is that test-pkg cannot test all possibilities, it would take
way too much time.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot