From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Peter Seiderer <ps.report@gmx.net>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>,
Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC v1] package/rpi-userland: add GLint64, GLuint64 and GLsync typedefs to GLES2/gl2ext.h
Date: Fri, 6 Aug 2021 00:07:50 +0200 [thread overview]
Message-ID: <20210806000750.0bc826da@windsurf> (raw)
In-Reply-To: <20210510195352.13205-1-ps.report@gmx.net>
Hello,
On Mon, 10 May 2021 21:53:52 +0200
Peter Seiderer <ps.report@gmx.net> wrote:
> + interface/khronos/include/GLES2/gl2ext.h | 13 +++++++++++++
> + 1 file changed, 13 insertions(+)
Are you sure gl2ext.h is the right place to add those typedefs ? In the
mesa3d-headers package (which kind of is our reference for OpenGL
Khronos headers), these typedefs are in GLES2/gl2.h.
Another question is: why is GStreamer defining:
39 #if !GST_GL_HAVE_GLSYNC
40 typedef gpointer GLsync;
41 #endif
Isn't that a mistake from the GStreamer code base ?
Did you report this issue to rpi-userland upstream to see what they think ?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-05 22:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 19:53 [Buildroot] [RFC v1] package/rpi-userland: add GLint64, GLuint64 and GLsync typedefs to GLES2/gl2ext.h Peter Seiderer
2021-08-05 22:07 ` Thomas Petazzoni [this message]
2022-07-24 13:21 ` Romain Naour
2022-07-25 13:00 ` Thomas Petazzoni via buildroot
2022-08-17 10:44 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806000750.0bc826da@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=mahyar.koshkouei@gmail.com \
--cc=maxime.hadjinlian@gmail.com \
--cc=ps.report@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox