From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Peter Seiderer <ps.report@gmx.net>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>,
Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC v1] package/rpi-userland: add GLint64, GLuint64 and GLsync typedefs to GLES2/gl2ext.h
Date: Mon, 25 Jul 2022 15:00:25 +0200 [thread overview]
Message-ID: <20220725150025.12ee53e7@windsurf> (raw)
In-Reply-To: <20210510195352.13205-1-ps.report@gmx.net>
Hello Peter,
On Mon, 10 May 2021 21:53:52 +0200
Peter Seiderer <ps.report@gmx.net> wrote:
> The problem is that gstreamer sees the original gl2ext.h file from
> rpi-userland (rpi-userland-093b30bbc2fd083d68cc3ee07e6e555c6e592d11/interface/khronos/include/GLES2/gl2ext.h)
> without the additional GLint64, GLuint64 and GLsync typedef definitions but
> checks for existance and if not found enables its own versions in gstgl_compat.h,
> incompatible with the later ones used from Qt (qopengles2ext.h).
>
> Fix this by adding the same typedef definitions already to the
> rpi-userland header version.
Romain and I finally had a look at this. I was a bit confused by your
explanation, so after doing our investigation, I rewrote it this way:
The problem is that rpi-userland doesn't define GLsync, and both
GStreamer and Qt have their own definition of GLsync in this case, but
they are not the same.
We reported this issue to:
* rpi-userland, to get the headers updated:
https://github.com/raspberrypi/userland/issues/469#issuecomment-1193864294
* gstreamer, to get their bogus definition of GLsync fixed:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/973
In the mean time, fix this by adding the missing definitions to
rpi-userland, so that GStreamer and Qt don't try to provide their own.
As you can see, I also reported the issue back to rpi-userland (more
precisely pinged in an existing issue) and to GStreamer.
But for now, what you proposed is the most immediate fix, so I've
applied your patch to master with an updated commit log and patch
description.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-25 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 19:53 [Buildroot] [RFC v1] package/rpi-userland: add GLint64, GLuint64 and GLsync typedefs to GLES2/gl2ext.h Peter Seiderer
2021-08-05 22:07 ` Thomas Petazzoni
2022-07-24 13:21 ` Romain Naour
2022-07-25 13:00 ` Thomas Petazzoni via buildroot [this message]
2022-08-17 10:44 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725150025.12ee53e7@windsurf \
--to=buildroot@buildroot.org \
--cc=mahyar.koshkouei@gmail.com \
--cc=maxime.hadjinlian@gmail.com \
--cc=ps.report@gmx.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox