From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/kodi: add comment that OpenGLES support also needs udev
Date: Sun, 8 Aug 2021 22:35:24 +0200 [thread overview]
Message-ID: <20210808223524.615419a7@windsurf> (raw)
In-Reply-To: <20210807102106.714972-1-bernd.kuhls@t-online.de>
Hello Bernd,
On Sat, 7 Aug 2021 12:21:06 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> For reference:
> https://git.buildroot.net/buildroot/tree/package/kodi/Config.in#n26
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/kodi/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/kodi/Config.in b/package/kodi/Config.in
> index 074a457d1b..bbdef8aefe 100644
> --- a/package/kodi/Config.in
> +++ b/package/kodi/Config.in
> @@ -49,7 +49,7 @@ config BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11
> select BR2_PACKAGE_KODI_PLATFORM_SUPPORTS
> select BR2_PACKAGE_XLIB_LIBXRANDR
>
> -comment "kodi needs an OpenGL EGL backend with OpenGL or GLES support"
> +comment "kodi needs an OpenGL EGL backend with OpenGL or GLES/udev support"
> depends on !BR2_PACKAGE_KODI_PLATFORM_SUPPORTS
I don't really understand the justification here.
BR2_PACKAGE_KODI_PLATFORM_SUPPORTS gets selected by
BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM or
BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_WAYLAND or
BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11. While
BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM requires udev, the other two not
necessarily.
But in fact the existing comment is already incorrect. Kodi requires
either:
(OpenGL || OpenGLES) && gbm && udev => to use BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM
OR
(OpenGL || OpenGLES) && wayland && libegl-wayland => to use BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_WAYLAND
OR
(OpenGL || OpenGLES) && X.org => to use BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11
So I guess the reason for the existing comment is that the (OpenGL ||
OpenGLES) dependency is common to all 3 cases.
So unfortunately, just adding this "/udev" doesn't make much sense I
believe :-/
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-08 20:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 10:21 [Buildroot] [PATCH 1/1] package/kodi: add comment that OpenGLES support also needs udev Bernd Kuhls
2021-08-08 20:35 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210808223524.615419a7@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox