[Buildroot] [PATCH 1/1] package/kodi: add comment that OpenGLES support also needs udev

[Buildroot] [PATCH 1/1] package/kodi: add comment that OpenGLES support also needs udev

[Bernd Kuhls]

For reference:
https://git.buildroot.net/buildroot/tree/package/kodi/Config.in#n26

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index 074a457d1b..bbdef8aefe 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -49,7 +49,7 @@ config BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11
 	select BR2_PACKAGE_KODI_PLATFORM_SUPPORTS
 	select BR2_PACKAGE_XLIB_LIBXRANDR
 
-comment "kodi needs an OpenGL EGL backend with OpenGL or GLES support"
+comment "kodi needs an OpenGL EGL backend with OpenGL or GLES/udev support"
 	depends on !BR2_PACKAGE_KODI_PLATFORM_SUPPORTS
 
 menuconfig BR2_PACKAGE_KODI
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/kodi: add comment that OpenGLES support also needs udev

[Thomas Petazzoni]

Hello Bernd,

On Sat,  7 Aug 2021 12:21:06 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> For reference:
> https://git.buildroot.net/buildroot/tree/package/kodi/Config.in#n26
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/kodi/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/kodi/Config.in b/package/kodi/Config.in
> index 074a457d1b..bbdef8aefe 100644
> --- a/package/kodi/Config.in
> +++ b/package/kodi/Config.in
> @@ -49,7 +49,7 @@ config BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11
>  	select BR2_PACKAGE_KODI_PLATFORM_SUPPORTS
>  	select BR2_PACKAGE_XLIB_LIBXRANDR
>  
> -comment "kodi needs an OpenGL EGL backend with OpenGL or GLES support"
> +comment "kodi needs an OpenGL EGL backend with OpenGL or GLES/udev support"
>  	depends on !BR2_PACKAGE_KODI_PLATFORM_SUPPORTS

I don't really understand the justification here.
BR2_PACKAGE_KODI_PLATFORM_SUPPORTS gets selected by
BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM or
BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_WAYLAND or
BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11. While
BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM requires udev, the other two not
necessarily.

But in fact the existing comment is already incorrect. Kodi requires
either:

 (OpenGL || OpenGLES) && gbm && udev => to use BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM

OR

 (OpenGL || OpenGLES) && wayland && libegl-wayland => to use BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_WAYLAND

OR

 (OpenGL || OpenGLES) && X.org => to use BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11

So I guess the reason for the existing comment is that the (OpenGL ||
OpenGLES) dependency is common to all 3 cases.

So unfortunately, just adding this "/udev" doesn't make much sense I
believe :-/

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot