[Buildroot] [PATCH 1/1] package/mpv: vaapi-drm needs egl-drm

[Buildroot] [PATCH 1/1] package/mpv: vaapi-drm needs egl-drm

[Fabrice Fontaine]

Build of vaapi-drm without egl-drm is broken since commit
6ec47c4e59c7c8c57e972dab985c8a2ba0bf7174:
https://github.com/mpv-player/mpv/blob/ec0006bfa1aaf608a7141929f2871c89ac7a15d6/wscript#L647

Fixes:
 - http://autobuild.buildroot.org/results/83d6dcbb77ab8754aefcdcf90baeaff9db2a1c81

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/mpv/mpv.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/mpv/mpv.mk b/package/mpv/mpv.mk
index d4d4d4811d..91e31dd150 100644
--- a/package/mpv/mpv.mk
+++ b/package/mpv/mpv.mk
@@ -181,7 +181,7 @@ endif
 ifeq ($(BR2_PACKAGE_LIBVA)$(BR2_PACKAGE_MPV_SUPPORTS_VAAPI),yy)
 MPV_CONF_OPTS += --enable-vaapi
 MPV_DEPENDENCIES += libva
-ifeq ($(BR2_PACKAGE_LIBDRM),y)
+ifeq ($(BR2_PACKAGE_LIBDRM)$(BR2_PACKAGE_MESA3D_OPENGL_EGL),yy)
 MPV_CONF_OPTS += --enable-vaapi-drm
 else
 MPV_CONF_OPTS += --disable-vaapi-drm
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/mpv: vaapi-drm needs egl-drm

[Thomas Petazzoni]

On Thu, 19 Aug 2021 18:03:17 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Build of vaapi-drm without egl-drm is broken since commit
> 6ec47c4e59c7c8c57e972dab985c8a2ba0bf7174:
> https://github.com/mpv-player/mpv/blob/ec0006bfa1aaf608a7141929f2871c89ac7a15d6/wscript#L647
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/83d6dcbb77ab8754aefcdcf90baeaff9db2a1c81
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/mpv/mpv.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/mpv/mpv.mk b/package/mpv/mpv.mk
> index d4d4d4811d..91e31dd150 100644
> --- a/package/mpv/mpv.mk
> +++ b/package/mpv/mpv.mk
> @@ -181,7 +181,7 @@ endif
>  ifeq ($(BR2_PACKAGE_LIBVA)$(BR2_PACKAGE_MPV_SUPPORTS_VAAPI),yy)
>  MPV_CONF_OPTS += --enable-vaapi
>  MPV_DEPENDENCIES += libva
> -ifeq ($(BR2_PACKAGE_LIBDRM),y)
> +ifeq ($(BR2_PACKAGE_LIBDRM)$(BR2_PACKAGE_MESA3D_OPENGL_EGL),yy)
>  MPV_CONF_OPTS += --enable-vaapi-drm

Do we can only use Mesa3D as an EGL provider ?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/mpv: vaapi-drm needs egl-drm

[Fabrice Fontaine]

Le jeu. 19 août 2021 à 22:32, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> On Thu, 19 Aug 2021 18:03:17 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Build of vaapi-drm without egl-drm is broken since commit
> > 6ec47c4e59c7c8c57e972dab985c8a2ba0bf7174:
> > https://github.com/mpv-player/mpv/blob/ec0006bfa1aaf608a7141929f2871c89ac7a15d6/wscript#L647
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/83d6dcbb77ab8754aefcdcf90baeaff9db2a1c81
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/mpv/mpv.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/mpv/mpv.mk b/package/mpv/mpv.mk
> > index d4d4d4811d..91e31dd150 100644
> > --- a/package/mpv/mpv.mk
> > +++ b/package/mpv/mpv.mk
> > @@ -181,7 +181,7 @@ endif
> >  ifeq ($(BR2_PACKAGE_LIBVA)$(BR2_PACKAGE_MPV_SUPPORTS_VAAPI),yy)
> >  MPV_CONF_OPTS += --enable-vaapi
> >  MPV_DEPENDENCIES += libva
> > -ifeq ($(BR2_PACKAGE_LIBDRM),y)
> > +ifeq ($(BR2_PACKAGE_LIBDRM)$(BR2_PACKAGE_MESA3D_OPENGL_EGL),yy)
> >  MPV_CONF_OPTS += --enable-vaapi-drm
>
> Do we can only use Mesa3D as an EGL provider ?
From my understanding, vaapi-drm needs egl-drm which has been added
with commit 031df474c24f92757ac95ade572b90995ebdc6a2 and is only
available with mesa3d because of gbm dependency:
https://github.com/mpv-player/mpv/blob/0b56e1c00a57fdb767674462c299a5c973a9e373/wscript#L571
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/mpv: vaapi-drm needs egl-drm

[Thomas Petazzoni]

On Thu, 19 Aug 2021 22:40:16 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> > Do we can only use Mesa3D as an EGL provider ?  
> From my understanding, vaapi-drm needs egl-drm which has been added
> with commit 031df474c24f92757ac95ade572b90995ebdc6a2 and is only
> available with mesa3d because of gbm dependency:
> https://github.com/mpv-player/mpv/blob/0b56e1c00a57fdb767674462c299a5c973a9e373/wscript#L571

OK, so it's related to the fact that for now, only Mesa3D is recognized
as a proper gbm provider.

So I think your proposed patch is OK: this is a limitation that we
know. I know internally at Bootlin we do have a patch series (probably
it was submitted once) to improve the Buildroot handling of gbm. I'll
poke internally to get it posted.

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot