From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Joachim Wiberg <troglobit@gmail.com>
Cc: Matt Weber <matthew.weber@collins.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/smcroute: bump version to v2.5.0
Date: Fri, 20 Aug 2021 23:32:26 +0200 [thread overview]
Message-ID: <20210820233226.677ff169@windsurf> (raw)
In-Reply-To: <20210820054419.439633-1-troglobit@gmail.com>
Hello Joachim,
On Fri, 20 Aug 2021 07:44:19 +0200
Joachim Wiberg <troglobit@gmail.com> wrote:
> diff --git a/package/smcroute/smcroute.hash b/package/smcroute/smcroute.hash
> index f79ce167ed..01d5eafd59 100644
> --- a/package/smcroute/smcroute.hash
> +++ b/package/smcroute/smcroute.hash
> @@ -1,5 +1,5 @@
> # Locally generated
> -sha256 431be94c46646767f69c85fee445277b7e765a55177d3ee29522416cfe2cc067 smcroute-2.4.4.tar.xz
> +sha256 fa0a496ee4258c286814b789e1dc4d0be2cc4788adba23e8484ff5d0a65f6cc5 smcroute-2.5.0.tar.gz
> sha256 ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6 COPYING
> -# From https://github.com/troglobit/smcroute/releases/download/2.4.4/smcroute-2.4.4.tar.xz.md5
> -md5 a1dc8c54c684e8c8de139444f73a0ba3 smcroute-2.4.4.tar.xz
> +# From https://github.com/troglobit/smcroute/releases/download/2.5.0/smcroute-2.5.0.tar.gz.md5
> +md5 285a2765a4366e7d5ba07139a9f56bd5 smcroute-2.5.0.tar.gz
> diff --git a/package/smcroute/smcroute.mk b/package/smcroute/smcroute.mk
> index 0db0e084f6..16197e6f68 100644
> --- a/package/smcroute/smcroute.mk
> +++ b/package/smcroute/smcroute.mk
> @@ -4,16 +4,13 @@
> #
> ################################################################################
>
> -SMCROUTE_VERSION = 2.4.4
> -SMCROUTE_SOURCE = smcroute-$(SMCROUTE_VERSION).tar.xz
> +SMCROUTE_VERSION = 2.5.0
> SMCROUTE_SITE = https://github.com/troglobit/smcroute/releases/download/$(SMCROUTE_VERSION)
> SMCROUTE_LICENSE = GPL-2.0+
> SMCROUTE_LICENSE_FILES = COPYING
> SMCROUTE_CPE_ID_VENDOR = troglobit
>
> -SMCROUTE_CONF_OPTS = ac_cv_func_setpgrp_void=yes
> -#BUG:The package Makefile uses CC?= even though the package is autotools based
> -SMCROUTE_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
> +SMCROUTE_CONF_OPTS = --enable-mrdisc CFLAGS=-std=gnu99
Thanks for the update. However, passing CFLAGS=-std=gnu99 is not
correct, as it means other Buildroot CFLAGS are no longer passed.
Instead, it should be:
SMCROUTE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS -std=gnu99"
could you see if that works for you, and send an updated version?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-20 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 5:44 [Buildroot] [PATCH 1/1] package/smcroute: bump version to v2.5.0 Joachim Wiberg
2021-08-20 21:32 ` Thomas Petazzoni [this message]
2021-08-21 17:30 ` Joachim Wiberg
2021-08-21 19:38 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820233226.677ff169@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=matthew.weber@collins.com \
--cc=troglobit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox