Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Joachim Wiberg <troglobit@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Matt Weber <matthew.weber@collins.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/smcroute: bump version to v2.5.0
Date: Sat, 21 Aug 2021 19:30:46 +0200	[thread overview]
Message-ID: <87y28upuwp.fsf@gmail.com> (raw)
In-Reply-To: <20210820233226.677ff169@windsurf>


Hi Thomas!

On Fri, Aug 20, 2021 at 23:32, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> On Fri, 20 Aug 2021 07:44:19 +0200 Joachim Wiberg <troglobit@gmail.com> wrote:
>> -SMCROUTE_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
>> +SMCROUTE_CONF_OPTS = --enable-mrdisc CFLAGS=-std=gnu99
> Thanks for the update. However, passing CFLAGS=-std=gnu99 is not
> correct, as it means other Buildroot CFLAGS are no longer passed.

Ouch, that's obviously not what I intended.  Sorry about that,
and thank you for taking the time to review!

> Instead, it should be:
> SMCROUTE_CONF_ENV = CFLAGS="$(TARGET_CFLAGS -std=gnu99"
> could you see if that works for you, and send an updated version?

Thanks, it was a dirty hack.  I'm going to do a new release upstream
instead, but I'll keep this for next time I run into something simiar.

Also, do you think it would be OK to add an init start script and add
the systemd unit file shipped with SMCRoute?  I belive most users would
appreciate an easy way to start the daemon.  They don't need any .conf
file set up, and we can have everything passive by default.


Best regards
 /Joachim
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-21 17:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  5:44 [Buildroot] [PATCH 1/1] package/smcroute: bump version to v2.5.0 Joachim Wiberg
2021-08-20 21:32 ` Thomas Petazzoni
2021-08-21 17:30   ` Joachim Wiberg [this message]
2021-08-21 19:38     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y28upuwp.fsf@gmail.com \
    --to=troglobit@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=matthew.weber@collins.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox