From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@buildroot.org
Cc: Refik Tuzakli <tuzakli.refik@gmail.com>,
Gary Bisson <bisson.gary@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/4] package/freescale-imx/imx-gpu-viv: move pkg-config files fixup to the build step
Date: Fri, 20 Aug 2021 23:37:59 +0200 [thread overview]
Message-ID: <20210820233759.1ecc5c73@windsurf> (raw)
In-Reply-To: <20210805212736.2799576-1-thomas.petazzoni@bootlin.com>
On Thu, 5 Aug 2021 23:27:32 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> The fixup of the pkg-config files modifies files in the build
> directory (@D) but is done in the staging installation step, which
> doesn't make much sense, especially since the build step already has
> some fixup logic. So we move the fixup logic of the pkg-config files
> into the build step.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> .../freescale-imx/imx-gpu-viv/imx-gpu-viv.mk | 22 +++++++++----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
Following the review of Gary, I have applied to next those 4 patches.
Thanks Gary!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-20 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 21:27 [Buildroot] [PATCH 1/4] package/freescale-imx/imx-gpu-viv: move pkg-config files fixup to the build step Thomas Petazzoni
2021-08-05 21:27 ` [Buildroot] [PATCH 2/4] package/freescale-imx/imx-gpu-viv: drop pkg-config files installation Thomas Petazzoni
2021-08-20 13:40 ` Gary Bisson
2021-08-05 21:27 ` [Buildroot] [PATCH 3/4] package/freescale-imx/imx-gpu-viv: make pkg-config fixups mutually exclusive Thomas Petazzoni
2021-08-20 13:41 ` Gary Bisson
2021-08-05 21:27 ` [Buildroot] [PATCH 4/4] package/freescale-imx/imx-gpu-viv: use make loops instead of shell loops Thomas Petazzoni
2021-08-20 13:43 ` Gary Bisson
2021-08-20 13:36 ` [Buildroot] [PATCH 1/4] package/freescale-imx/imx-gpu-viv: move pkg-config files fixup to the build step Gary Bisson
2021-08-20 21:37 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820233759.1ecc5c73@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=bisson.gary@gmail.com \
--cc=buildroot@buildroot.org \
--cc=tuzakli.refik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox