From: Gary Bisson <gary.bisson@boundarydevices.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Gary Bisson <bisson.gary@gmail.com>,
Refik Tuzakli <tuzakli.refik@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/4] package/freescale-imx/imx-gpu-viv: make pkg-config fixups mutually exclusive
Date: Fri, 20 Aug 2021 15:41:55 +0200 [thread overview]
Message-ID: <YR+xIx0OGnpr39Op@p1g2> (raw)
In-Reply-To: <20210805212736.2799576-3-thomas.petazzoni@bootlin.com>
Hi,
On Thu, Aug 05, 2021 at 11:27:34PM +0200, Thomas Petazzoni wrote:
> The IMX_GPU_VIV_FIXUP_PKGCONFIG fixup is defined conditionally
> depending on the value of IMX_GPU_VIV_LIB_TARGET, which means that
> obviously only one of the definitions is possible. Make this clear by
> using a ifeq ... else ifeq ... else ifeq ... endif logic.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Good point, not sure why it wasn't like this since day one.
Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>
Regards,
Gary
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-20 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 21:27 [Buildroot] [PATCH 1/4] package/freescale-imx/imx-gpu-viv: move pkg-config files fixup to the build step Thomas Petazzoni
2021-08-05 21:27 ` [Buildroot] [PATCH 2/4] package/freescale-imx/imx-gpu-viv: drop pkg-config files installation Thomas Petazzoni
2021-08-20 13:40 ` Gary Bisson
2021-08-05 21:27 ` [Buildroot] [PATCH 3/4] package/freescale-imx/imx-gpu-viv: make pkg-config fixups mutually exclusive Thomas Petazzoni
2021-08-20 13:41 ` Gary Bisson [this message]
2021-08-05 21:27 ` [Buildroot] [PATCH 4/4] package/freescale-imx/imx-gpu-viv: use make loops instead of shell loops Thomas Petazzoni
2021-08-20 13:43 ` Gary Bisson
2021-08-20 13:36 ` [Buildroot] [PATCH 1/4] package/freescale-imx/imx-gpu-viv: move pkg-config files fixup to the build step Gary Bisson
2021-08-20 21:37 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR+xIx0OGnpr39Op@p1g2 \
--to=gary.bisson@boundarydevices.com \
--cc=bisson.gary@gmail.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tuzakli.refik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox