From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] support/testing: revert the last change of check_network()
Date: Tue, 24 Aug 2021 23:55:19 +0200 [thread overview]
Message-ID: <20210824235519.4320cc50@windsurf> (raw)
In-Reply-To: <20210824171144.66813-1-romain.naour@gmail.com>
On Tue, 24 Aug 2021 19:11:44 +0200
Romain Naour <romain.naour@gmail.com> wrote:
> check_network() must check the error code of the command
> used to check the network configuration with the value
> passed as argument "exitCode".
>
> But this argument is ignored since this commit [1].
>
> Revert the last change of check_network().
>
> Fixes:
> https://gitlab.com/kubu93/buildroot/-/jobs/1522848308
> https://gitlab.com/kubu93/buildroot/-/jobs/1522848306
>
> [1] afc1ed4d5152e0f6e724e6986a1d12c8001b94fe
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> support/testing/tests/init/base.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-24 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 17:11 [Buildroot] [PATCH] support/testing: revert the last change of check_network() Romain Naour
2021-08-24 21:55 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824235519.4320cc50@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox