* [Buildroot] [PATCH] support/testing: revert the last change of check_network()
@ 2021-08-24 17:11 Romain Naour
2021-08-24 21:55 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Romain Naour @ 2021-08-24 17:11 UTC (permalink / raw)
To: buildroot; +Cc: Romain Naour, Thomas Petazzoni
check_network() must check the error code of the command
used to check the network configuration with the value
passed as argument "exitCode".
But this argument is ignored since this commit [1].
Revert the last change of check_network().
Fixes:
https://gitlab.com/kubu93/buildroot/-/jobs/1522848308
https://gitlab.com/kubu93/buildroot/-/jobs/1522848306
[1] afc1ed4d5152e0f6e724e6986a1d12c8001b94fe
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
support/testing/tests/init/base.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/support/testing/tests/init/base.py b/support/testing/tests/init/base.py
index 6a85b87783..7f12186b73 100644
--- a/support/testing/tests/init/base.py
+++ b/support/testing/tests/init/base.py
@@ -42,4 +42,5 @@ class InitSystemBase(infra.basetest.BRTest):
def check_network(self, interface, exitCode=0):
cmd = "ip addr show {} |grep inet".format(interface)
- self.assertRunOk(cmd)
+ _, exit_code = self.emulator.run(cmd)
+ self.assertEqual(exit_code, exitCode)
--
2.31.1
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-24 21:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-24 17:11 [Buildroot] [PATCH] support/testing: revert the last change of check_network() Romain Naour
2021-08-24 21:55 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox