From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Martin Elshuber <martin.elshuber@theobroma-systems.com>
Cc: "Jérôme Pouiller" <jezz@sysmic.org>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/3] package/strongswan: fix broken dependency relation
Date: Sat, 18 Sep 2021 23:12:46 +0200 [thread overview]
Message-ID: <20210918211246.GC1053080@scaer> (raw)
In-Reply-To: <20210913142652.942533-1-martin.elshuber@theobroma-systems.com>
Martin, All,
On 2021-09-13 16:26 +0200, Martin Elshuber spake thusly:
> The AKA backend for 3GPP2 requires libgmp (see
> https://wiki.strongswan.org/projects/strongswan/wiki/Autoconf). Since
> the AKA backend for 3GPP2 is included by BR2_PACKAGE_STRONGSWAN_EAP,
> when selecting a crypto backend different from
> BR2_PACKAGE_STRONGSWAN_GMP, there is no guarantee the gmp package is
> selected as well. When doing so, make fails since the package is in the
> dependency chain but not selected:
>
> $ make
> Makefile:585: *** gmp is in the dependency chain of strongswan that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop.
> make: *** [Makefile:23: _all] Error 2
>
> To fix this, select BR2_PACKAGE_GMP when selecting BR2_PACKAGE_STRONGSWAN_EAP.
>
> Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com>
Applied to master, thanks.
I was a bit confused as to what would happen if both gmp and other
crypto backend were used to gether, but there are explicitl options to
select each of them at ./configure time, so it seems it should be OK, I
guess...
Regards,
Yann E. MORIN.
> ---
> package/strongswan/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in
> index 47c7107f59..368cd1ecc0 100644
> --- a/package/strongswan/Config.in
> +++ b/package/strongswan/Config.in
> @@ -75,6 +75,7 @@ config BR2_PACKAGE_STRONGSWAN_TNCCS_DYNAMIC
>
> config BR2_PACKAGE_STRONGSWAN_EAP
> bool "Enable EAP protocols"
> + select BR2_PACKAGE_GMP
> help
> Enable various EAP protocols:
> - mschapv2
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-09-18 21:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 14:26 [Buildroot] [PATCH 1/3] package/strongswan: fix broken dependency relation Martin Elshuber
2021-09-13 14:26 ` [Buildroot] [PATCH 2/3] package/strongswan: Add options to select EAP plugins Martin Elshuber
2021-09-18 21:06 ` Yann E. MORIN
2021-09-20 15:14 ` Martin Elshuber
2021-09-20 15:28 ` [Buildroot] [PATCH v2 1/2] " Martin Elshuber
2021-09-27 16:56 ` Arnout Vandecappelle
2021-09-27 17:21 ` Yann E. MORIN
2021-09-28 20:47 ` Yann E. MORIN
2021-09-20 15:28 ` [Buildroot] [PATCH v2 2/2] package/strongswan: add md4 hash algorithm option Martin Elshuber
2021-09-27 17:00 ` Arnout Vandecappelle
2021-09-28 20:26 ` Yann E. MORIN
2021-09-28 20:47 ` Yann E. MORIN
2021-09-13 14:26 ` [Buildroot] [PATCH 3/3] strongswan: " Martin Elshuber
2021-09-18 21:12 ` Yann E. MORIN [this message]
2021-10-04 11:09 ` [Buildroot] [PATCH 1/3] package/strongswan: fix broken dependency relation Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210918211246.GC1053080@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=jezz@sysmic.org \
--cc=martin.elshuber@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox