Re: [Buildroot] [PATCH v2 1/2] package/strongswan: Add options to select EAP plugins

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: buildroot@buildroot.org, "Jérôme Pouiller" <jezz@sysmic.org>,
	"Martin Elshuber" <martin.elshuber@theobroma-systems.com>
Subject: Re: [Buildroot] [PATCH v2 1/2] package/strongswan: Add options to select EAP plugins
Date: Mon, 27 Sep 2021 19:21:55 +0200	[thread overview]
Message-ID: <20210927172155.GA1504958@scaer> (raw)
In-Reply-To: <0b09997d-7df9-2385-aede-f6620d8d3292@mind.be>

Arnout, Martin, All,

On 2021-09-27 18:56 +0200, Arnout Vandecappelle spake thusly:
> On 20/09/2021 17:28, Martin Elshuber wrote:
> >Add options to chose EAP plugins.
> >
> >Since the only plugin requiring libgmp is
> >BR2_PACKAGE_STRONGSWAN_EAP_AKA_3GPP2, the selection of BR2_PACKAGE_GMP
> >is moved down accordingly.
> >
> >Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com>
> >
> >---
> >Changes v1 -> v2:
> >   - use conditional defaults and mark as legacy
> >   - drop 'ifeq ($(BR2_PACKAGE_STRONGSWAN_EAP),y)'
> >   - fix title for BR2_PACKAGE_STRONGSWAN_EAP_DYNAMIC
> >
> >Signed-off-by: Martin Elshuber <martin.elshuber@theobroma-systems.com>
> >---
> >  package/strongswan/Config.in     | 89 +++++++++++++++++++++++++-------
> >  package/strongswan/strongswan.mk | 40 +++++++-------
> >  2 files changed, 87 insertions(+), 42 deletions(-)
> >
> >diff --git a/package/strongswan/Config.in b/package/strongswan/Config.in
> >index 368cd1ecc0..8eae568b6a 100644
> >--- a/package/strongswan/Config.in
> >+++ b/package/strongswan/Config.in
> >@@ -75,34 +75,83 @@ config BR2_PACKAGE_STRONGSWAN_TNCCS_DYNAMIC
> >  config BR2_PACKAGE_STRONGSWAN_EAP
> >  	bool "Enable EAP protocols"
> >-	select BR2_PACKAGE_GMP
> >-	help
> >-	  Enable various EAP protocols:
> >-	    - mschapv2
> >-	    - tls
> >-	    - ttls
> >-	    - peap
> >-	    - sim
> >-	    - sim-file
> >-	    - aka
> >-	    - aka-3gpp2
> >-	    - simaka-sql
> >-	    - simaka-pseudonym
> >-	    - simaka-reauth
> >-	    - identity
> >-	    - md5
> >-	    - gtc
> >-	    - tnc
> >-	    - dynamic
> >-	    - radius
> >  if BR2_PACKAGE_STRONGSWAN_EAP
> >+config BR2_PACKAGE_STRONGSWAN_EAP_SIM
> >+	bool "Enable EAP-SIM"
> >+	default y if BR2_PACKAGE_STRONGSWAN_EAP # legacy
> 
>  This is already inside if BR2_PACKAGE_STRONGSWAN_EAP, so the condition on
> the default is meaningless. Yann said something about this legacy stuff
> which I don't quite follow, since the BR2_PACKAGE_STRONGSWAN_EAP is not
> legacy. Yann, did you mean that BR2_PACKAGE_STRONGSWAN_EAP should be removed
> (i.e. moved to Config.in.legacy), or was it a mistake?

Yes, BR2_PACKAGE_STRONGSWAN_EAP should be moved to legacy, i.e. to
Config.in.legacy. Sorry, I was not so clear in my previous review...

My understanding is that, with this change, BR2_PACKAGE_STRONGSWAN_EAP
by itself will no longer enable/disable anything; only the new
sub-options will.

As such, BR2_PACKAGE_STRONGSWAN_EAP serves no other purpose that to
hide/show a bunch of options; this is superfluous. Hence, my suggestion
to move it to legacy.

Regards,
Yann E. MORIN.

>  Regards,
>  Arnout
> 
> [snip]

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot